[CONTP-1596]Improve GKE Autopilot support#3013
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d80ce13ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (73.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
+ Coverage 42.24% 42.68% +0.44%
==========================================
Files 337 337
Lines 28951 29046 +95
==========================================
+ Hits 12230 12399 +169
+ Misses 15916 15830 -86
- Partials 805 817 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
7d80ce1 to
5f79f93
Compare
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: a1ae71b | Docs | Datadog PR Page | Give us feedback! |
1e614a8 to
7cf3137
Compare
|
Botched rebase, ignore the pings, sorry for that! |
51f1b85 to
5c6d883
Compare
5c6d883 to
a1ae71b
Compare
What does this PR do?
Updates GKE Autopilot support for DatadogAgent reconciliation and the GKE WorkloadAllowlist synchronizer.
Commit breakdown:
972a0b2
v1.0.5.experimental.agent.datadoghq.com/autopilot-allowlist-versionoverride.AllowlistSynchronizerwith operator ownership labels, including the DatadogAgentapp.kubernetes.io/part-ofvalue.AllowlistSynchronizerwith server-side apply so existingdatadog-synchronizerobjects are updated when the desired allowlist path or labels change.allowlistsynchronizers.auto.gke.iofor server-side apply.e7042a2
DD_KUBELET_USE_API_SERVER=truefor Autopilot.get/listRBAC when API-server pod discovery is required.0a9040e
7dce32e
4d41757
a1ae71b
Motivation
The existing Autopilot overrides were out of date with current GKE Autopilot allowlist behavior and left several generated pod specs with resources, mounts, or discovery settings that are not valid on Autopilot.
This also makes the WorkloadAllowlist version explicit and overrideable, so future allowlist bumps do not require changing the synchronizer logic.
Additional Notes
mainwith the Autopilot work grouped into reviewable commits. Two unrelated unused helper functions from the original branch history were intentionally left out ofcontroller_v2_test.go.v1.0.5Datadog WorkloadAllowlist.Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Verified on
v1.35.3-gke.1737000go test ./pkg/allowlistsynchronizerChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel