Skip to content

Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009

Merged
levan-m merged 9 commits into
mainfrom
levan-m/providers-ddai
Jun 2, 2026
Merged

Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009
levan-m merged 9 commits into
mainfrom
levan-m/providers-ddai

Conversation

@levan-m

@levan-m levan-m commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

CONTP-1570

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Deploy agent with annotated DDA

apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  annotations:
    datadoghq.com/provider: eks-ec2-use-hostname-from-file
...

verify mounts/env var are present on init-config and agent containers:

  env:
    - name: DD_HOSTNAME_FILE
      value: /var/lib/cloud/data/instance-id
...
    volumeMounts:
    - mountPath: /var/lib/cloud/data/instance-id
      name: cloudinit-instance-id-file
...
  volumes:
  - hostPath:
      path: /var/lib/cloud/data/instance-id
      type: File
    name: cloudinit-instance-id-file

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@levan-m levan-m added this to the v1.28.0 milestone May 12, 2026
@levan-m levan-m added the enhancement New feature or request label May 12, 2026
@levan-m levan-m changed the title Levan m/providers ddai Provider capabilities basic framework and eks.ec2.useHostnameFromFile support May 12, 2026
@codecov-commenter

codecov-commenter commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.89%. Comparing base (a4fd8d9) to head (a02e595).

Files with missing lines Patch % Lines
...datadogagent/providercaps/provider_capabilities.go 0.00% 66 Missing ⚠️
...datadogagentinternal/controller_reconcile_agent.go 0.00% 7 Missing ⚠️
...er/datadogagentinternal/controller_reconcile_v2.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3009      +/-   ##
==========================================
- Coverage   43.00%   42.89%   -0.11%     
==========================================
  Files         339      340       +1     
  Lines       29228    29301      +73     
==========================================
  Hits        12570    12570              
- Misses      15836    15909      +73     
  Partials      822      822
Flag Coverage Δ
unittests 42.89% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogagent/feature/types.go 22.10% <ø> (ø)
pkg/kubernetes/provider.go 86.36% <ø> (ø)
...er/datadogagentinternal/controller_reconcile_v2.go 0.00% <0.00%> (ø)
...datadogagentinternal/controller_reconcile_agent.go 4.16% <0.00%> (-0.22%) ⬇️
...datadogagent/providercaps/provider_capabilities.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fd8d9...a02e595. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official

datadog-official Bot commented May 12, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown

Code Coverage  Pipelines

✨ Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

• Patch coverage: 0.00% (threshold: 80.00%)

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-operator | e2e: [1.32]   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Job failed due to timeout: execution took longer than 1h0m0s seconds.

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 43.23% (-0.11%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a02e595 | Docs | Datadog PR Page | Give us feedback!

@levan-m
levan-m marked this pull request as ready for review May 13, 2026 00:50
@levan-m
levan-m requested a review from a team as a code owner May 13, 2026 00:50
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 13, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97d838ec57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/controller/datadogagent/global/provider_spec.go
tbavelier
tbavelier approved these changes May 19, 2026
View reviewed changes

@tbavelier tbavelier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the PR directly, but this option is not always compatible with EC2 depending on the underlying image, e.g. I think this file is not available on Bottlerocket nodes/can't be mounted due to system restrictions but to be investigated

@levan-m
levan-m changed the base branch from levan-m/drop-feature-provider to main May 29, 2026 21:21
@levan-m
levan-m requested review from a team as code owners May 29, 2026 21:21
@levan-m
levan-m requested review from a team as code owners May 29, 2026 21:21
@levan-m
levan-m requested review from AmitaiBl, agagniere and embeaken and removed request for a team May 29, 2026 21:21
@levan-m
levan-m changed the base branch from main to levan-m/drop-feature-provider May 30, 2026 00:56
@vitkyrka
vitkyrka removed the request for review from a team June 1, 2026 07:50
Base automatically changed from levan-m/drop-feature-provider to main June 1, 2026 22:58
@gh-worker-ownership-write-b05516
gh-worker-ownership-write-b05516 Bot removed the request for review from a team June 2, 2026 00:16
@levan-m

levan-m commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

Not related to the PR directly, but this option is not always compatible with EC2 depending on the underlying image, e.g. I think this file is not available on Bottlerocket nodes/can't be mounted due to system restrictions but to be investigated

@tbavelier once all providers are supported will add documentation about their usage and applicability.

@levan-m
levan-m merged commit bd0f5e2 into main Jun 2, 2026
36 of 38 checks passed
@levan-m
levan-m deleted the levan-m/providers-ddai branch June 2, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@tbavelier tbavelier tbavelier approved these changes
@agagniere agagniere Awaiting requested review from agagniere agagniere was automatically assigned from DataDog/opentelemetry-agent
@embeaken embeaken Awaiting requested review from embeaken embeaken was automatically assigned from DataDog/action-platform
@AmitaiBl AmitaiBl Awaiting requested review from AmitaiBl AmitaiBl was automatically assigned from DataDog/cloud-network-monitoring

Assignees

No one assigned

Labels

enhancement New feature or request team/container-platform

Projects

None yet

Milestone

v1.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@levan-m @codecov-commenter @tbavelier