fix: make apm config a pointer#2995
Merged
Merged
Conversation
This commit makes the APM configuration a pointer so that we can properly nil check it in the handler.
Mathew-Estafanous
approved these changes
May 8, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
=======================================
Coverage 40.76% 40.76%
=======================================
Files 332 332
Lines 28197 28197
=======================================
Hits 11494 11494
Misses 15928 15928
Partials 775 775
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
hmahmood
approved these changes
May 8, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
Mathew-Estafanous
added a commit
that referenced
this pull request
May 14, 2026
This reverts commit 6416ca2.
3 tasks
tbavelier
pushed a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit makes the APM configuration a pointer so that we can properly nil check it in the handler.
Motivation
In the Datadog Agent, we want the handler for this config to look like:
We can't currently nil check it because it's not a pointer 🤦 .
Describe your test plan
I made sure the generation works as expected:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel