[CASCL-1323] chore(kubectl-datadog): split autoscaling install.go into smaller files by L3n41c · Pull Request #2968 · DataDog/datadog-operator

L3n41c · 2026-05-04T13:27:12Z

Replaces #2967 (closed by an unintended GitHub branch-rename side effect when the Jira reference was added retroactively to the branch name).

What does this PR do?

Splits the 705-line cmd/kubectl-datadog/autoscaling/cluster/install/install.go (and its 444-line test) into smaller, more cohesive files within the same Go package. No behavior change — the logical content (excluding comments, blank lines, and import blocks) is byte-identical to before.

Layout after the split:

File	Content
`install_mode.go`	`InstallMode` pflag enum + `String/Set/Type`
`create_karpenter_resources.go`	`CreateKarpenterResources` pflag enum + methods
`inference_method.go`	`InferenceMethod` pflag enum + methods
`install.go` (slim)	Cobra command wiring — flag-bound globals, `options`, `complete`, `validate`
`steps.go`	Orchestration — `run()` + individual steps (CFN stacks, aws-auth, Helm, NodePool, cluster-info snapshot) + display messages + embedded CFN templates

Tests are split symmetrically.

Motivation

The parent PR #2961 introducing kubectl datadog autoscaling cluster install has become too large to review comfortably. Splitting install.go into smaller files makes incoming reviews and follow-ups (notably a future update subcommand that will reuse steps.go) easier to land.

The split also reflects the intended division of labour for the future update:

The cobra layer (install.go) will be duplicated by update.
The orchestration (steps.go) will be reused by update once run() is parameterized to drop its dependency on the install-package globals (deferred to that follow-up PR).

Additional Notes

The pflag boilerplate (three enum types × String/Set/Type) lives in dedicated files now; it was crowding the install logic in the original file.
steps.go still contains (*options).run and (*options).installHelmChart coupled to the install globals — parameterization is intentionally out of scope here and will be done as part of the PR that introduces update.

Minimum Agent Versions

Not applicable — refactor only, no runtime change.

Agent: n/a
Cluster Agent: n/a

Describe your test plan

Pure file-level reorganization, mechanically verified:

go build ./... passes
go test ./cmd/kubectl-datadog/autoscaling/cluster/install/... — all tests pass
make lint — 0 issues
Sorted-line diff between original install.go (resp. install_test.go) and the union of the new files is empty modulo comments / blank lines / package+import lines
CI green

Checklist

PR has at least one valid label: refactoring
qa/skip-qa label set (no runtime behavior changes)
All commits are signed

codecov-commenter · 2026-05-04T13:38:57Z

Codecov Report

❌ Patch coverage is 30.31250% with 223 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.41%. Comparing base (1ed0fbc) to head (66ec55f).

Files with missing lines	Patch %	Lines
...bectl-datadog/autoscaling/cluster/install/steps.go	20.07%	223 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2968   +/-   ##
=======================================
  Coverage   41.41%   41.41%           
=======================================
  Files         327      331    +4     
  Lines       28891    28891           
=======================================
  Hits        11964    11964           
  Misses      16072    16072           
  Partials      855      855

Flag	Coverage Δ
unittests	`41.41% <30.31%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ling/cluster/install/create_karpenter_resources.go	`100.00% <100.00%> (ø)`
...og/autoscaling/cluster/install/inference_method.go	`100.00% <100.00%> (ø)`
...ctl-datadog/autoscaling/cluster/install/install.go	`27.90% <ø> (-2.13%)`	⬇️
...atadog/autoscaling/cluster/install/install_mode.go	`100.00% <100.00%> (ø)`
...bectl-datadog/autoscaling/cluster/install/steps.go	`20.07% <20.07%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed0fbc...66ec55f. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…o smaller files Pure file-level reorganization within the install package — no behavior changes. Prepares for a future `update` subcommand that will reuse the orchestration in steps.go (the install command is already idempotent and most of its logic carries over). Layout: - install_mode.go, create_karpenter_resources.go, inference_method.go: pflag enum types and their String/Set/Type receiver methods (verbose boilerplate that obscured the install logic in the original file). - install.go (now slim): cobra command wiring — flag-bound globals, options struct, complete/validate. To be duplicated by `update`. - steps.go: orchestration — run() plus the individual steps (CloudFormation stacks, aws-auth ConfigMap, Helm release, NodePool resources, cluster-info snapshot) and the display messages. To be reused by `update` once run() is parameterized. Tests are split symmetrically. Logical content (excluding comments, blank lines, and import blocks) is byte-identical to the original. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

L3n41c · 2026-05-04T15:27:57Z

This PR only moves lines of code and GitHub isn’t very good at showing that lines of code have been moved and not just deleted and added elsewhere.

I’d recommend a command like like:

$ git diff --stat -p -n 1 --find-copies --color-moved origin/main...origin/lenaic/CASCL-1292-split-install-go

to validate that code has been moved and not changed.

…tallation PR #2968 split install.go into multiple files; the foreign-Karpenter detection block and `displayForeignKarpenterMessage` moved to steps.go, and the matching tests moved to steps_test.go. Conflicts resolved by taking origin/main's slim install.go / install_test.go and re-applying this branch's `FindKarpenterInstallation` + `KarpenterInstallation` adaptation against the new locations (steps.go callsite + display signature; steps_test.go type + assertion message). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

L3n41c added refactoring qa/skip-qa labels May 4, 2026

L3n41c mentioned this pull request May 4, 2026

[CASCL-1292] chore(kubectl-datadog): split autoscaling install.go into smaller files #2967

Closed

8 tasks

github-actions Bot added the team/container-autoscaling label May 4, 2026

This comment has been minimized.

Sign in to view

L3n41c changed the title ~~[CASCL-1292] chore(kubectl-datadog): split autoscaling install.go into smaller files~~ [CASCL-1292] chore(kubectl-datadog): split autoscaling install.go into smaller files May 4, 2026

L3n41c force-pushed the lenaic/CASCL-1292-split-install-go branch from 1e9e6f5 to 66ec55f Compare May 4, 2026 14:44

L3n41c changed the title ~~[CASCL-1292] chore(kubectl-datadog): split autoscaling install.go into smaller files~~ [CASCL-1323] chore(kubectl-datadog): split autoscaling install.go into smaller files May 4, 2026

L3n41c marked this pull request as ready for review May 4, 2026 15:23

L3n41c requested a review from a team May 4, 2026 15:23

L3n41c requested a review from a team as a code owner May 4, 2026 15:23

clamoriniere approved these changes May 4, 2026

View reviewed changes

gabedos approved these changes May 4, 2026

View reviewed changes

L3n41c merged commit 35814b5 into main May 4, 2026
40 of 43 checks passed

L3n41c deleted the lenaic/CASCL-1292-split-install-go branch May 4, 2026 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CASCL-1323] chore(kubectl-datadog): split autoscaling install.go into smaller files#2968

[CASCL-1323] chore(kubectl-datadog): split autoscaling install.go into smaller files#2968
L3n41c merged 1 commit into
mainfrom
lenaic/CASCL-1292-split-install-go

L3n41c commented May 4, 2026

Uh oh!

codecov-commenter commented May 4, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

L3n41c commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

L3n41c commented May 4, 2026

What does this PR do?

Motivation

Additional Notes

Minimum Agent Versions

Describe your test plan

Checklist

Uh oh!

codecov-commenter commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

L3n41c commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented May 4, 2026 •

edited

Loading