Skip to content

[Backport v1.26] Comment out flaky test#2933

Merged
khewonc merged 1 commit into
v1.26from
backport-2932-to-v1.26
Apr 24, 2026
Merged

[Backport v1.26] Comment out flaky test#2933
khewonc merged 1 commit into
v1.26from
backport-2932-to-v1.26

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Apr 24, 2026

Copy link
Copy Markdown

Backport 039572f from #2932.


What does this PR do?

Comment out flaky test

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

(cherry picked from commit 039572f)
@dd-octo-sts dd-octo-sts Bot added bug Something isn't working qa/skip-qa labels Apr 24, 2026
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner April 24, 2026 13:38
@dd-octo-sts dd-octo-sts Bot added backport label added by backport action bot label added by backport bot team/container-platform labels Apr 24, 2026
@dd-octo-sts dd-octo-sts Bot added this to the v1.26.0 milestone Apr 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aca04e79bf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}
}
}
// func Test_Experiment_StateTransitions(t *testing.T) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Disable flaky test via t.Skip instead of commenting it out

Commenting out Test_Experiment_StateTransitions removes the entire 24-scenario state-transition matrix from the runnable test suite, so regressions in restart behavior after terminal phases can ship without signal. Keeping the function registered and using t.Skip("flaky: <tracking issue>") preserves visibility in test listings, keeps the code compiling as helpers evolve, and makes it easier to re-enable targeted subcases once the flake is fixed.

Useful? React with 👍 / 👎.

@codecov-commenter

codecov-commenter commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.52%. Comparing base (c3d0d96) to head (aca04e7).
⚠️ Report is 2 commits behind head on v1.26.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.26    #2933      +/-   ##
==========================================
+ Coverage   40.05%   40.52%   +0.46%     
==========================================
  Files         319      320       +1     
  Lines       28052    28376     +324     
==========================================
+ Hits        11237    11500     +263     
- Misses      15993    16032      +39     
- Partials      822      844      +22     
Flag Coverage Δ
unittests 40.52% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974005b...aca04e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khewonc
khewonc merged commit 554029b into v1.26 Apr 24, 2026
54 of 62 checks passed
@khewonc
khewonc deleted the backport-2932-to-v1.26 branch April 24, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport label added by backport action bot label added by backport bot bug Something isn't working qa/skip-qa team/container-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants