Comment out flaky test#2932
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b04397950
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| } | ||
| } | ||
| // func Test_Experiment_StateTransitions(t *testing.T) { |
There was a problem hiding this comment.
Commenting out Test_Experiment_StateTransitions removes the only matrix test that exercises new experiments after all terminal prior states (promoted, rollback, timeout, aborted) and both fresh/stale revision timestamps. The remaining tests in this file validate only narrower paths (primarily promoted), so regressions in rollback/timeout/aborted transition handling can now pass CI and reach users undetected.
Useful? React with 👍 / 👎.
tbavelier
left a comment
tbavelier
left a comment
There was a problem hiding this comment.
No more flakes:
FAIL
FAIL github.com/DataDog/datadog-operator/internal/controller/datadogagent 206.254s
FAIL
╭─ ~/dd/datadog-operator main 3.12 15:25:11
╰─❯ git checkout khewonc/flaky-test
branch 'khewonc/flaky-test' set up to track 'origin/khewonc/flaky-test'.
Switched to a new branch 'khewonc/flaky-test'
╭─ ~/dd/datadog-operator khewonc/flaky-test 3.12 15:25:14
╰─❯ go test ./internal/controller/datadogagent/ -count=20
ok github.com/DataDog/datadog-operator/internal/controller/datadogagent 151.063s
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
=======================================
Coverage 40.69% 40.69%
=======================================
Files 321 321
Lines 28413 28413
=======================================
Hits 11563 11563
Misses 16015 16015
Partials 835 835
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
(cherry picked from commit 039572f) Co-authored-by: khewonc <[email protected]>
3 participants
What does this PR do?
Comment out flaky test
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel