Update access flag only if informer succeeded#2894
Merged
levan-m merged 1 commit intoApr 13, 2026
Merged
Conversation
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## levan-m/cm-watch-without-rbac #2894 +/- ##
=================================================================
- Coverage 40.05% 40.04% -0.01%
=================================================================
Files 319 319
Lines 28046 28050 +4
=================================================================
Hits 11233 11233
- Misses 15990 15994 +4
Partials 823 823
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
levan-m
approved these changes
Apr 13, 2026
tbavelier
added a commit
that referenced
this pull request
Apr 14, 2026
* Avoid RBAC errors when Operator can't list or watch ConfigMaps * Update access flag only if informer succeeded (#2894) --------- Co-authored-by: Timothée Bavelier <[email protected]>
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
* Avoid RBAC errors when Operator can't list or watch ConfigMaps * Update access flag only if informer succeeded (#2894) --------- Co-authored-by: Timothée Bavelier <[email protected]> (cherry picked from commit d09fcb3)
tbavelier
added a commit
that referenced
this pull request
Apr 14, 2026
#2900) * Avoid RBAC errors when Operator can't list or watch ConfigMaps * Update access flag only if informer succeeded (#2894) --------- (cherry picked from commit d09fcb3) Co-authored-by: levan-m <[email protected]> Co-authored-by: Timothée Bavelier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel