Skip to content

Remove early exit in credential-dependent controllers when credentials are missing (#2530)#2549

Merged
fanny-jiang merged 1 commit into
v1.23from
fanny/cherry-pick-2530
Jan 29, 2026
Merged

Remove early exit in credential-dependent controllers when credentials are missing (#2530)#2549
fanny-jiang merged 1 commit into
v1.23from
fanny/cherry-pick-2530

Conversation

@fanny-jiang

@fanny-jiang fanny-jiang commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Cherry-pick #2530

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@fanny-jiang
Remove early exit in credential-dependent controllers when credential…
1bf1ada 
…s are missing (#2530)

* Revert "[AGENTONB-1702] Early exit if no credentials despite controllers requiring them (#2387)"

This reverts commit 39bd16a.

* remove fail-fast for datadogMonitor controller
@fanny-jiang fanny-jiang added this to the v1.23.0 milestone Jan 28, 2026
@fanny-jiang
fanny-jiang requested a review from a team as a code owner January 28, 2026 21:06
@fanny-jiang fanny-jiang added bug Something isn't working qa/skip-qa labels Jan 28, 2026
@codecov-commenter

codecov-commenter commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.73%. Comparing base (78652b2) to head (1bf1ada).
⚠️ Report is 11 commits behind head on v1.23.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.23    #2549      +/-   ##
==========================================
- Coverage   37.79%   37.73%   -0.06%     
==========================================
  Files         303      303              
  Lines       25969    25956      -13     
==========================================
- Hits         9815     9795      -20     
- Misses      15411    15418       +7     
  Partials      743      743
Flag Coverage Δ
unittests 37.73% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/main.go 0.00% <ø> (-6.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78652b2...1bf1ada. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fanny-jiang
fanny-jiang merged commit ad71b5e into v1.23 Jan 29, 2026
36 checks passed
@fanny-jiang
fanny-jiang deleted the fanny/cherry-pick-2530 branch January 29, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khewonc khewonc khewonc approved these changes

Assignees

No one assigned

Labels

bug Something isn't working qa/skip-qa

Projects

None yet

Milestone

v1.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fanny-jiang @codecov-commenter @khewonc