Remove early exit in credential-dependent controllers when credentials are missing#2530
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
- Coverage 37.87% 37.84% -0.03%
==========================================
Files 303 303
Lines 26003 25990 -13
==========================================
- Hits 9849 9837 -12
+ Misses 15411 15410 -1
Partials 743 743
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.23 v1.23
# Navigate to the new working tree
cd .worktrees/backport-v1.23
# Create a new branch
git switch --create backport-2530-to-v1.23
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a04b5dc214d6d289595b6598bf705d30319c9f0
# Push it to GitHub
git push --set-upstream origin backport-2530-to-v1.23
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.23Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.23 v1.23
# Navigate to the new working tree
cd .worktrees/backport-v1.23
# Create a new branch
git switch --create backport-2530-to-v1.23
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a04b5dc214d6d289595b6598bf705d30319c9f0
# Push it to GitHub
git push --set-upstream origin backport-2530-to-v1.23
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.23Then, create a pull request where the |
What does this PR do?
Motivation
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Reproducing the bug:
CrashLoopBackOff. In the Operator logs, you'll seeerrors about missing credentials for the datadogSLO and datadogGenericResource controllers:
DD_API_KEYandDD_APP_KEYenv vars are not set. Perform ahelm upgrade, and check the operator deployment again. The env vars should now be present and the operator pod should stop crashing.QA'ing the changes:
operator.*overrides:helm upgrade. Those errors should not be present in the new operator pod and the operator deployment YAML should have the API/APP key env vars present.examplesfolder and they should work as normal.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel