(No-op) SA1019: Remove deprecated functions usage#2478
Merged
tbavelier merged 8 commits intoApr 15, 2026
Conversation
…lTrafficPolicyType
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) 🔗 Commit SHA: eed36b0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
short-circuited on result.Requeue, effectively treating the RequeueAfter result from tag injection as a local "tags were updated" signal rather than generic reconcile flow control. The SA1019 cleanup replaced that logic with !result.IsZero(), but that broadened the condition and caused the controller to return early on any non-zero result. In the required-tag path, that changed behavior by routing control through a generic Result check instead of an explicit "tags were updated" signal. Refactor checkRequiredTags() to return (bool, error) instead: true, nil when tags were added false, err when the update failed false, nil when nothing changed This keeps the deprecation cleanup while making the tag-update path intentional and avoiding misuse of IsZero() for local control flow.
gabedos
approved these changes
Apr 14, 2026
tbavelier
deleted the
tbavelier/remove-deprecated-functions-usage-on-main
branch
April 15, 2026 06:46
nlchung
added a commit
that referenced
this pull request
Apr 17, 2026
* [CONTP-1335] organizing finalizers initial PR * reverted bug fix * Fix HandleFinalizer deletion-path return and remove redundant caller guards HandleFinalizer was missing a return on the deletion path, causing reconciliation to continue into create/update logic. Remove the compensating GetDeletionTimestamp checks from all 5 callers, fix SLO deleteResource closure capture, and improve finalizer test coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * added finalizer and error requeue periods * fix: requeue after adding finalizer to match original controller behavior HandleFinalizer was falling through after adding a finalizer instead of requeuing, causing controllers to run create/update logic on the same reconcile pass. This broke the datadogmonitor unsupported-type and datadogslo create-failure test cases. Updated SLO tests to reconcile twice (once for finalizer, once for actual logic). * fix: use immediate requeue after adding finalizer for controllers that had Requeue:true The old datadogagent, datadogagentinternal, datadogdashboard, and datadoggenericresource controllers all used Requeue:true (immediate) after adding a finalizer, while datadogmonitor/datadogslo used RequeueAfter with a period. The shared HandleFinalizer now supports both: pass 0 for immediate requeue, or a duration for delayed requeue. This fixes the 34 integration test timeouts where the 60s requeue delay exceeded the 10s test timeout. * fix: use defaultErrRequeuePeriod for all controllers after adding finalizer All migrated controllers now pass defaultErrRequeuePeriod (5s) as the requeue period when adding a finalizer, consistent with the existing datadogslo pattern. Removes the Requeue:true special case for zero period from HandleFinalizer. * refactor: simplify HandleFinalizer to use immediate requeue, revert unrelated changes - Remove defaultRequeuePeriod param from NewFinalizer; HandleFinalizer now always uses immediate requeue (Requeue: true) after adding a finalizer or while waiting for deletion, matching the original behavior of most controllers. - Revert result.IsZero() cleanup and checkRequiredTags signature refactor as they are out of scope for this ticket. * fix: restore SA1019 cleanup from #2478 that was inadvertently reverted The previous "revert unrelated changes" commit rolled main's post-#2478 state back to pre-#2478, undoing the deprecated-Requeue-field cleanup and the checkRequiredTags (bool, error) signature. Restore main's current state for those call sites so this PR is limited to the finalizer reorganization. * reinstated default requeue period and implemented deletion requeue period * fixing naming inconsistency --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Tested the plugin manually, verified metrics forwarder is still working and is stopped on object removal
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel