Skip to content

[AGENTONB-1702] Early exit if no credentials despite controllers requiring them#2387

Merged
tbavelier merged 1 commit into
mainfrom
tbavelier/check-credentials-controllers
Dec 10, 2025
Merged

[AGENTONB-1702] Early exit if no credentials despite controllers requiring them#2387
tbavelier merged 1 commit into
mainfrom
tbavelier/check-credentials-controllers

Conversation

@tbavelier

@tbavelier tbavelier commented Dec 9, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Errors out and quits the manager process if credentials are not present despite being required for controllers to work

Motivation

This pattern existed for DatadogMonitor solely, but other resource controllers can benefit from it

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Start with usual deploy (e.g. make deploy) without creds and ensure manager process runs since no resource controllers but Agent is enabled ootb
  • Enable generic resource controller and verifies it errors out and CLBOs:
    {"level":"ERROR","ts":"2025-12-09T14:56:10.809Z","logger":"setup","msg":"Unable to retrieve Datadog API credentials required by one or more enabled controllers","DatadogMonitor":false,"DatadogDashboard":false,"DatadogSLO":false,"DatadogGenericResource":true,"error":"empty API key and/or App key","stacktrace":"main.setupErrorf\n\t/workspace/cmd/main.go:509\nmain.run\n\t/workspace/cmd/main.go:265\nmain.main\n\t/workspace/cmd/main.go:204\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:285"}
    ╰─❯ k get pod
    NAME                                        READY   STATUS             RESTARTS      AGE
    datadog-operator-manager-67b79b87df-4t6zc   0/1     CrashLoopBackOff   2 (20s ago)   44s
  • Add api key and app key foo and verifies it recovers/is able to run without the error

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added this to the v1.22.0 milestone Dec 9, 2025
@tbavelier
tbavelier requested a review from a team as a code owner December 9, 2025 14:58
@tbavelier tbavelier added the enhancement New feature or request label Dec 9, 2025
@codecov-commenter

codecov-commenter commented Dec 9, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.97%. Comparing base (77aedeb) to head (2d1f8de).
⚠️ Report is 228 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 81.81% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
+ Coverage   36.90%   36.97%   +0.06%     
==========================================
  Files         286      286              
  Lines       24116    24125       +9     
==========================================
+ Hits         8900     8920      +20     
+ Misses      14518    14507      -11     
  Partials      698      698              
Flag Coverage Δ
unittests 36.97% <81.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/main.go 7.01% <81.81%> (+7.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aedeb...2d1f8de. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier
tbavelier merged commit 39bd16a into main Dec 10, 2025
36 checks passed
@tbavelier
tbavelier deleted the tbavelier/check-credentials-controllers branch December 10, 2025 07:50
fanny-jiang added a commit that referenced this pull request Jan 27, 2026
fanny-jiang added a commit that referenced this pull request Jan 28, 2026
…s are missing (#2530)

* Revert "[AGENTONB-1702] Early exit if no credentials despite controllers requiring them (#2387)"

This reverts commit 39bd16a.

* remove fail-fast for datadogMonitor controller
fanny-jiang added a commit that referenced this pull request Jan 28, 2026
…s are missing (#2530)

* Revert "[AGENTONB-1702] Early exit if no credentials despite controllers requiring them (#2387)"

This reverts commit 39bd16a.

* remove fail-fast for datadogMonitor controller
fanny-jiang added a commit that referenced this pull request Jan 29, 2026
…s are missing (#2530) (#2549)

* Revert "[AGENTONB-1702] Early exit if no credentials despite controllers requiring them (#2387)"

This reverts commit 39bd16a.

* remove fail-fast for datadogMonitor controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants