feat: Support proxy for debugger endpoint v2#918
Merged
Conversation
lym953
commented
Nov 10, 2025
| .route(LLM_OBS_SPANS_ENDPOINT_PATH, post(Self::llm_obs_spans_proxy)) | ||
| .route(DEBUGGER_ENDPOINT_PATH, post(Self::debugger_logs_proxy)) | ||
| .route(V1_DEBUGGER_ENDPOINT_PATH, post(Self::debugger_logs_proxy)) | ||
| .route(V2_DEBUGGER_ENDPOINT_PATH, post(Self::debugger_logs_proxy)) |
Contributor
Author
There was a problem hiding this comment.
Is it correct to use Self::debugger_logs_proxy? Should any param here be different?
datadog-lambda-extension/bottlecap/src/traces/trace_agent.rs
Lines 388 to 398 in 0a5e11e
Contributor
There was a problem hiding this comment.
Sorry, I was incorrect in Slack. After looking at the datadog-agent code, it looks like the params changed in v2. See the suggested code changes in the other comments
lym953
marked this pull request as ready for review
November 10, 2025 20:36
nhulston
reviewed
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Suggested change
| const V1_DEBUGGER_LOGS_INTAKE_PATH: &str = "/api/v2/logs"; | |
| const V2_DEBUGGER_INTAKE_PATH: &str = "/api/v2/debugger"; |
nhulston
reviewed
Nov 10, 2025
nhulston
approved these changes
Nov 10, 2025
nhulston
left a comment
nhulston
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Can we test in a real Lambda before merging?
Contributor
Author
|
Tested. Will merge after v89 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we support proxying requests from
/debugger/v1/input. This PR adds/debugger/v2/inputand/debugger/v1/diagnostics.#925
Test
Steps
DD_TRACE_DEBUGtotrueResult
Before:
debugger::unsupported_agentUnsupported Datadog agent detected. Snapshots from Dynamic Instrumentation/Exception Replay/Code Origin for Spans will not be uploaded. Please upgrade to version 7.49.0 or laterAfter:
Detected /debugger/v2/input endpointNotes
Thanks @nhulston @joeyzhao2018 @purple4reina for discussion and helping debug.