[SVLS-7885] update tag splitting to allow for ',' and ' '#916
Merged
Conversation
astuyve
approved these changes
Nov 6, 2025
litianningdatadog
requested changes
Nov 6, 2025
litianningdatadog
requested changes
Nov 6, 2025
| } | ||
| let parts = tag.split(':').collect::<Vec<&str>>(); | ||
| if parts.len() == 2 { | ||
| map.insert(parts[0].to_string(), parts[1].to_string()); |
Contributor
There was a problem hiding this comment.
In fact I meant to change below to skip empty key or value
if parts.len() == 2 && !parts[0].is_empty() && !parts[1].is_empty()
litianningdatadog
approved these changes
Nov 7, 2025
duncanpharvey
pushed a commit
that referenced
this pull request
Mar 10, 2026
## Overview We currently split the`DD_TAGS` only by `,`. Customer is asking if we can also split by spaces since that is common for container images and lambda lets you deploy images. (https://docs.datadoghq.com/getting_started/tagging/assigning_tags/?tab=noncontainerizedenvironments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We currently split the
DD_TAGSonly by,. Customer is asking if we can also split by spaces since that is common for container images and lambda lets you deploy images. (https://docs.datadoghq.com/getting_started/tagging/assigning_tags/?tab=noncontainerizedenvironments)