feat: [Trace Stats] Do not set ClientStatsPayload.hostname#905
Merged
Conversation
lym953
commented
Oct 23, 2025
| Some(ClientStatsPayload { | ||
| hostname: self.hostname.clone(), | ||
| // Do not set hostname so the trace stats backend can aggregate stats properly | ||
| hostname: String::new(), |
Contributor
Author
There was a problem hiding this comment.
This is the main change. Other code changes are just removing the unused self.hostname.
lym953
marked this pull request as ready for review
October 23, 2025 16:21
duncanista
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
As APM Stats team suggested,
ClientStatsPayload.hostnameshould be left empty so the trace stats backend can aggregate stats properly.Testing
Still some undercounting. Expecting 5000 for the
highvolume(with concurrency) tests, but seeing 4xxx for some runtimes. Will keep investigating.Notes
#688
https://datadoghq.atlassian.net/browse/SVLS-6907