fix(logs): use channel-based aggregator#879
Merged
Merged
Conversation
shreyamalpani
marked this pull request as ready for review
October 1, 2025 15:03
duncanista
reviewed
Oct 1, 2025
duncanista
reviewed
Oct 1, 2025
duncanista
approved these changes
Oct 1, 2025
duncanista
left a comment
duncanista
left a comment
Contributor
There was a problem hiding this comment.
LGTM – left some comments, and we also talked about some other improvements which I expect to be there before merging, so this can unblock you 
shreyamalpani
added a commit
that referenced
this pull request
Oct 28, 2025
Use a channel-based aggregator for traces to avoid locking on aggregation. Adds an aggregator service which receives incoming commands on a channel. Commands can be to insert payloads, get batches, and shutdown. Follows a similar pattern as #879. Tested with self-monitoring and tested that dual shipping still works as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a channel-based aggregator for logs to avoid locking on aggregation. Adds an aggregator service which receives incoming commands on a channel. Commands can be flush requests, inserts, or shutdowns.
Follows a similar pattern as DataDog/serverless-components#32
Tested that dual shipping still works as well.
SVLS-7646