[Serverless-Init] Build serverless-init with zstd enabled#878
Merged
Conversation
duncanista
approved these changes
Sep 29, 2025
nhulston
deleted the
nicholas.hulston/build-serverless-init-with-zstd
branch
September 29, 2025 21:15
dd-mergequeue Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 29, 2025
### What does this PR do? Use `zstd` compression. We just need to enable add the `zstd` build tag (in DataDog/datadog-lambda-extension#878) [Before this change](https://github.com/DataDog/serverless-init-performance-testing/blob/main/saved-profiles/cpu-glib.pb.gz): <img width="1000" height="62" alt="Screenshot 2025-09-29 at 12 45 16 PM" src="https://github.com/user-attachments/assets/306a6233-db57-4617-8d3e-c65adcd73537" /> [After this change](https://github.com/DataDog/serverless-init-performance-testing/blob/main/saved-profiles/cpu-zstd.pb.gz): <img width="1000" height="62" alt="Screenshot 2025-09-29 at 12 45 24 PM" src="https://github.com/user-attachments/assets/402ffddd-e8b1-45e8-8bce-9fddddf5b5e3" /> The cum% for `(*batchStrategy).addMessage` goes down from 20.16% to 4.12%. <img width="500" height="425" alt="Screenshot 2025-09-29 at 5 13 42 PM" src="https://github.com/user-attachments/assets/a95ac5ed-577b-4ed1-81dd-fd97e17a9782" /> For more information, see [this one-pager](https://docs.google.com/document/d/1ovNSaNk_rZKcF3SDz8Ol5ypCD_MRqpq25MsnxMgTmPU/edit?usp=sharing). This PR pretty much just reverts #37523 ### Motivation Improving serverless-init performance https://datadoghq.atlassian.net/browse/SVLS-7667 ### Describe how you validated your changes - Unit tests - Manual testing & [profiling the agent](https://github.com/DataDog/serverless-init-performance-testing) - [Serverless self-monitoring tests](https://gitlab.ddbuild.io/DataDog/serverless-init-self-monitoring/-/pipelines/77863262). It has monitors to make sure we are still receiving logs/metrics/traces - [Serverless e2e tests](https://gitlab.ddbuild.io/DataDog/serverless-e2e-serverless-init-gcp-tests/-/pipelines/77869595/). Failures are known issues and unrelated to this change. ### Additional Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information, see: https://docs.google.com/document/d/1ovNSaNk_rZKcF3SDz8Ol5ypCD_MRqpq25MsnxMgTmPU/edit?usp=sharing
Datadog-agent PR: DataDog/datadog-agent#41353