Add architecture option#32
Merged
Merged
Conversation
nhinsch
reviewed
Oct 25, 2021
| elif [ $ARCHITECTURE == "arm64" ]; then | ||
| echo "Building for arm64 only" | ||
| docker_build_zip arm64 | ||
| else |
Contributor
|
I would add a comment at the top of the |
nhinsch
approved these changes
Oct 25, 2021
nhinsch
left a comment
nhinsch
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple changes needed.
I noticed the integration tests are failing but that's probably worth fixing in a different PR.
jcstorms1
reviewed
Oct 25, 2021
| echo "Building for arm64 only" | ||
| docker_build_zip arm64 | ||
| else | ||
| echo "No valid ARCHITECTURE variable found (allowed values are : arm64, amd64), building for both amd64 and arm64" |
Contributor
There was a problem hiding this comment.
Do we need to build both? The default in this case would be amd64. Is this just in case a customer changes it later?
Contributor
Author
There was a problem hiding this comment.
yeah we need to build it for both architectures since this script is used during our release process
litianningdatadog
pushed a commit
that referenced
this pull request
Dec 1, 2025
route was changed, as opposed to schema version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs adds the architecture option to enable faster build while developing