Fix error on getting the latest DD Lambda Extension version#192
Merged
Conversation
duncanista
approved these changes
Feb 2, 2024
duncanista
left a comment
Contributor
There was a problem hiding this comment.
approving as a short-time fix, since this is probably going to be used with the Datadog/serverless-tools repo
duncanista
added a commit
that referenced
this pull request
Jun 16, 2026
The major OTel SDK bump (sdk-node 0.54 → 0.219) broke the otlp-node
Lambda's runtime instrumentation: index.js still uses the OTel 1.x API
(new Resource({...}), provider.addSpanProcessor) which silently fails on
the 2.x SDK, so no traces are emitted and the OTLP integration suite
returns 0 traces for the node runtime.
Revert otlp-node deps to the 0.54.2 / 1.28.0 / 1.x line and rely on a
top-level protobufjs override (^7.6.4) to pull in the patched protobufjs
without changing the public OTel API surface. This still resolves the
high-severity protobufjs alerts (DoS via unbounded recursion, code
generation gadgets, prototype injection, etc.) and #191/#192 via the
transitive @grpc/[email protected].
The lone critical (GHSA-xq3m-2v4x-88gg, fixed in protobufjs 8.0.1) is
not closed here because the major requires updating index.js to the OTel
2.x API — tracking as follow-up.
Lock regenerated with npm 10.8.2 (node 20) to match CI's resolver.
duncanista
added a commit
that referenced
this pull request
Jun 17, 2026
## Overview Consolidates the 6 open Dependabot/ADMS vulnerability PRs into a single PR. | Source PR | Manifest | Notes | |---|---|---| | #1258 | `integration-tests/lambda/otlp-java/pom.xml` | `io.opentelemetry:opentelemetry-api` 1.58.0 → 1.63.0 | | #1259 | `local_tests/golang/go.{mod,sum}` | `aws-sdk-go`, `golang.org/x/net`, `golang.org/x/sys` minor bumps | | #1260 | `integration-tests/lambda/otlp-node/package*.json` | Superseded by #1263 (lock already has `@grpc/[email protected]`, `@protobufjs/utf8` override carried over) | | #1261 | `integration-tests/package*.json` | `uuid` 9 → 14 (ported manually onto #1262 to avoid lock conflict) | | #1262 | `integration-tests/package*.json` | `axios` 1.15 → 1.18, plus overrides for `@opentelemetry/core`, `fast-xml-parser`, `fast-xml-builder`, `fast-uri`, `brace-expansion` | | #1263 | `integration-tests/lambda/otlp-node/package*.json` | Major OTel SDK bump (`@opentelemetry/sdk-node` 0.54 → 0.219, `protobufjs` 7.5.4 → 7.6.4) | Closes the following Dependabot alerts: #191, #192 (`@grpc/grpc-js`); #183–#190 + older axios alerts; protobufjs alerts via the major OTel SDK bump; uuid #180; OpenTelemetry Java #176. ## Testing GitHub Actions checks (Build All, Test Suite, Clippy, Audit, CodeQL) passed on each individual source PR. `dd-gitlab/*` checks failed identically on all 6 — appears to be an unrelated infra/permissions issue with the bot-authored branches. Re-running CI on this branch (created from a maintainer account) should clear them. The vendored deps live entirely under `integration-tests/` and `local_tests/`, so they have no impact on the shipped extension binary. --------- Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that performance tests were using the fallback Extension version: ddserverless example
We were getting 403s from Github's API because we didn't have a
User-Agentheader: https://docs.github.com/en/rest/using-the-rest-api/troubleshooting-the-rest-api?apiVersion=2022-11-28#user-agent-requiredAlso bumped the
FALLBACK_LATEST_EXTENSION_VERSION.