Skip to content

Move from github-actions to gitlab to publish layers#136

Merged
maxday merged 123 commits into
mainfrom
maxday/gitlab
Apr 3, 2023
Merged

Move from github-actions to gitlab to publish layers#136
maxday merged 123 commits into
mainfrom
maxday/gitlab

Conversation

@maxday

@maxday maxday commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

We're now using gitlab to build and publish layer

  • remove binary from git
  • remove aem encryption
  • remove MFA as it's running on internal runner

@maxday
maxday requested a review from a team as a code owner March 17, 2023 20:56
Comment thread .gitlab-ci.yml
value: main
LAYER_SUFFIX:
description: "Suffix to be appended to the layer name (default empty)"
value: ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add build tags here as well, so we don't have to keep reverting PRs when we want to change the build tags.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not, maybe in an other PR as this one is already quite big, WDYT?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. It's also less important now that we're solidly in the otlp build tag world as opposed to previously where we were going back and forth regularly.

@maxday
maxday merged commit 36bc555 into main Apr 3, 2023
@maxday
maxday deleted the maxday/gitlab branch April 3, 2023 15:58
duncanista added a commit that referenced this pull request Jun 10, 2026
Picks up the doc-comment clarification from the copilot review on
DataDog/serverless-components#136 (https/fips features aren't
Cargo-enforced).
duncanista added a commit that referenced this pull request Jun 10, 2026
DataDog/serverless-components#136 merged at bb4dedeee20b949db3143c05e5a779b843a8a484.
The previous pin was the pre-merge branch SHA used during development.
duncanista added a commit that referenced this pull request Jun 10, 2026
Three real fixes from independent review:

1. **Cargo.lock dedup** — bump dogstatsd and datadog-fips from
   `aaac1a5d` to `bb4dedee` so they share the same serverless-components
   SHA as datadog-agent-config. Otherwise cargo resolves two distinct
   `dogstatsd` source entries (the dep transitively from agent-config
   pulled in a second copy at the newer rev). Source trees for both
   crates are byte-identical between the two SHAs; only #136 changed
   between them. PR description matches reality now.

2. **`capture_lambda_payload_max_depth` graceful deserializer** —
   the field was missing `#[serde(deserialize_with = ...)]`, violating
   the upstream `ConfigExtension::Source` contract. Without it, a
   malformed env value would silently reset *all* extension fields to
   their defaults (api_key_secret_arn, kms_api_key, …) and emit only
   a `tracing::warn!`. Adds `deser_opt_lossless` which returns `None`
   on bad input so the rest of the extension keeps its values.

3. **Test coverage gaps**:
   - YAML round-trip for the two source-to-config renames
     (`org_uuid → dd_org_uuid` and
     `lambda_customer_metrics_exclude_tags → custom_metrics_exclude_tags`).
     These were the exact cases where YAML behavior matters most and
     they only had env tests.
   - `FlushStrategy::EndPeriodically` (`"end,N"`) and
     `FlushStrategy::Continuously` (`"continuously,N"`) — the upstream
     enum has all four variants and bottlecap will rely on them
     behaviorally; previously only `End` and `Periodically` had
     coverage.

Test count: 33 → 37.
duncanista added a commit that referenced this pull request Jun 18, 2026
Picks up the doc-comment clarification from the copilot review on
DataDog/serverless-components#136 (https/fips features aren't
Cargo-enforced).
duncanista added a commit that referenced this pull request Jun 18, 2026
DataDog/serverless-components#136 merged at bb4dedeee20b949db3143c05e5a779b843a8a484.
The previous pin was the pre-merge branch SHA used during development.
duncanista added a commit that referenced this pull request Jun 18, 2026
Three real fixes from independent review:

1. **Cargo.lock dedup** — bump dogstatsd and datadog-fips from
   `aaac1a5d` to `bb4dedee` so they share the same serverless-components
   SHA as datadog-agent-config. Otherwise cargo resolves two distinct
   `dogstatsd` source entries (the dep transitively from agent-config
   pulled in a second copy at the newer rev). Source trees for both
   crates are byte-identical between the two SHAs; only #136 changed
   between them. PR description matches reality now.

2. **`capture_lambda_payload_max_depth` graceful deserializer** —
   the field was missing `#[serde(deserialize_with = ...)]`, violating
   the upstream `ConfigExtension::Source` contract. Without it, a
   malformed env value would silently reset *all* extension fields to
   their defaults (api_key_secret_arn, kms_api_key, …) and emit only
   a `tracing::warn!`. Adds `deser_opt_lossless` which returns `None`
   on bad input so the rest of the extension keeps its values.

3. **Test coverage gaps**:
   - YAML round-trip for the two source-to-config renames
     (`org_uuid → dd_org_uuid` and
     `lambda_customer_metrics_exclude_tags → custom_metrics_exclude_tags`).
     These were the exact cases where YAML behavior matters most and
     they only had env tests.
   - `FlushStrategy::EndPeriodically` (`"end,N"`) and
     `FlushStrategy::Continuously` (`"continuously,N"`) — the upstream
     enum has all four variants and bottlecap will rely on them
     behaviorally; previously only `End` and `Periodically` had
     coverage.

Test count: 33 → 37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants