fix(metrics): emit init duration metric on platform report as fallback#1253
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the init duration enhanced metric is emitted reliably on on-demand cold starts by adding a platform.report-based fallback when platform.initReport is missing or arrives late, while preventing double emission.
Changes:
- Track whether the init duration metric has already been emitted for the current sandbox (
init_duration_metric_emitted). - Emit init duration from
platform.report’sinit_duration_msas a fallback when needed, and skip subsequent emission fromplatform.initReport. - Add targeted tests covering emission from init report, fallback from report, warm invocations, and double-emission prevention.
purple4reina
approved these changes
Jun 12, 2026
shreyamalpani
force-pushed
the
shreya.malpani/fix-init-duration-metric
branch
from
June 16, 2026 15:44
aa29f22 to
9ae4d86
Compare
litianningdatadog
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The init duration metric is sent on the
PlatformInitReportevent. In the case of this event not being received / arriving late, this PR adds a fallback to use the init duration from thePlatformReportevent on cold start invocations in On Demand mode.Motivation
Saw failures on emitting the init duration metric in E2E tests.
Testing
Added unit tests and E2E tests no longer fail on sending the init duration metric on this PR.