Skip to content

fix(traces): add retry strategy#1116

Merged
duncanista merged 6 commits into
mainfrom
jordan.gonzalez/traces/add-retry-strategy
Mar 19, 2026
Merged

fix(traces): add retry strategy#1116
duncanista merged 6 commits into
mainfrom
jordan.gonzalez/traces/add-retry-strategy

Conversation

@duncanista

Copy link
Copy Markdown
Contributor

Overview

Add a retry strategy for traces

Testing

N/A

@duncanista
duncanista requested a review from a team as a code owner March 19, 2026 15:16
@duncanista
duncanista requested review from Copilot and lym953 and removed request for Copilot March 19, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a retry strategy to trace flushing so transient send failures can be retried automatically during a flush cycle.

Changes:

  • Introduces a helper (trace_retry_strategy) to construct a RetryStrategy.
  • Applies the retry strategy to the primary trace SendData builder.
  • Ensures dual-shipped (additional endpoint) SendData instances also receive the same retry strategy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread bottlecap/src/traces/trace_flusher.rs Outdated

@lym953 lym953 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Comment thread bottlecap/src/traces/stats_flusher.rs Outdated
@duncanista
duncanista merged commit 2b9c605 into main Mar 19, 2026
46 of 49 checks passed
@duncanista
duncanista deleted the jordan.gonzalez/traces/add-retry-strategy branch March 19, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants