Skip to content

Add trace support to integration testing#11

Merged
maxday merged 24 commits into
mainfrom
maxday/add-trace-support
Jul 12, 2021
Merged

Add trace support to integration testing#11
maxday merged 24 commits into
mainfrom
maxday/add-trace-support

Conversation

@maxday

@maxday maxday commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Add integration tests for traces (nodejs + python)

@maxday
maxday requested a review from a team as a code owner June 21, 2021 21:35

@DarcyRaynerDD DarcyRaynerDD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small question

runtime: python3.8
handler: datadog_lambda.handler.handler
layers:
- arn:aws:lambda:${self:provider.region}:464622532012:layer:Datadog-Python38:${env:PYTHON_LAYER_VERSION}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we swapped to the staging layers?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a way to dynamically get the latest versions of prod layers without adding prod credentials as secrets

@maxday
maxday merged commit f2bdf75 into main Jul 12, 2021
@maxday
maxday deleted the maxday/add-trace-support branch July 12, 2021 13:55
litianningdatadog pushed a commit that referenced this pull request Dec 1, 2025
`INVOKE` event subscription in elevator would crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants