Nathan.gallet/fix ci failures#247
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
NathanGallet-dd
force-pushed
the
nathan.gallet/fix-ci-failures
branch
2 times, most recently
from
July 7, 2026 15:11
c0cae59 to
405bcd8
Compare
- Remove hard error when branch name is empty in getRepositoryCommitInfo - Replace with explanatory comment noting branch is optional metadata - Detached-HEAD state is common in CI tag builds where no branch is checked out Rationale: The scanner was aborting entirely when run against a detached HEAD (e.g., a CI pipeline triggered by a git tag). Branch is only metadata attached to the scan result; it is not required for the scan to succeed. Continuing without a branch name is the correct behaviour rather than returning an error that prevents any scan results from being produced. This commit made by [/dd:git:commit:atomic](https://github.com/DataDog/claude-marketplace/tree/main/dd/commands/git/commit/atomic.md)
NathanGallet-dd
force-pushed
the
nathan.gallet/fix-ci-failures
branch
from
July 7, 2026 15:25
405bcd8 to
1971071
Compare
whitemerch
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test_E2EFetchBundleThenOfflineScanwas failing in CI becausegetRepositoryCommitInfohard-errors when the git branch name cannot be determined. This happens on release tag pushes, where GitHub Actions checks out in detached HEAD state with no remote branch pointing at the commit.Branch is optional metadata (
omitemptyin the model) — aborting the entire scan over it is wrong. The fix removes the hard error and lets the scan continue with an empty branch.How to reproduce