Remove legacy Rego compat shim (follow-up to Rego v1)#185
Merged
Conversation
whitemerch
marked this pull request as ready for review
June 15, 2026 16:19
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1f41b31 | Docs | Datadog PR Page | Give us feedback! |
NathanGallet-dd
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a small follow-up to PR #179. After defaulting the engine to Rego v1, the
dd_iac_compatshim still merged results from the pre-renamedata.Cx.CxPolicypath even though every shipped rule now exposesdata.datadog.DatadogPolicy. TheCxPolicyleg is unused dead code; removing it drops an extra OPA module from every evaluation and simplifies the top-level query.Changes
Engine
Stop injecting
dd_iac_compat.regoalongside rule modules.Query defaults
Set
RegoQuerytoresult = data.datadog.DatadogPolicyand delete theRegoCompatShimconstant.Author Checklist
QA Instruction
go test ./pkg/engine/... ./pkg/utils/... ./pkg/scan/...Blast Radius
Datadog IaC Scanner OPA evaluation only: rule modules must continue to define
package datadogwith aDatadogPolicyrule set, which is already the contract after the rename migration.Additional Notes
None.
I submit this contribution under the Apache-2.0 license.