Rename pkg/kics to pkg/runner and keep path discovery in pkg/analyzer#175
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: da3f23f | Docs | Datadog PR Page | Give us feedback! |
whitemerch
force-pushed
the
chakib.hamie/rename_pkg_kics_to_service
branch
from
June 3, 2026 11:38
3319816 to
52a85df
Compare
whitemerch
changed the title
whitemerch
marked this pull request as ready for review
June 3, 2026 11:39
whitemerch
marked this pull request as draft
June 3, 2026 11:40
whitemerch
changed the title
whitemerch
force-pushed
the
chakib.hamie/rename_pkg_kics_to_service
branch
from
June 3, 2026 11:54
60b9545 to
3dc7f9c
Compare
whitemerch
marked this pull request as ready for review
June 3, 2026 11:58
NathanGallet-dd
previously approved these changes
Jun 3, 2026
whitemerch
force-pushed
the
chakib.hamie/rename_pkg_kics_to_service
branch
from
June 3, 2026 14:07
3dc7f9c to
da3f23f
Compare
NathanGallet-dd
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The legacy
pkg/kicsname does not describe the scan pipeline. Path discovery (platform detection, OpenAPI heuristics,Analyze) is separate from orchestrating parse + inspect work.Layout
pkg/runner— scan pipeline (Service, sinks,PrepareScanDocument, etc.),package runner.pkg/analyzer— path discovery only (Analyzer,Analyze, shared OpenAPI regexes for resolvers),package analyzerat the repo root (no nestedpathspackage).Imports:
pkg/scanandpkg/scanneruserunnerfor the pipeline;pkg/scan/utils.goandpkg/resolver/fileuseanalyzerfor path analysis helpers.CI
Critical tests run
./pkg/runnerand./pkg/analyzer.How to verify
go build ./... go test -short ./pkg/runner/... ./pkg/analyzer/... ./pkg/scan/... ./pkg/scanner/...Impact
Internal Go package layout only. No CLI or rule format changes.