chore: refactor serverless e2e tests#2371
Merged
ava-silver merged 4 commits intoJun 22, 2026
Merged
Conversation
This was referenced Jun 17, 2026
Contributor
Author
This comment has been minimized.
This comment has been minimized.
ava-silver
marked this pull request as ready for review
June 17, 2026 21:19
duncanista
approved these changes
Jun 18, 2026
nina9753
approved these changes
Jun 18, 2026
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
5 times, most recently
from
June 18, 2026 22:33
cab8641 to
ee260a1
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
2 times, most recently
from
June 22, 2026 14:37
dbee69c to
c8512a8
Compare
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
from
June 22, 2026 14:37
ee260a1 to
0e64240
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 22, 2026 14:50
c8512a8 to
94cef46
Compare
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
2 times, most recently
from
June 22, 2026 15:26
74043f9 to
5c99ae7
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 22, 2026 15:26
94cef46 to
6905508
Compare
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
from
June 22, 2026 18:42
5c99ae7 to
c6a4a4c
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 22, 2026 18:42
6905508 to
64bd964
Compare
Base automatically changed from
ava.silver/chore/add-web-app-e2e-checks
to
master
June 22, 2026 19:22
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
from
June 22, 2026 19:22
c6a4a4c to
04c1d4a
Compare
ava-silver
force-pushed
the
ava.silver/chore/refactor-serverless-e2e-tests
branch
from
June 22, 2026 21:00
cc0e3ab to
f55b20b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
Groups the serverless-owned e2e tests and their helpers under
e2e/serverless/, with one subdirectory per feature (lambda, cloud-run, container-app, aas). These cloud-instrumentation tests and their verifiers were sitting flat among the other e2e files, and their ownership was spelled out across ~9 CODEOWNERS lines and duplicated path lists in CI.Collecting them by package gives a single ownership boundary -- mirroring how
packages/base/src/helpers/serverlessalready gets one CODEOWNERS entry -- and lets each CI change-detection filter point at a package glob instead of enumerating individual files. Adding a test, verifier, or shared helper no longer requires editingci.yml. Non-serverless tests (junit, sarif, sbom, sourcemaps, synthetics, git-metadata, version) stay flat at the top level.How?
*.test.tsand its verifier intoe2e/serverless/<feature>/:lambda/-- lambda.test.ts, lambda-verifier.tscloud-run/-- cloud-run.test.ts, cloud-run-verifier.tscontainer-app/-- container-app.test.ts, container-app-verifier.tsaas/-- aas-linux.test.ts, aas-windows.test.ts, aas-verifier.tsNo Jest or tsconfig changes needed: e2e discovery is recursive (`roots: ['e2e']`) and `e2e/tsconfig.json` already covers the new subdirs.
Review checklist