chore: add telemetry checks to AAS web app e2e tests#2365
Merged
Conversation
Contributor
Author
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 64bd964 | Docs | Datadog PR Page | Give us feedback! |
ava-silver
force-pushed
the
graphite-base/2365
branch
from
June 16, 2026 18:15
36742bd to
4aa83a2
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 16, 2026 18:15
84fd1d0 to
0f29354
Compare
ava-silver
changed the base branch from
graphite-base/2365
to
ava.silver/chore/add-container-app-e2e-checks
June 16, 2026 18:15
This was referenced Jun 16, 2026
ava-silver
changed the base branch from
ava.silver/chore/add-container-app-e2e-checks
to
graphite-base/2365
June 16, 2026 18:23
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 16, 2026 18:24
0f29354 to
410a930
Compare
ava-silver
force-pushed
the
graphite-base/2365
branch
from
June 16, 2026 18:24
4aa83a2 to
1a359ff
Compare
ava-silver
changed the base branch from
graphite-base/2365
to
ava.silver/chore/add-container-app-e2e-checks
June 16, 2026 18:24
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
3 times, most recently
from
June 17, 2026 17:52
410a930 to
b4027cc
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
from
June 17, 2026 17:54
2bfcdae to
c30c9df
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
2 times, most recently
from
June 17, 2026 18:23
4bb9bc5 to
9e1091d
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
from
June 17, 2026 18:23
c30c9df to
6cd5dc1
Compare
This was referenced Jun 17, 2026
ava-silver
marked this pull request as ready for review
June 17, 2026 20:04
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 17, 2026 20:37
9e1091d to
bd78eea
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
2 times, most recently
from
June 17, 2026 20:45
9fd84c5 to
e700d40
Compare
1 task
duncanista
approved these changes
Jun 18, 2026
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 18, 2026 22:33
73c9fbb to
dbee69c
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
from
June 18, 2026 22:33
e700d40 to
112e548
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 22, 2026 14:37
dbee69c to
c8512a8
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
2 times, most recently
from
June 22, 2026 14:50
8cb96cd to
b6cd212
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
2 times, most recently
from
June 22, 2026 15:26
94cef46 to
6905508
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-container-app-e2e-checks
branch
2 times, most recently
from
June 22, 2026 16:28
426ebf0 to
a5a35eb
Compare
ava-silver
changed the base branch from
ava.silver/chore/add-container-app-e2e-checks
to
graphite-base/2365
June 22, 2026 17:03
Uses pre-built zips from selfmonitoringprod storage (node-sidecar.zip for Linux, node-extension.zip for Windows) -- these include dd-trace + winston with node_modules pre-installed, so no SCM_DO_BUILD_DURING_DEPLOYMENT needed.
az webapp deploy requires Kudu/SCM permissions that the CI service principal doesn't have. WEBSITE_RUN_FROM_PACKAGE uses the ARM appsettings API (same as aas instrument) and mounts the zip directly -- no extra permissions needed.
…loy, sustained traffic, windows traces-only
…d where the checker looks
…th the CI principal
…; drop basic-auth toggle
ava-silver
force-pushed
the
ava.silver/chore/add-web-app-e2e-checks
branch
from
June 22, 2026 18:42
6905508 to
64bd964
Compare
ava-silver
force-pushed
the
graphite-base/2365
branch
from
June 22, 2026 18:42
a5a35eb to
5b46b0c
Compare
TalUsvyatsky
approved these changes
Jun 22, 2026
This was referenced Jun 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
Adds telemetry-flow verification to the Azure App Service (Linux + Windows) e2e suites so they assert that telemetry actually reaches Datadog under a run-specific identity -- not just that instrumentation config was applied. Linux asserts spans and logs; Windows asserts spans (Windows App Service does not support Datadog log collection).
Stacked on #2364, and depends on #2369 (shared telemetry checker).
How?
service/env/versionand aone_e2e_run_idextra tag so the checker asserts identity, not mere existence.DATADOG_API_KEY), so the spans/logs land in the org the assertions read from.--instance-loggingso the sidecar forwards the app's stdout logs, not just traces.az webapp deploy(zipdeploy) withSCM_DO_BUILD_DURING_DEPLOYMENT, so Oryx generates the iisnodeweb.configIIS needs to route requests to the Node app. (Mounting the package read-only viaWEBSITE_RUN_FROM_PACKAGEskips that build, so the app 403s.) Auth uses the az-login AAD token; the SCM site can return a 502 while cold, so the deploy retries. (Requires the CI service principal to haveWebsite Contributoron the e2e resource group for the SCM deploy.)triggerTraffichelper so the trace/log pipeline has time to warm up after a cold start before we assert telemetry.telemetry flowsasserts identity (service + env + version + run-id tag) via the shared telemetry checker -- spans + logs on Linux, spans only on Windows.traffic.tsand telemetry checker to the AAS CI path filter.Test plan
End-to-end test the packageGitHub Actions job (gated by theaaspath filter + Azure OIDC); all three Node matrix versions green with live spans (Linux: spans + logs) flowing to Datadog.Review checklist