e2e no plaintext secrets#2349
Merged
Merged
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 27725b0 | Docs | Datadog PR Page | Give us feedback! |
ava-silver
marked this pull request as ready for review
June 11, 2026 20:10
duncanista
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
e2e/.env.localwas the suggested way to supply secrets locally for e2e tests, which meant real API and app keys living in a plaintext file on disk. This removes that practice and points contributors todd-authinstead.How?
DD_API_KEY,DATADOG_API_KEY, andDATADOG_APP_KEYfrome2e/.env.local(non-secret config likeDATADOG_CI_COMMANDand GCP/Azure resource IDs stays)jest.config-e2e.jsthat exits immediately with a clear message if no API key is present, rather than failing deep inside a teste2e/helpers/exec.tsto no longer imply.env.localis for credentialsTo run e2e tests locally, use:
Review checklist