[K9VULN-15920] Warn when env tag is passed to sbom upload#2344
Merged
Conversation
The --env flag is ignored server-side for non-SCI uploads (env is always normalized to "ci"). This adds a client-side warning so users know the flag has no effect. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 08452b1 | Docs | Datadog PR Page | Give us feedback! |
dastrong
reviewed
Jun 8, 2026
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
dastrong
approved these changes
Jun 8, 2026
divyav-datadog
marked this pull request as ready for review
June 8, 2026 19:39
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
The
--envflag is ignored server-side for non-SCI SBOM uploads (env is always normalized to"ci"). This adds a client-side warning so users know the flag has no effect rather than silently ignoring it.How?
packages/plugin-sbom/src/renderer.ts— addedrenderEnvFlagDeprecationWarning()that prints a yellow warning to stderrpackages/plugin-sbom/src/commands/upload.ts— calls the warning when--envis set to anything other than the default"ci"