chore: cloud-run e2e telemetry flow validation#2341
Merged
ava-silver merged 3 commits intoJun 9, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
Drarig29
approved these changes
Jun 9, 2026
nina9753
approved these changes
Jun 9, 2026
ava-silver
deleted the
ava.silver/chore/cloud-run-e2e-telemetry-flow-validation
branch
June 9, 2026 15:27
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
The Cloud Run e2e tests previously only verified resource shape (sidecar injection, env vars, volume mounts) using the stock
helloimage, which emits no telemetry. This PR extends them to verify that spans and logs from the instrumented app actually reach the Datadog e2e org.Note, we may want to migrate to
dd-stsat some point to avoid having api/app keys stored in githubHow?
gcr.io/datadog-serverless-gcp-dev/run-nodejs-sidecar(a real Node.js app with tracing), controlled via the newGCP_CLOUD_RUN_APP_IMAGE_E2Erepo variable--allow-unauthenticatedso the test can hit the service URL without credentials--tracingto theinstrumentinvocation to ensureDD_TRACE_ENABLED=truetelemetry flowstest case (between instrument and uninstrument) that:gcloud run services describefetchto generate a tracee2e/helpers/cloud-run-telemetry-checker.ts(mirrors the pattern fromjunit-upload-checker.ts) with explicitDATADOG_API_KEY/DATADOG_APP_KEYauth -- the e2e org keys already flow in fromDATADOG_API_KEY_E2E/DATADOG_APP_KEY_E2Ein CIGCP_CLOUD_RUN_APP_IMAGE_E2Ethrough CI env and adds the helper file to the cloud-run paths filterReview checklist