Skip to content

chore: skip serverless e2e on version-bump-only release commits#2335

Merged
ava-silver merged 1 commit into
masterfrom
ava.silver/chore/skip-serverless-e2e-on-version-bump-only-release-commits
May 28, 2026
Merged

chore: skip serverless e2e on version-bump-only release commits#2335
ava-silver merged 1 commit into
masterfrom
ava.silver/chore/skip-serverless-e2e-on-version-bump-only-release-commits

Conversation

@ava-silver

@ava-silver ava-silver commented May 28, 2026

Copy link
Copy Markdown
Contributor

What and why?

Release PRs created by yarn version:all only bump the "version" field in every package.json. Because packages/base/package.json is in the path filters for the serverless e2e check jobs, those tests were always triggered on release commits even though no serverless code changed.

Example: https://github.com/DataDog/datadog-ci/actions/runs/26580292541/job/78312089121?pr=2334

How?

Adds a check-version-bump-only job that:

  1. Fails fast if any non-package.json file was touched.
  2. Greps the actual diff content -- if every +/- line matches "version": "X.Y.Z", the commit is version-bump-only.

The e2e-test job's SKIP_*_TESTS env vars now also skip when check-version-bump-only returns true.

Manual testing

Tested the script logic against two real branches:

alejandro.fontan/release-v5.18.0 (16 package.json files, version fields only):

non_json: ''
leftover lines: (none)
result=true  ✓

PR #2333 (tal.usvyatsky/datadog-ci-lambda-e2e-tests, real code changes):

non_json: '.github/CODEOWNERS .github/workflows/ci.yml e2e/fixtures/lambda/...'
result=false  ✓

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-prod-us1-3

This comment has been minimized.

@ava-silver
ava-silver marked this pull request as ready for review May 28, 2026 15:06
@ava-silver
ava-silver requested a review from a team as a code owner May 28, 2026 15:06
@ava-silver ava-silver added chores Related to the CI or developer experience datadog-ci For PRs spanning multiple commands, and repo-wide changes labels May 28, 2026
@ava-silver
ava-silver merged commit ca8a044 into master May 28, 2026
35 of 36 checks passed
@ava-silver
ava-silver deleted the ava.silver/chore/skip-serverless-e2e-on-version-bump-only-release-commits branch May 28, 2026 15:48
@GabrielAnca GabrielAnca mentioned this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience datadog-ci For PRs spanning multiple commands, and repo-wide changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants