[SVLS-7939] Add Lambda E2E tests#2333
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
TalUsvyatsky
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
May 22, 2026 19:21
1d8b6d7 to
1aa9a92
Compare
1 task
TalUsvyatsky
marked this pull request as ready for review
June 5, 2026 19:43
urseberry
previously requested changes
Jun 5, 2026
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
June 15, 2026 19:37
2e0551c to
a6a4df0
Compare
Contributor
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
June 15, 2026 21:37
a6a4df0 to
4bfe122
Compare
This was referenced Jun 16, 2026
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
2 times, most recently
from
June 17, 2026 17:54
6b6d4c9 to
bcf57a2
Compare
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
June 17, 2026 18:23
bcf57a2 to
7e54ba0
Compare
ava-silver
changed the base branch from
graphite-base/2333
to
ava.silver/chore/shared-e2e-telemetry-checker
June 17, 2026 18:23
This was referenced Jun 17, 2026
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
2 times, most recently
from
June 17, 2026 20:45
61bbd3b to
b097b38
Compare
ava-silver
force-pushed
the
ava.silver/chore/shared-e2e-telemetry-checker
branch
from
June 17, 2026 20:45
8cbadb2 to
83da7dd
Compare
1 task
duncanista
approved these changes
Jun 18, 2026
avangelillo
reviewed
Jun 18, 2026
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
June 18, 2026 22:33
b097b38 to
957856e
Compare
avangelillo
approved these changes
Jun 22, 2026
Base automatically changed from
ava.silver/chore/shared-e2e-telemetry-checker
to
master
June 22, 2026 15:25
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
ava-silver
force-pushed
the
tal.usvyatsky/datadog-ci-lambda-e2e-tests
branch
from
June 22, 2026 15:26
34e1df8 to
9ed1b16
Compare
ava-silver
added a commit
that referenced
this pull request
Jun 22, 2026
…#2370) ### What and why? Re-running `instrument` on a serverless-init sidecar target (Azure Container App) must be a true no-op. Previously a re-instrument could drop provider-populated sidecar fields (e.g. `resources`) and re-append the shared volume mount, producing config drift. This makes the sidecar merge idempotent and enables APM on the Container App sidecar. Split out from the Container App e2e PR (#2364) so the production behavior change is reviewed on its own. Stacked on #2333. ### How? - `packages/base/src/helpers/serverless/common.ts`: when a sidecar container already exists, merge the new config **onto** it -- preserving existing `resources` and env vars, and deduping the shared volume mount via a new `ensureSharedVolumeMount` helper -- instead of replacing it wholesale. - `packages/plugin-container-app/src/common.ts`: set `DD_APM_ENABLED=true` so the sidecar enables APM. - Updates the affected unit tests and the instrument snapshot. ### Test plan - `yarn test` for `packages/base` serverless helpers and `packages/plugin-container-app` (60 tests pass). - End-to-end idempotency is asserted by the Container App e2e suite in #2364. ### Review checklist - [x] Feature or bugfix MUST have appropriate tests (unit, integration)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
Adds real AWS Lambda e2e coverage for
datadog-ci lambda instrumentanddatadog-ci lambda uninstrument. The tests are gated in CI, targeteu-central-1, and use thenodejs24.xruntime.Stacked on #2369 (shared telemetry checker).
How?
one-e2e-ci-lambda-*function with the AWS CLI, instruments it, verifies the AWS configuration, invokes it and asserts telemetry flows, re-instruments and asserts idempotency (exactly one of each Datadog layer), uninstruments, verifies cleanup, and deletes it.dd_sls_citag.e2e/.env.local, matching the local e2e docs.Test plan
Review checklist