Skip to content

chore: migrate lambda and cloud-run to @inquirer/prompts#2327

Merged
ava-silver merged 4 commits into
masterfrom
ava.silver/chore/migrate-lambda-and-cloud-run-to-inquirer-prompts-via-base-serverless
May 21, 2026
Merged

chore: migrate lambda and cloud-run to @inquirer/prompts#2327
ava-silver merged 4 commits into
masterfrom
ava.silver/chore/migrate-lambda-and-cloud-run-to-inquirer-prompts-via-base-serverless

Conversation

@ava-silver

@ava-silver ava-silver commented May 19, 2026

Copy link
Copy Markdown
Contributor

What and why?

Replaces inquirer v8 with @inquirer/prompts v7 in plugin-lambda and plugin-cloud-run. Also removes inquirer-checkbox-plus-prompt and fuzzy.

How?

Direct imports from @inquirer/prompts in each plugin -- no shared wrapper needed since @inquirer/[email protected] ships a CJS build that works with the existing TypeScript config. v7 is used over v8 because v8 introduced a dependency on NoInfer<T>, which requires TypeScript >=5.4 (this project is on 5.1.6).

Behavior change

The custom inquirer-checkbox-plus-prompt-based checkbox (which let users type to fuzzy-filter the function list) is replaced with the standard @inquirer/prompts checkbox, which is scroll-only. @inquirer/checkbox v4 has no search support. This is acceptable since function lists are sorted, making scroll navigation reasonable.

Before image
After image

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

ava-silver commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 19, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6c4f9ba | Docs | Datadog PR Page | Give us feedback!

Replaces inquirer v8 + inquirer-checkbox-plus-prompt with @inquirer/[email protected].
Direct imports -- no abstraction layer needed since plugins are tsdown-bundled
and @inquirer/prompts ships a CJS build compatible with the tsc output.

Also removes fuzzy and @inquirer/core deps (dropped the custom searchable
checkbox in favour of the plain @inquirer/prompts checkbox).
@ava-silver
ava-silver changed the base branch from ava.silver/chore/scaffold-base-serverless-package to graphite-base/2327 May 19, 2026 22:22
@ava-silver
ava-silver force-pushed the ava.silver/chore/migrate-lambda-and-cloud-run-to-inquirer-prompts-via-base-serverless branch from d7a9a95 to 17a4710 Compare May 19, 2026 22:22
@ava-silver
ava-silver force-pushed the graphite-base/2327 branch from d6afde3 to ae7af20 Compare May 19, 2026 22:22
@ava-silver
ava-silver changed the base branch from graphite-base/2327 to master May 19, 2026 22:22
@ava-silver ava-silver added the chores Related to the CI or developer experience label May 19, 2026

@Drarig29 Drarig29 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't know if you were OK with dropping some behavior 👌

@ava-silver
ava-silver marked this pull request as ready for review May 21, 2026 13:17
@ava-silver
ava-silver requested review from a team as code owners May 21, 2026 13:17
@ava-silver
ava-silver requested a review from nina9753 May 21, 2026 13:17
@ava-silver

Copy link
Copy Markdown
Contributor Author

LGTM, I didn't know if you were OK with dropping some behavior 👌

@Drarig29 the search functionality is not the most important behavior IMO since this is just for first time customers -- but I'll check in with the team to see what they think

Comment thread packages/plugin-lambda/src/__tests__/prompt.test.ts Outdated
@ava-silver
ava-silver merged commit c0c5f09 into master May 21, 2026
29 checks passed
@ava-silver
ava-silver deleted the ava.silver/chore/migrate-lambda-and-cloud-run-to-inquirer-prompts-via-base-serverless branch May 21, 2026 15:26
@afontan afontan mentioned this pull request May 28, 2026
@ava-silver ava-silver changed the title chore: migrate lambda and cloud-run to inquirer prompts via base-serverless chore: migrate lambda and cloud-run to inquirer prompts May 28, 2026
@ava-silver ava-silver changed the title chore: migrate lambda and cloud-run to inquirer prompts chore: migrate lambda and cloud-run to @inquirer/prompts May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants