Skip to content

[chore] Build standalone binary with stock Node.js binaries#2317

Merged
Drarig29 merged 5 commits into
masterfrom
corentin.girard/remove-yao-pkg-patches
May 19, 2026
Merged

[chore] Build standalone binary with stock Node.js binaries#2317
Drarig29 merged 5 commits into
masterfrom
corentin.girard/remove-yao-pkg-patches

Conversation

@Drarig29

@Drarig29 Drarig29 commented May 18, 2026

Copy link
Copy Markdown
Contributor

What and why?

This PR removes the local patches for @yao-pkg/pkg and @yao-pkg/pkg-fetch, which were meant to target Node.js custom-built binaries hosted at https://github.com/Drarig29/pkg-fetch/releases/tag/v1.0, built using --with-intl=none to reduce the size of the binaries.

This effectively reverts #1858, at the cost of bigger binaries:

File Before (v22.19.0) After (v22.22.3)
datadog-ci_darwin-arm64 74.6 MB 138,9 MB
datadog-ci_darwin-x64 80.3 MB 141,4 MB
datadog-ci_linux-arm64 81.2 MB 148,2 MB
datadog-ci_linux-x64 85.7 MB 150,9 MB
datadog-ci_win-x64 72.8 MB 113,1 MB

But the benefits are:

How?

Use the default @yao-pkg/pkg experience, without modifications. Standalone binaries can be baked into Docker images or cached in CI anyway, and them being bigger is the cost of being standalone.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the chores Related to the CI or developer experience label May 18, 2026
@Drarig29
Drarig29 marked this pull request as ready for review May 18, 2026 16:32
@Drarig29
Drarig29 requested a review from a team as a code owner May 18, 2026 16:32
@Drarig29
Drarig29 marked this pull request as draft May 18, 2026 20:47
@Drarig29 Drarig29 changed the title [chore] Upgrade @yao-pkg/pkg and remove patches [chore] Build standalone binary with stock Node.js binaries May 18, 2026
@Drarig29
Drarig29 force-pushed the corentin.girard/remove-yao-pkg-patches branch from 32062ba to d140ba9 Compare May 18, 2026 22:32
@Drarig29
Drarig29 marked this pull request as ready for review May 19, 2026 01:59
@Drarig29
Drarig29 merged commit 0f62ec3 into master May 19, 2026
52 of 53 checks passed
@Drarig29
Drarig29 deleted the corentin.girard/remove-yao-pkg-patches branch May 19, 2026 10:14
@Drarig29 Drarig29 mentioned this pull request May 19, 2026
@Drarig29 Drarig29 added datadog-ci For PRs spanning multiple commands, and repo-wide changes guild-project Related to a project lead by the #datadog-ci-guild labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience datadog-ci For PRs spanning multiple commands, and repo-wide changes guild-project Related to a project lead by the #datadog-ci-guild

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants