fix(dora): treat 401 as non-retriable and exit non-zero#2303
Merged
ava-silver merged 1 commit intoMay 5, 2026
Merged
Conversation
ava-silver
changed the title
ava-silver
added
bug
ava-silver
marked this pull request as ready for review
May 4, 2026 14:05
1 task
borja-gomez
approved these changes
May 5, 2026
Drarig29
approved these changes
May 5, 2026
ava-silver
deleted the
ava.silver/chore/fix-dora-deployment-401-non-retriable-exit-code
branch
May 5, 2026 16:00
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes #2301.
When
dora deploymentreceived a 401 (Unauthorized), it would retry 5 times and then silently swallow the error -- printing "✅ Successfully sent" and exiting with code 0 despite the API call having failed.Two root causes:
errorCodesNoRetryinretry.tswas missing 401, so the request was retried unnecessarily.nonRetriableErrorCodesin the DORA deployment command was also missing 401, so after all retries were exhausted the caught error was swallowed (returned instead of thrown), lettingexecute()fall through to the success log.How?
Added
401to both lists:packages/base/src/helpers/retry.ts-- bail immediately on 401 (no retries)packages/plugin-dora/src/commands/deployment.ts-- throw on 401 (propagates out ofexecute(), skips the success log, exits non-zero)Added a test that mocks a 401 response and asserts exit code is non-zero and the success message is absent.
Review checklist