Skip to content

[FRSLES-848] add --sidecar-image flag to aas and container-app instrument#2290

Merged
ava-silver merged 2 commits into
masterfrom
ava.silver/chore/add---sidecar-image-flag-to-aas-and-container-app-instrument
Apr 24, 2026
Merged

[FRSLES-848] add --sidecar-image flag to aas and container-app instrument#2290
ava-silver merged 2 commits into
masterfrom
ava.silver/chore/add---sidecar-image-flag-to-aas-and-container-app-instrument

Conversation

@ava-silver

@ava-silver ava-silver commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

What and why?

Adds --sidecar-image flag to aas instrument and container-app instrument, matching the existing flag on cloud-run instrument. Allows users to pin or override the sidecar container image (e.g. to a specific digest) rather than always using the default index.docker.io/datadog/serverless-init:latest.

How?

  • Added sidecarImage to AasConfigOptions and ContainerAppConfigOptions
  • Added --sidecar-image option to both base instrument commands, defaulting to SIDECAR_IMAGE
  • Updated plugin implementations to use config.sidecarImage in place of the hardcoded constant
  • For AAS, also updated the validation check in instrumentSidecar so existing sidecars with a matching custom image aren't unnecessarily re-deployed
  • READMEs auto-updated by the lint-readme hook

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ava-silver ava-silver changed the title chore: add --sidecar-image flag to aas and container-app instrument [SVLS] add --sidecar-image flag to aas and container-app instrument Apr 23, 2026
@ava-silver ava-silver added enhancement New feature or request serverless Related to [aas, cloud-run, lambda, stepfunctions] labels Apr 23, 2026
@ava-silver
ava-silver marked this pull request as ready for review April 23, 2026 21:37
@ava-silver
ava-silver requested review from a team as code owners April 23, 2026 21:37
@ava-silver
ava-silver requested a review from avangelillo April 23, 2026 21:37
@ava-silver ava-silver changed the title [SVLS] add --sidecar-image flag to aas and container-app instrument [FRSLES-848] add --sidecar-image flag to aas and container-app instrument Apr 23, 2026
@ava-silver
ava-silver merged commit 980fc29 into master Apr 24, 2026
97 of 103 checks passed
@ava-silver
ava-silver deleted the ava.silver/chore/add---sidecar-image-flag-to-aas-and-container-app-instrument branch April 24, 2026 15:16
@ava-silver ava-silver mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request serverless Related to [aas, cloud-run, lambda, stepfunctions]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants