[junit upload] Fix wrongly processed glob patterns#1315
Merged
juan-fernandez merged 4 commits intomasterfrom May 28, 2024
Merged
[junit upload] Fix wrongly processed glob patterns#1315juan-fernandez merged 4 commits intomasterfrom
juan-fernandez merged 4 commits intomasterfrom
Conversation
juan-fernandez
changed the title
juan-fernandez
added
the
software-delivery
Datadog ReportBranch report: ✅ 0 Failed, 240 Passed, 0 Skipped, 1m 31.34s Total duration (1m 26.22s time saved) |
juan-fernandez
commented
May 28, 2024
| - name: Run junit upload test (metrics) | ||
| run: yarn datadog-ci junit upload --service=datadog-ci-e2e-tests-junit artifacts/e2e/junit-reports --metrics testmeasure2:60 --report-metrics sessionmeasure2:80 | ||
| - name: Run junit upload test (metrics), passing glob as literal string | ||
| run: yarn datadog-ci junit upload --service=datadog-ci-e2e-tests-junit '**/junit-reports/**' --metrics testmeasure2:60 --report-metrics sessionmeasure2:80 |
Contributor
Author
There was a problem hiding this comment.
by passing quotation marks the pattern is not expanded and is managed by the CLI. This makes for a more complete test and also helps testing the usage of https://github.com/DataDog/junit-upload-github-action/
anmarchenko
approved these changes
May 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes #1304
How?
We make sure that
buildPathis not called when not necessary.Additionally we've also improved testing of the GHA in DataDog/junit-upload-github-action#17
Review checklist