Skip to content

Revert "Revert "Change Windows Containers to Windows Server Nano""#5898

Merged
julien-lebot merged 1 commit into
masterfrom
revert-5589-revert-5488-albertvaka/containerized-windows-nano
Aug 20, 2020
Merged

Revert "Revert "Change Windows Containers to Windows Server Nano""#5898
julien-lebot merged 1 commit into
masterfrom
revert-5589-revert-5488-albertvaka/containerized-windows-nano

Conversation

@julien-lebot

@julien-lebot julien-lebot commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Reverts #5589 since giampaolo/psutil#1768 has been merged.

@julien-lebot julien-lebot added this to the 7.22.0 milestone Jul 6, 2020
@julien-lebot
julien-lebot requested a review from a team as a code owner July 6, 2020 08:12
albertvaka
albertvaka approved these changes Jul 6, 2020
View reviewed changes

@albertvaka albertvaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump the dependencies on psutils (I think they all are in integrations-core) to include the fixed version as well.

@julien-lebot julien-lebot modified the milestones: 7.22.0, 7.23.0 Aug 6, 2020
@tonyredondo

tonyredondo commented Aug 19, 2020

Copy link
Copy Markdown
Member

Hi! ✋ do you know what is this PR missing to get merged? We are working in the CI/CD integration project and launching the agent in a windows pipeline take too long due the image size, we think this would help us a lot.

@mx-psi

mx-psi commented Aug 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I believe we just have to bump psutil, let me open a PR for that.

@mx-psi mx-psi mentioned this pull request Aug 19, 2020
Merged
4 tasks
@tonyredondo

tonyredondo commented Aug 20, 2020

Copy link
Copy Markdown
Member

I believe we just have to bump psutil, let me open a PR for that.

Great! and I've just saw that it got merged! 🎉

@julien-lebot
julien-lebot force-pushed the revert-5589-revert-5488-albertvaka/containerized-windows-nano branch from 5efd000 to 6adc00e Compare August 20, 2020 09:54
@julien-lebot

julien-lebot commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

I've ran some sanity checks on datadog/agent-dev:revert-5589-revert-5488-albertvaka-containerized-windows-nano-py3-win1809 and the agent seems to be working fine, so I'm going to go ahead and merge this.

@julien-lebot
julien-lebot merged commit fa1ffdc into master Aug 20, 2020
@julien-lebot
julien-lebot deleted the revert-5589-revert-5488-albertvaka/containerized-windows-nano branch August 20, 2020 13:53
@mx-psi mx-psi mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@albertvaka albertvaka albertvaka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed [deprecated] team/agent-platform

Projects

None yet

Milestone

7.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@julien-lebot @tonyredondo @mx-psi @albertvaka