Skip to content

[ADP] bypass non-Linux OS gate via DD_DATA_PLANE_FORCE_ENABLE#50239

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
jszwedko/only-apply-gate-release-builds
May 4, 2026
Merged

[ADP] bypass non-Linux OS gate via DD_DATA_PLANE_FORCE_ENABLE#50239
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
jszwedko/only-apply-gate-release-builds

Conversation

@jszwedko

@jszwedko jszwedko commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Follows up on #50151. Adds DD_DATA_PLANE_FORCE_ENABLE=true as a developer escape hatch for the non-Linux OS gate in sanitizeDataPlaneConfig.

Test plan

  • dda inv test --targets=./pkg/config/setup/... passes (295 tests, including 4 new bypass cases)
  • Verify on macOS: set DD_DATA_PLANE_FORCE_ENABLE=true in datadog.yaml env and confirm data_plane.enabled is honoured

🤖 Generated with Claude Code

@jszwedko
feat(adp): bypass non-Linux OS gate via DD_DATA_PLANE_FORCE_ENABLE
cbdaf8b 
Developers on macOS/Windows can now set DD_DATA_PLANE_FORCE_ENABLE=true
to skip the sanitizeDataPlaneConfig override and test ADP locally.
The env var is injected as a func parameter so tests use stubs and
the production path uses os.Getenv with no global state.
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-configuration labels May 1, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label May 1, 2026
@jszwedko
jszwedko marked this pull request as ready for review May 1, 2026 18:00
@jszwedko
jszwedko requested a review from a team as a code owner May 1, 2026 18:00
@jszwedko
jszwedko requested a review from rahulkaukuntla May 1, 2026 18:00
@jszwedko jszwedko added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels May 1, 2026
@datadog-prod-us1-5

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-sts Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 3fd9f396:

Results for datadog-agent_7.80.0~devel.git.403.cbdaf8b.pipeline.111070935-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3fd9f39
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 740.776 MiB
✅ agent_deb_amd64_fips 699.171 MiB
✅ agent_heroku_amd64 309.189 MiB
✅ agent_msi 607.450 MiB
✅ agent_rpm_amd64 740.760 MiB
✅ agent_rpm_amd64_fips 699.155 MiB
✅ agent_rpm_arm64 718.721 MiB
✅ agent_rpm_arm64_fips 680.226 MiB
✅ agent_suse_amd64 740.760 MiB
✅ agent_suse_amd64_fips 699.155 MiB
✅ agent_suse_arm64 718.721 MiB
✅ agent_suse_arm64_fips 680.226 MiB
✅ docker_agent_amd64 801.160 MiB
✅ docker_agent_arm64 803.942 MiB
✅ docker_agent_jmx_amd64 992.080 MiB
✅ docker_agent_jmx_arm64 983.640 MiB
✅ docker_cluster_agent_amd64 206.563 MiB
✅ docker_cluster_agent_arm64 220.571 MiB
✅ docker_cws_instrumentation_amd64 7.142 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 39.359 MiB
✅ docker_dogstatsd_arm64 37.565 MiB
✅ dogstatsd_deb_amd64 30.020 MiB
✅ dogstatsd_deb_arm64 28.161 MiB
✅ dogstatsd_rpm_amd64 30.020 MiB
✅ dogstatsd_suse_amd64 30.020 MiB
✅ iot_agent_deb_amd64 44.450 MiB
✅ iot_agent_deb_arm64 41.427 MiB
✅ iot_agent_deb_armhf 42.167 MiB
✅ iot_agent_rpm_amd64 44.451 MiB
✅ iot_agent_suse_amd64 44.451 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +11.96 KiB (0.01% increase) 175.158 → 175.170 → 179.160
✅ agent_deb_amd64_fips -3.77 KiB (0.00% reduction) 166.999 → 166.995 → 174.440
✅ agent_heroku_amd64 neutral 74.926 MiB → 80.310
✅ agent_msi neutral 140.531 MiB → 148.730
✅ agent_rpm_amd64 -21.92 KiB (0.01% reduction) 177.222 → 177.200 → 182.080
✅ agent_rpm_amd64_fips -3.57 KiB (0.00% reduction) 168.344 → 168.340 → 174.140
✅ agent_rpm_arm64 +3.32 KiB (0.00% increase) 159.332 → 159.335 → 163.610
✅ agent_rpm_arm64_fips -2.21 KiB (0.00% reduction) 151.681 → 151.679 → 156.850
✅ agent_suse_amd64 -21.92 KiB (0.01% reduction) 177.222 → 177.200 → 182.080
✅ agent_suse_amd64_fips -3.57 KiB (0.00% reduction) 168.344 → 168.340 → 174.140
✅ agent_suse_arm64 +3.32 KiB (0.00% increase) 159.332 → 159.335 → 163.610
✅ agent_suse_arm64_fips -2.21 KiB (0.00% reduction) 151.681 → 151.679 → 156.850
✅ docker_agent_amd64 -3.34 KiB (0.00% reduction) 267.526 → 267.523 → 272.990
✅ docker_agent_arm64 +2.42 KiB (0.00% increase) 254.543 → 254.545 → 261.470
✅ docker_agent_jmx_amd64 -8.64 KiB (0.00% reduction) 336.196 → 336.188 → 341.610
✅ docker_agent_jmx_arm64 -6.48 KiB (0.00% reduction) 319.181 → 319.174 → 326.050
✅ docker_cluster_agent_amd64 -3.1 KiB (0.00% reduction) 72.400 → 72.397 → 73.460
✅ docker_cluster_agent_arm64 +12.76 KiB (0.02% increase) 67.852 → 67.864 → 68.680
✅ docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 15.235 MiB → 15.870
✅ docker_dogstatsd_arm64 +4.61 KiB (0.03% increase) 14.549 → 14.554 → 14.890
✅ dogstatsd_deb_amd64 neutral 7.940 MiB → 8.830
✅ dogstatsd_deb_arm64 +2.14 KiB (0.03% increase) 6.823 → 6.825 → 7.750
✅ dogstatsd_rpm_amd64 neutral 7.953 MiB → 8.840
✅ dogstatsd_suse_amd64 neutral 7.953 MiB → 8.840
✅ iot_agent_deb_amd64 +4.12 KiB (0.03% increase) 11.697 → 11.701 → 13.210
✅ iot_agent_deb_arm64 neutral 9.997 MiB → 11.620
✅ iot_agent_deb_armhf neutral 10.206 MiB → 11.780
✅ iot_agent_rpm_amd64 neutral 11.715 MiB → 13.230
✅ iot_agent_suse_amd64 neutral 11.715 MiB → 13.230

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 37a2fa9b-5803-474c-94d3-e334add2c9cf

Baseline: ab10ba7
Comparison: fdfb3e3
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.75 [-0.23, +5.72] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.75 [-0.23, +5.72] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.66 [+0.50, +0.82] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.57 [+0.32, +0.83] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.37 [+0.13, +0.61] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.24 [+0.09, +0.40] 1 Logs
➖ docker_containers_memory memory utilization +0.23 [+0.12, +0.33] 1 Logs
➖ file_tree memory utilization +0.19 [+0.14, +0.24] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.16 [-0.03, +0.35] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.16 [+0.12, +0.20] 1 Logs bounds checks dashboard
➖ file_to_blackhole_500ms_latency egress throughput +0.06 [-0.35, +0.46] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.38, +0.46] 1 Logs
➖ ddot_logs memory utilization +0.04 [-0.02, +0.10] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.09, +0.14] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.10] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.19, +0.19] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.21, +0.19] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.03 [-0.57, +0.50] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.07 [-0.12, -0.02] 1 Logs
➖ ddot_metrics memory utilization -0.26 [-0.46, -0.06] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.27 [-0.45, -0.10] 1 Logs
➖ quality_gate_idle memory utilization -0.28 [-0.32, -0.23] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -0.41 [-1.38, +0.56] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.55 [-0.65, -0.44] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ docker_containers_cpu simple_check_run 10/10 686 ≥ 26
✅ docker_containers_memory memory_usage 10/10 245.42MiB ≤ 370MiB
✅ docker_containers_memory simple_check_run 10/10 694 ≥ 26
✅ file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
✅ file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_1000ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
✅ file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_100ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
✅ file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
✅ file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
✅ quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 142.33MiB ≤ 147MiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 473.32MiB ≤ 495MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 174.38MiB ≤ 195MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 363.77 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 370.27MiB ≤ 430MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

@jszwedko
jszwedko changed the base branch from main to worktree-bump-adp May 2, 2026 15:57
Base automatically changed from worktree-bump-adp to main May 2, 2026 18:22
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit fdfb3e3 into main May 4, 2026
310 of 316 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jszwedko/only-apply-gate-release-builds branch May 4, 2026 15:17
@github-actions github-actions Bot added this to the 7.80.0 milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahulkaukuntla rahulkaukuntla rahulkaukuntla approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Milestone

7.80.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jszwedko @rahulkaukuntla