[ADP] gate `data_plane.enabled` to Linux at config load time by jszwedko · Pull Request #50151 · DataDog/datadog-agent

jszwedko · 2026-04-30T00:05:02Z

Summary

ADP (Agent Data Plane) is Linux-only, but data_plane.enabled: true was silently ignored on Windows and macOS with no feedback to the user. This PR adds a platform gate in the config loading path that emits a warning and resets data_plane.enabled to false on non-Linux platforms, ensuring every downstream consumer (dogstatsd ADP path, OTLP proxy) automatically sees the correct value without per-site guards.

Follows up on review feedback from #49891.

No changelog entry since ADP still is a "hidden feature".

Test plan

dda inv test --targets=./pkg/config/setup/... passes (291 tests)

🤖 Generated with Claude Code

ADP is a Linux-only component. Rather than letting each downstream consumer silently ignore the flag on non-Linux, reset data_plane.enabled to false (with a warning) in sanitizeDataPlaneConfig, called from LoadDatadog, so all consumers automatically see the correct value regardless of platform. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- Add GetSource assertion to TestSanitizeDataPlaneConfigNonLinux to verify the override is applied at SourceAgentRuntime precedence level - Replace raw string "data_plane.enabled" with DataPlaneEnabled constant in sanitizeDataPlaneConfig function for consistency and DRY principle Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84e5eac814

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Without this, a fleet policy (SourceFleetPolicies) applied after LoadDatadog could set data_plane.enabled=true and bypass the gate, since SourceAgentRuntime was only written when the value was already true at sanitize time. Now the override is always written on non-Linux so SourceFleetPolicies (lower priority) can never win. The warning is still only emitted when the value was actually true at call time. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

datadog-prod-us1-4 · 2026-04-30T00:32:59Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.20% (-0.04%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 03e8787 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-04-30T01:04:21Z

Files inventory check summary

File checks results against ancestor a0db807d:

Results for datadog-agent_7.80.0~devel.git.342.03e8787.pipeline.110609259-1_amd64.deb:

No change detected

dd-octo-sts · 2026-04-30T01:07:56Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a0db807
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64_fips	+8.45 KiB (0.00% increase)	698.688 → 698.697 → 702.690
✅	agent_msi	+5.0 KiB (0.00% increase)	607.024 → 607.029 → 623.540
✅	agent_rpm_amd64_fips	+8.45 KiB (0.00% increase)	698.672 → 698.680 → 702.670
✅	agent_rpm_arm64_fips	+5.37 KiB (0.00% increase)	679.762 → 679.768 → 684.460
✅	agent_suse_amd64_fips	+8.45 KiB (0.00% increase)	698.672 → 698.680 → 702.670
✅	agent_suse_arm64_fips	+5.37 KiB (0.00% increase)	679.762 → 679.768 → 684.460
✅	docker_agent_jmx_amd64	+4.67 KiB (0.00% increase)	991.660 → 991.664 → 996.590
✅	dogstatsd_deb_arm64	+4.0 KiB (0.01% increase)	28.146 → 28.149 → 29.270
✅	iot_agent_deb_armhf	+4.0 KiB (0.01% increase)	42.124 → 42.128 → 42.740

22 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	740.286 MiB
✅	agent_heroku_amd64	309.138 MiB
✅	agent_rpm_amd64	740.270 MiB
✅	agent_rpm_arm64	718.324 MiB
✅	agent_suse_amd64	740.270 MiB
✅	agent_suse_arm64	718.324 MiB
✅	docker_agent_amd64	800.744 MiB
✅	docker_agent_arm64	803.608 MiB
✅	docker_agent_jmx_arm64	983.307 MiB
✅	docker_cluster_agent_amd64	206.402 MiB
✅	docker_cluster_agent_arm64	220.508 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.351 MiB
✅	docker_dogstatsd_arm64	37.565 MiB
✅	dogstatsd_deb_amd64	30.005 MiB
✅	dogstatsd_rpm_amd64	30.005 MiB
✅	dogstatsd_suse_amd64	30.005 MiB
✅	iot_agent_deb_amd64	44.404 MiB
✅	iot_agent_deb_arm64	41.392 MiB
✅	iot_agent_rpm_amd64	44.404 MiB
✅	iot_agent_suse_amd64	44.404 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-28.6 KiB (0.02% reduction)	175.036 → 175.008 → 179.160
✅	agent_deb_amd64_fips	-18.96 KiB (0.01% reduction)	166.782 → 166.764 → 174.440
✅	agent_heroku_amd64	neutral	74.919 MiB → 80.310
✅	agent_msi	-20.0 KiB (0.01% reduction)	140.406 → 140.387 → 148.730
✅	agent_rpm_amd64	+39.98 KiB (0.02% increase)	177.028 → 177.067 → 182.080
✅	agent_rpm_amd64_fips	-17.97 KiB (0.01% reduction)	168.210 → 168.193 → 174.140
✅	agent_rpm_arm64	+16.55 KiB (0.01% increase)	159.253 → 159.270 → 163.610
✅	agent_rpm_arm64_fips	-33.2 KiB (0.02% reduction)	151.556 → 151.523 → 156.850
✅	agent_suse_amd64	+39.98 KiB (0.02% increase)	177.028 → 177.067 → 182.080
✅	agent_suse_amd64_fips	-17.97 KiB (0.01% reduction)	168.210 → 168.193 → 174.140
✅	agent_suse_arm64	+16.55 KiB (0.01% increase)	159.253 → 159.270 → 163.610
✅	agent_suse_arm64_fips	-33.2 KiB (0.02% reduction)	151.556 → 151.523 → 156.850
✅	docker_agent_amd64	+17.17 KiB (0.01% increase)	267.358 → 267.375 → 272.990
✅	docker_agent_arm64	+13.05 KiB (0.01% increase)	254.402 → 254.414 → 261.470
✅	docker_agent_jmx_amd64	+14.67 KiB (0.00% increase)	336.022 → 336.037 → 341.610
✅	docker_agent_jmx_arm64	-19.97 KiB (0.01% reduction)	319.047 → 319.027 → 326.050
✅	docker_cluster_agent_amd64	neutral	72.336 MiB → 73.460
✅	docker_cluster_agent_arm64	-3.59 KiB (0.01% reduction)	67.807 → 67.803 → 68.680
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.232 MiB → 15.870
✅	docker_dogstatsd_arm64	+6.89 KiB (0.05% increase)	14.546 → 14.553 → 14.890
✅	dogstatsd_deb_amd64	neutral	7.938 MiB → 8.830
✅	dogstatsd_deb_arm64	neutral	6.819 MiB → 7.750
✅	dogstatsd_rpm_amd64	neutral	7.947 MiB → 8.840
✅	dogstatsd_suse_amd64	neutral	7.947 MiB → 8.840
✅	iot_agent_deb_amd64	+3.75 KiB (0.03% increase)	11.687 → 11.691 → 13.210
✅	iot_agent_deb_arm64	neutral	9.990 MiB → 11.620
✅	iot_agent_deb_armhf	neutral	10.193 MiB → 11.780
✅	iot_agent_rpm_amd64	neutral	11.705 MiB → 13.230
✅	iot_agent_suse_amd64	neutral	11.705 MiB → 13.230

cit-pr-commenter-54b7da · 2026-04-30T01:24:05Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7e0068d4-912a-4adb-9831-bd27385ac0b1

Baseline: 7d29ffb
Comparison: b27860f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.10	[-3.10, +2.90]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.05	[+0.07, +2.03]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.64	[+0.49, +0.79]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.58	[+0.42, +0.74]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.57	[+0.52, +0.61]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.31	[+0.21, +0.41]	1	Logs
➖	quality_gate_idle	memory utilization	+0.25	[+0.20, +0.30]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.25	[+0.05, +0.44]	1	Logs
➖	docker_containers_memory	memory utilization	+0.22	[+0.12, +0.32]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.21	[+0.02, +0.39]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.20, +0.19]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.10, +0.09]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.13, +0.11]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.19]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.02	[-0.06, +0.02]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.46, +0.39]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.44, +0.36]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.06	[-0.60, +0.47]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.10	[-3.10, +2.90]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.19	[-0.44, +0.06]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.23	[-0.28, -0.18]	1	Logs
➖	ddot_logs	memory utilization	-0.28	[-0.35, -0.21]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.29	[-0.53, -0.05]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.41	[-0.60, -0.22]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	700 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	252.25MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	700 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	143.01MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	467.40MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	176.24MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	341.62 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	380.95MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

## Summary Follows up on #50151. Adds `DD_DATA_PLANE_FORCE_ENABLE=true` as a developer escape hatch for the non-Linux OS gate in `sanitizeDataPlaneConfig`. ## Test plan - [x] `dda inv test --targets=./pkg/config/setup/...` passes (295 tests, including 4 new bypass cases) - [x] Verify on macOS: set `DD_DATA_PLANE_FORCE_ENABLE=true` in `datadog.yaml` env and confirm `data_plane.enabled` is honoured 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: jesse.szwedko <[email protected]>

jszwedko and others added 2 commits April 29, 2026 16:57

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-configuration labels Apr 30, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Apr 30, 2026

refactor(config): convert data_plane sanitize tests to table-driven

84e5eac

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

jszwedko changed the title ~~Gate data_plane.enabled to Linux at config load time~~ [ADP] gate data_plane.enabled to Linux at config load time Apr 30, 2026

jszwedko added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Apr 30, 2026

jszwedko marked this pull request as ready for review April 30, 2026 00:12

jszwedko requested a review from a team as a code owner April 30, 2026 00:12

jszwedko requested a review from s-alad April 30, 2026 00:12

jszwedko added the ask-review Ask in slack required teams to review this PR label Apr 30, 2026

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread pkg/config/setup/config.go

tobz approved these changes Apr 30, 2026

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Apr 30, 2026

s-alad approved these changes Apr 30, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit b27860f into main Apr 30, 2026
274 of 275 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the jszwedko/gate-adp-config-platform branch April 30, 2026 16:54

github-actions Bot added this to the 7.80.0 milestone Apr 30, 2026

jszwedko mentioned this pull request May 1, 2026

[ADP] bypass non-Linux OS gate via DD_DATA_PLANE_FORCE_ENABLE #50239

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ADP] gate `data_plane.enabled` to Linux at config load time#50151

[ADP] gate `data_plane.enabled` to Linux at config load time#50151
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
jszwedko/gate-adp-config-platform

jszwedko commented Apr 30, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

datadog-prod-us1-4 Bot commented Apr 30, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 30, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jszwedko commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-prod-us1-4 Bot commented Apr 30, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Files inventory check summary

Results for datadog-agent_7.80.0~devel.git.342.03e8787.pipeline.110609259-1_amd64.deb:

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jszwedko commented Apr 30, 2026 •

edited

Loading

datadog-prod-us1-4 Bot commented Apr 30, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

cit-pr-commenter-54b7da Bot commented Apr 30, 2026 •

edited

Loading