enhancement(dogstatsd): Default ADP dogstatsd pipeline enabled to true by jszwedko · Pull Request #49891 · DataDog/datadog-agent

jszwedko · 2026-04-24T19:11:12Z

Summary

Brings the Core Agent's routing between its in-process DogStatsD server and the Agent Data Plane (ADP) into line with the truth table defined in DataDog/saluki#1334 (comment). With this change, enabling ADP (data_plane.enabled: true) is sufficient to move DogStatsD onto it by default, and setting use_dogstatsd: false now reliably suppresses DogStatsD in both the Core Agent and ADP via the existing config stream — closing a gap where ADP ignored the global master toggle.

No changelog entry since ADP is still a "hidden" feature.

Refs DataDog/saluki#1334

Test plan

go test -tags test ./comp/dogstatsd/config/... -count=1 passes TestTruthTable (21 rows) and TestLogResolvedMode.
go test -tags test ./pkg/config/setup/... -count=1 passes, including TestApplyUseDogstatsdSuppression.
Manual verification on a dev agent: with use_dogstatsd: false + data_plane.enabled: true + data_plane.dogstatsd.enabled: true, both the Core Agent and the ADP log confirm DogStatsD is off.
Manual verification: with only data_plane.enabled: true set (no data_plane.dogstatsd.enabled), the Core Agent's startup log prints DogStatsD routing: ... -> agent-data-plane and the in-process server is not started.

Tracked by DADP-38

Adds exhaustive 21-row truth-table coverage for Enabled(), EnabledInternal(), and enabledDataPlane() against the combinations of use_dogstatsd, data_plane.enabled, and data_plane.dogstatsd.enabled. Refs DataDog/saluki#1334

When data_plane.enabled is on, ADP takes ownership of DogStatsD by default, matching the truth table at DataDog/saluki#1334 (comment). data_plane.enabled still defaults to false, so this is a no-op for users who have not opted into ADP. Refs DataDog/saluki#1334

Refs DataDog/saluki#1334

…d=false Adds applyUseDogstatsdSuppression as a post-load override that forces data_plane.dogstatsd.enabled to false when the global use_dogstatsd master toggle is false. This guarantees the Agent Data Plane — which reads the resolved value via the config stream — skips its DogStatsD source, preserving the truth table's "off everywhere when use_dogstatsd=false" rows. data_plane.enabled is not touched, so non-DSD ADP pipelines (OTLP, etc.) continue to honor their own toggles. Refs DataDog/saluki#1334

Emits a single INFO line summarizing the effective DogStatsD routing decision (off / core-agent / agent-data-plane) and the three toggles that drive it, so operators can confirm their configuration from agent logs. Refs DataDog/saluki#1334

DD_ADP_ENABLED remains honored for back-compat but now emits a single deprecation warning per process so operators discover the replacement settings (data_plane.enabled, data_plane.dogstatsd.enabled). Refs DataDog/saluki#1334

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb8f0a943f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Removes the sync.Once-guarded deprecation warning for the legacy DD_ADP_ENABLED env var — the fallback behavior stays, but the log line was only noise for reviewers. Also renames the "core-agent" routing label emitted by LogResolvedMode to just "agent" for consistency with other log surfaces. Refs DataDog/saluki#1334

Replaces the ad-hoc tri{set,val} struct with plain *bool to encode the "not set by the user" third state. Removes the nonsense tri{false,true} failure mode and reads more cleanly at the row literals. Refs DataDog/saluki#1334

Switches TestApplyUseDogstatsdSuppression from direct SetWithoutSource calls to confFromYAML so the test exercises the same config-load path users hit in production, matching the surrounding test file's style. Refs DataDog/saluki#1334

Removes the startup log that summarized the resolved DogStatsD routing decision. The extra surface area distracted reviewers and the same information is reachable via existing config-dump tooling. Refs DataDog/saluki#1334

Collapses the two early-return guards in applyUseDogstatsdSuppression into one if-statement that wraps the log and Set calls. Behaviorally equivalent; reads more directly. Refs DataDog/saluki#1334

datadog-datadog-prod-us1 · 2026-04-24T19:36:07Z

🎯 Code Coverage (details)
• Patch Coverage: 83.33%
• Overall Coverage: 50.24% (-0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 05f0a7d | Docs | Datadog PR Page | Give us feedback!}

Mirrors the runtime default flip in pkg/config/setup/common_settings.go so schema consumers and generated config docs advertise the new behavior. Refs DataDog/saluki#1334

dd-octo-sts · 2026-04-24T20:03:13Z

Files inventory check summary

File checks results against ancestor d94932f5:

Results for datadog-agent_7.80.0~devel.git.417.05f0a7d.pipeline.110817448-1_amd64.deb:

No change detected

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd00635188

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dd-octo-sts · 2026-04-24T20:11:49Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d94932f
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+2.49 KiB (0.00% increase)	740.772 → 740.775 → 750.310
✅	agent_deb_amd64_fips	+6.46 KiB (0.00% increase)	699.171 → 699.178 → 702.690
✅	agent_msi	+9.0 KiB (0.00% increase)	607.444 → 607.453 → 623.540
✅	agent_rpm_amd64	+2.49 KiB (0.00% increase)	740.756 → 740.759 → 750.280
✅	agent_rpm_amd64_fips	+6.46 KiB (0.00% increase)	699.155 → 699.161 → 702.670
✅	agent_suse_amd64	+2.49 KiB (0.00% increase)	740.756 → 740.759 → 750.280
✅	agent_suse_amd64_fips	+6.46 KiB (0.00% increase)	699.155 → 699.161 → 702.670
✅	docker_cluster_agent_amd64	+4.02 KiB (0.00% increase)	206.543 → 206.547 → 207.600
✅	iot_agent_deb_arm64	+4.03 KiB (0.01% increase)	41.423 → 41.427 → 42.560
✅	iot_agent_deb_armhf	+4.02 KiB (0.01% increase)	42.163 → 42.167 → 42.740

21 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_heroku_amd64	309.182 MiB
✅	agent_rpm_arm64	718.717 MiB
✅	agent_rpm_arm64_fips	680.223 MiB
✅	agent_suse_arm64	718.717 MiB
✅	agent_suse_arm64_fips	680.223 MiB
✅	docker_agent_amd64	801.155 MiB
✅	docker_agent_arm64	803.938 MiB
✅	docker_agent_jmx_amd64	992.075 MiB
✅	docker_agent_jmx_arm64	983.636 MiB
✅	docker_cluster_agent_arm64	220.571 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.358 MiB
✅	docker_dogstatsd_arm64	37.565 MiB
✅	dogstatsd_deb_amd64	30.020 MiB
✅	dogstatsd_deb_arm64	28.161 MiB
✅	dogstatsd_rpm_amd64	30.020 MiB
✅	dogstatsd_suse_amd64	30.020 MiB
✅	iot_agent_deb_amd64	44.443 MiB
✅	iot_agent_rpm_amd64	44.443 MiB
✅	iot_agent_suse_amd64	44.443 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-9.83 KiB (0.01% reduction)	175.140 → 175.131 → 179.160
✅	agent_deb_amd64_fips	-10.27 KiB (0.01% reduction)	166.969 → 166.959 → 174.440
✅	agent_heroku_amd64	-5.95 KiB (0.01% reduction)	74.923 → 74.917 → 80.310
✅	agent_msi	+8.0 KiB (0.01% increase)	140.504 → 140.512 → 148.730
✅	agent_rpm_amd64	+29.4 KiB (0.02% increase)	177.165 → 177.194 → 182.080
✅	agent_rpm_amd64_fips	neutral	168.353 MiB → 174.140
✅	agent_rpm_arm64	-3.97 KiB (0.00% reduction)	159.313 → 159.309 → 163.610
✅	agent_rpm_arm64_fips	-9.05 KiB (0.01% reduction)	151.681 → 151.672 → 156.850
✅	agent_suse_amd64	+29.4 KiB (0.02% increase)	177.165 → 177.194 → 182.080
✅	agent_suse_amd64_fips	neutral	168.353 MiB → 174.140
✅	agent_suse_arm64	-3.97 KiB (0.00% reduction)	159.313 → 159.309 → 163.610
✅	agent_suse_arm64_fips	-9.05 KiB (0.01% reduction)	151.681 → 151.672 → 156.850
✅	docker_agent_amd64	+10.05 KiB (0.00% increase)	267.524 → 267.534 → 272.990
✅	docker_agent_arm64	-6.46 KiB (0.00% reduction)	254.547 → 254.540 → 261.470
✅	docker_agent_jmx_amd64	+4.96 KiB (0.00% increase)	336.192 → 336.197 → 341.610
✅	docker_agent_jmx_arm64	+6.77 KiB (0.00% increase)	319.175 → 319.181 → 326.050
✅	docker_cluster_agent_amd64	neutral	72.396 MiB → 73.460
✅	docker_cluster_agent_arm64	+2.74 KiB (0.00% increase)	67.849 → 67.852 → 68.680
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.235 MiB → 15.870
✅	docker_dogstatsd_arm64	-5.85 KiB (0.04% reduction)	14.555 → 14.549 → 14.890
✅	dogstatsd_deb_amd64	-2.29 KiB (0.03% reduction)	7.941 → 7.939 → 8.830
✅	dogstatsd_deb_arm64	neutral	6.823 MiB → 7.750
✅	dogstatsd_rpm_amd64	neutral	7.950 MiB → 8.840
✅	dogstatsd_suse_amd64	neutral	7.950 MiB → 8.840
✅	iot_agent_deb_amd64	neutral	11.700 MiB → 13.210
✅	iot_agent_deb_arm64	-3.01 KiB (0.03% reduction)	9.995 → 9.992 → 11.620
✅	iot_agent_deb_armhf	neutral	10.203 MiB → 11.780
✅	iot_agent_rpm_amd64	-4.59 KiB (0.04% reduction)	11.719 → 11.715 → 13.230
✅	iot_agent_suse_amd64	-4.59 KiB (0.04% reduction)	11.719 → 11.715 → 13.230

cit-pr-commenter-54b7da · 2026-04-24T20:23:02Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d768486b-40e6-4077-9d2c-7a5b9e300270

Baseline: 9b982e1
Comparison: 4b85274
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.25	[-0.70, +5.21]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.25	[-0.70, +5.21]	1	Logs
➖	quality_gate_logs	% cpu utilization	+1.19	[+0.21, +2.17]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.63	[+0.39, +0.88]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.56	[+0.36, +0.76]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.49	[+0.40, +0.59]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.37	[+0.18, +0.55]	1	Logs
➖	quality_gate_idle	memory utilization	+0.31	[+0.26, +0.36]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.28	[+0.13, +0.44]	1	Logs
➖	docker_containers_memory	memory utilization	+0.20	[+0.07, +0.34]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.14	[-0.10, +0.38]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.06	[-0.33, +0.45]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.48, +0.51]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.01	[-0.03, +0.06]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.19, +0.22]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.08, +0.09]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.10, +0.10]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.05	[-0.49, +0.38]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.07	[-0.13, -0.02]	1	Logs
➖	ddot_logs	memory utilization	-0.13	[-0.19, -0.07]	1	Logs
➖	file_tree	memory utilization	-0.39	[-0.44, -0.35]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.59	[-0.75, -0.44]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.66	[-0.81, -0.52]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	695 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	243.59MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	683 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	142.29MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	469.55MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	178.44MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	352.76 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	373.68MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Fleet policies are merged after LoadDatadog's override pass, so use_dogstatsd=false delivered via fleet policy would not suppress data_plane.dogstatsd.enabled. Export ApplyUseDogstatsdSuppression and call it explicitly in setupConfig after MergeFleetPolicy. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Gazelle generates this when run after the recent "Consolidate gazelle:exclude directives" change in main, since the broad `comp/dogstatsd` exclude was replaced by sibling-only excludes that no longer cover comp/dogstatsd/config. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

## Summary ADP (Agent Data Plane) is Linux-only, but `data_plane.enabled: true` was silently ignored on Windows and macOS with no feedback to the user. This PR adds a platform gate in the config loading path that emits a warning and resets `data_plane.enabled` to false on non-Linux platforms, ensuring every downstream consumer (dogstatsd ADP path, OTLP proxy) automatically sees the correct value without per-site guards. Follows up on review feedback from #49891. No changelog entry since ADP still is a "hidden feature". ## Test plan - [x] `dda inv test --targets=./pkg/config/setup/...` passes (291 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: jesse.szwedko <[email protected]>

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

…s DSD (#2965) dogstatsd: drop DD_USE_DOGSTATSD=false override when dataPlane handles DSD The Core Agent now observes data_plane.enabled and delegates DogStatsD to the Data Plane on its own (DataDog/datadog-agent#49891), so the operator no longer needs to set DD_USE_DOGSTATSD=false on the Core Agent (or on the single-container agent) when the dataPlane feature handles DSD. Combined with #2935 (which defaults dataPlane.dogstatsd.enabled to true), enabling dataPlane.enabled is sufficient to route DSD onto ADP. Address review: clarify comment, drop negative env-var assertions - Mention both data_plane.enabled and data_plane.dogstatsd.enabled in ManageNodeAgent's comment, since the Core Agent uses both to decide whether to run DogStatsD itself or delegate it to ADP. - Remove the now-superfluous DD_USE_DOGSTATSD assertions from the unit and e2e tests (no need to negatively assert the env var is unset), along with the assertContainerDoesNotHaveEnvVar helper. dogstatsd: gate DD_USE_DOGSTATSD=false removal on Agent >= 7.75 On Agent < 7.75, DD_DATA_PLANE_ENABLED / DD_DATA_PLANE_DOGSTATSD_ENABLED are unrecognised so the Core Agent starts DSD regardless, causing a bind conflict with ADP. Restore the explicit DD_USE_DOGSTATSD=false override for those agents while keeping the cleaner no-override path for >= 7.75. Uses the existing IsAboveMinVersion / GetAgentVersionFromImage machinery (same pattern as ProcessConfig, AppSec, KSM Core). Unknown / custom image tags fall back to AgentLatestVersion (7.77.2 > 7.75.0 → no override). fix lint: gci alignment in struct fields and const block Co-authored-by: jesse.szwedko <[email protected]>

jszwedko added 6 commits April 24, 2026 11:55

test(dogstatsd): add truth-table tests for DSD/ADP routing

82c2b5b

Adds exhaustive 21-row truth-table coverage for Enabled(), EnabledInternal(), and enabledDataPlane() against the combinations of use_dogstatsd, data_plane.enabled, and data_plane.dogstatsd.enabled. Refs DataDog/saluki#1334

test(config): add test for applyUseDogstatsdSuppression

ee36b42

Refs DataDog/saluki#1334

chore(dogstatsd): warn once when DD_ADP_ENABLED is used

cb8f0a9

DD_ADP_ENABLED remains honored for back-compat but now emits a single deprecation warning per process so operators discover the replacement settings (data_plane.enabled, data_plane.dogstatsd.enabled). Refs DataDog/saluki#1334

jszwedko requested review from a team as code owners April 24, 2026 19:11

jszwedko requested a review from dustmop April 24, 2026 19:11

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-metric-pipelines labels Apr 24, 2026

github-actions Bot added the medium review PR review might take time label Apr 24, 2026

dd-octo-sts Bot added the team/agent-configuration label Apr 24, 2026

jszwedko marked this pull request as draft April 24, 2026 19:15

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread pkg/config/setup/common_settings.go

jszwedko added 5 commits April 24, 2026 12:27

refactor(dogstatsd): express truth table with *bool

2a1c840

Replaces the ad-hoc tri{set,val} struct with plain *bool to encode the "not set by the user" third state. Removes the nonsense tri{false,true} failure mode and reads more cleanly at the row literals. Refs DataDog/saluki#1334

chore(dogstatsd): drop LogResolvedMode

50c59f8

Removes the startup log that summarized the resolved DogStatsD routing decision. The extra surface area distracted reviewers and the same information is reachable via existing config-dump tooling. Refs DataDog/saluki#1334

refactor(config): fold applyUseDogstatsdSuppression into single if

e147420

Collapses the two early-return guards in applyUseDogstatsdSuppression into one if-statement that wraps the log and Set calls. Behaviorally equivalent; reads more directly. Refs DataDog/saluki#1334

github-actions Bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Apr 24, 2026

chore(config): regenerate core schema for data_plane.dogstatsd default

fd00635

Mirrors the runtime default flip in pkg/config/setup/common_settings.go so schema consumers and generated config docs advertise the new behavior. Refs DataDog/saluki#1334

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Apr 24, 2026

jszwedko added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Apr 24, 2026

jszwedko marked this pull request as ready for review April 24, 2026 20:02

jszwedko changed the title ~~feat(dogstatsd): align Core-vs-ADP routing with truth table~~ enhancement(dogstatsd): Default ADP dogstatsd pipeline enabled to true Apr 24, 2026

jszwedko mentioned this pull request Apr 24, 2026

feat(config): enable remote_agent.configstream by default #49894

Closed

2 tasks

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread pkg/config/setup/common_settings.go Outdated

jszwedko added the ask-review Ask in slack required teams to review this PR label Apr 27, 2026

tobz reviewed Apr 27, 2026

View reviewed changes

Comment thread pkg/config/setup/common_settings.go

jszwedko mentioned this pull request Apr 29, 2026

feat(dogstatsd): enable ADP for dogstatsd with only data_plane.dogstatsd.enabled #49409

Closed

jszwedko requested a review from tobz April 29, 2026 20:30

tobz approved these changes Apr 29, 2026

View reviewed changes

rayz approved these changes Apr 29, 2026

View reviewed changes

dustmop approved these changes Apr 29, 2026

View reviewed changes

jszwedko and others added 2 commits April 29, 2026 15:28

Merge branch 'main' into jszwedko/adp-dogstatsd-truth-table

c133199

jszwedko requested a review from a team as a code owner April 29, 2026 23:59

dd-octo-sts Bot added the team/agent-build label Apr 29, 2026

jszwedko mentioned this pull request Apr 30, 2026

[ADP] gate data_plane.enabled to Linux at config load time #50151

Merged

1 task

jszwedko mentioned this pull request Apr 30, 2026

Investigate use_dogstatsd top-level toggle vs data_plane.dogstatsd.enabled. DataDog/saluki#1334

Closed

Merge branch 'main' into jszwedko/adp-dogstatsd-truth-table

daca433

aiuto approved these changes Apr 30, 2026

View reviewed changes

chore(config): update compressed core schema

05f0a7d

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

gh-worker-dd-mergequeue-cf854d Bot merged commit 4b85274 into main Apr 30, 2026
268 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the jszwedko/adp-dogstatsd-truth-table branch April 30, 2026 22:58

github-actions Bot added this to the 7.80.0 milestone Apr 30, 2026

jszwedko mentioned this pull request May 2, 2026

dogstatsd: drop DD_USE_DOGSTATSD=false override when dataPlane handles DSD DataDog/datadog-operator#2965

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

enhancement(dogstatsd): Default ADP dogstatsd pipeline enabled to true#49891

enhancement(dogstatsd): Default ADP dogstatsd pipeline enabled to true#49891
gh-worker-dd-mergequeue-cf854d[bot] merged 17 commits into
mainfrom
jszwedko/adp-dogstatsd-truth-table

jszwedko commented Apr 24, 2026 •

edited by atlassian Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented Apr 24, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

Uh oh!

dd-octo-sts Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 24, 2026 •

edited

Loading

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 24, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jszwedko commented Apr 24, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented Apr 24, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.80.0~devel.git.417.05f0a7d.pipeline.110817448-1_amd64.deb:

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jszwedko commented Apr 24, 2026 •

edited by atlassian Bot

Loading

datadog-datadog-prod-us1 Bot commented Apr 24, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

dd-octo-sts Bot commented Apr 24, 2026 •

edited

Loading

dd-octo-sts Bot commented Apr 24, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Apr 24, 2026 •

edited

Loading