Bump go to 1.25.9#49024
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoApr 9, 2026
Merged
Conversation
pgimalac
added
the
qa/done
dd-octo-sts
Bot
added
internal
Contributor
Gitlab CI Configuration ChangesModified Jobsvariables (configuration) variables:
AGENT_API_KEY_ORG2: agent-api-key-org-2
AGENT_APP_KEY_ORG2: agent-app-key-org-2
AGENT_BINARIES_DIR: bin/agent
AGENT_GITHUB_APP: agent-github-app
AGENT_QA_E2E: agent-qa-e2e
API_KEY_ORG2: ci.datadog-agent.datadog_api_key_org2
ARTIFACT_DOWNLOAD_ATTEMPTS: 2
ATLASSIAN_WRITE: atlassian-write
BTFHUB_ARCHIVE_BRANCH: main
BUCKET_BRANCH: dev
CACHE_COMPRESSION_LEVEL: slowest
CHANGELOG_COMMIT_SHA: ci.datadog-agent.gitlab_changelog_commit_sha
CHOCOLATEY_API_KEY: ci.datadog-agent.chocolatey_api_key
- CI_IMAGE_BTF_GEN: v105206457-cb3f8790
+ CI_IMAGE_BTF_GEN: v106628973-e0620387
CI_IMAGE_BTF_GEN_SUFFIX: ''
- CI_IMAGE_DOCKER_ARM64: v105206457-cb3f8790
? ^ ------- - --
+ CI_IMAGE_DOCKER_ARM64: v106628973-e0620387
? ^^^^^^^^^^^
CI_IMAGE_DOCKER_ARM64_SUFFIX: ''
- CI_IMAGE_DOCKER_X64: v105206457-cb3f8790
+ CI_IMAGE_DOCKER_X64: v106628973-e0620387
CI_IMAGE_DOCKER_X64_SUFFIX: ''
- CI_IMAGE_GITLAB_AGENT_DEPLOY: v105206457-cb3f8790
? ^ ------- - --
+ CI_IMAGE_GITLAB_AGENT_DEPLOY: v106628973-e0620387
? ^^^^^^^^^^^
CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: ''
- CI_IMAGE_LINUX: v105206457-cb3f8790
+ CI_IMAGE_LINUX: v106628973-e0620387
CI_IMAGE_LINUX_SUFFIX: ''
- CI_IMAGE_RPM_ARM64: v105206457-cb3f8790
+ CI_IMAGE_RPM_ARM64: v106628973-e0620387
CI_IMAGE_RPM_ARM64_SUFFIX: ''
- CI_IMAGE_RPM_ARMHF: v105206457-cb3f8790
+ CI_IMAGE_RPM_ARMHF: v106628973-e0620387
CI_IMAGE_RPM_ARMHF_SUFFIX: ''
- CI_IMAGE_RPM_X64: v105206457-cb3f8790
+ CI_IMAGE_RPM_X64: v106628973-e0620387
CI_IMAGE_RPM_X64_SUFFIX: ''
- CI_IMAGE_WIN_LTSC2022_X64: v105206457-cb3f8790
? ^ ------- - --
+ CI_IMAGE_WIN_LTSC2022_X64: v106628973-e0620387
? ^^^^^^^^^^^
CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: ''
- CI_IMAGE_WIN_LTSC2025_X64: v105206457-cb3f8790
? ^ ------- - --
+ CI_IMAGE_WIN_LTSC2025_X64: v106628973-e0620387
? ^^^^^^^^^^^
CI_IMAGE_WIN_LTSC2025_X64_SUFFIX: ''
CLANG_BUILD_VERSION: v60409452-ee70de70
CLANG_LLVM_VER: 12.0.1
CLUSTER_AGENT_BINARIES_DIR: bin/datadog-cluster-agent
CLUSTER_AGENT_CLOUDFOUNDRY_BINARIES_DIR: bin/datadog-cluster-agent-cloudfoundry
CODECOV: codecov
CODECOV_TOKEN: ci.datadog-agent.codecov_token
COMPARE_TO_BRANCH: main
CRC_PULL_SECRET: ci.datadog-agent.crc-pull-secret
CWS_INSTRUMENTATION_BINARIES_DIR: bin/cws-instrumentation
DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
DDA_CLIENT_TOKEN: dda-feature-flags-client-token
DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS: ci.datadog-agent.dda-feature-flags-client-token
DDA_FEATURE_FLAGS_CI_VAULT_KEY: token
DDA_FEATURE_FLAGS_CI_VAULT_KEY_MACOS: token
DDA_FEATURE_FLAGS_CI_VAULT_PATH: k8s/gitlab-runner-datadog-agent/datadog-agent/$DDA_CLIENT_TOKEN
DDA_FEATURE_FLAGS_CI_VAULT_PATH_MACOS: aws/arn:aws:iam::486234852809:role/ci-datadog-agent/$DDA_CLIENT_TOKEN
DD_AGENT_TESTING_DIR: $CI_PROJECT_DIR/test/new-e2e/tests
DD_PKG_GITLAB_URL: https://artifact-gateway.us1.ddbuild.io/internal/artifact-gateway/api/v4
DD_PKG_VERSION: latest
DEB_GPG_KEY_ID: c0962c7d
DEB_GPG_KEY_NAME: Datadog, Inc. APT key
DEB_RPM_TESTING_BUCKET_BRANCH: testing
DEB_S3_BUCKET: apt.datad0g.com
DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
DOCKER_REGISTRY_LOGIN: ci.datadog-agent.docker_hub_login
DOCKER_REGISTRY_PWD: ci.datadog-agent.docker_hub_pwd
DOCKER_REGISTRY_RO: dockerhub-readonly
DOCKER_REGISTRY_URL: docker.io
DOGSTATSD_BINARIES_DIR: bin/dogstatsd
DYNAMIC_TESTS_BREAKGLASS: dynamic-tests-breakglass
E2E_AZURE: e2e-azure
E2E_COVERAGE_PIPELINE: false
E2E_GCP: e2e-gcp
EXECUTOR_JOB_SECTION_ATTEMPTS: 2
FF_CLEAN_UP_FAILED_CACHE_EXTRACT: true
FF_KUBERNETES_HONOR_ENTRYPOINT: true
FF_SCRIPT_SECTIONS: 1
FF_TIMESTAMPS: true
FF_USE_FASTZIP: true
FF_USE_WINDOWS_JOB_OBJECT: true
GENERAL_ARTIFACTS_CACHE_BUCKET_URL: https://dd-agent-omnibus.s3.amazonaws.com
GET_SOURCES_ATTEMPTS: 2
GIT_STRATEGY: s3
GO_TEST_SKIP_FLAKE: 'true'
GPG_TEST_KEY_ID: crypto/k8s/keys/k8s_gitlab-runner-datadog-agent_datadog-agent_testing_signing-key
INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
INSTALL_SCRIPT_API_KEY_ORG2: install-script-api-key-org-2
INTEGRATION_WHEELS_CACHE_BUCKET: dd-agent-omnibus
KERNEL_MATRIX_TESTING_ARM_AMI_ID: ami-0b5f838a19d37fc61
KERNEL_MATRIX_TESTING_X86_AMI_ID: ami-05b3973acf5422348
KITCHEN_INFRASTRUCTURE_FLAKES_RETRY: 2
MACOS_APPLE_APPLICATION_SIGNING: apple-application-signing
MACOS_APPLE_DEVELOPER_ACCOUNT: apple-developer-account
MACOS_APPLE_INSTALLER_SIGNING: apple-installer-signing
MACOS_GITHUB_APP_1: macos-github-app-one
MACOS_GITHUB_APP_2: macos-github-app-two
MACOS_KEYCHAIN_PWD: ci-keychain
MACOS_S3_BUCKET: dd-agent-macostesting
OMNIBUS_BASE_DIR: /omnibus
OMNIBUS_GIT_CACHE_DIR: /tmp/omnibus-git-cache
OMNIBUS_PACKAGE_DIR: $CI_PROJECT_DIR/omnibus/pkg/
OMNIBUS_PACKAGE_DIR_SUSE: $CI_PROJECT_DIR/omnibus/suse/pkg
PIPELINE_KEY_ALIAS: alias/ci_datadog-agent_pipeline-key
PROCESS_S3_BUCKET: datad0g-process-agent
PYTHONUNBUFFERED: 1
RESTORE_CACHE_ATTEMPTS: 2
RPM_GPG_KEY_ID: b01082d3
RPM_GPG_KEY_NAME: Datadog, Inc. RPM key
RPM_S3_BUCKET: yum.datad0g.com
RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
RUN_E2E_TESTS: auto
RUN_KMT_TESTS: auto
RUN_UNIT_TESTS: auto
S3_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_CP_CMD: aws s3 cp $S3_CP_OPTIONS
S3_CP_OPTIONS: --no-progress --region us-east-1 --sse AES256
S3_DD_AGENT_OMNIBUS_BTFS_URI: s3://dd-agent-omnibus/btfs
S3_DD_AGENT_OMNIBUS_JAVA_URI: s3://dd-agent-omnibus/openjdk
S3_DD_AGENT_OMNIBUS_LLVM_URI: s3://dd-agent-omnibus/llvm
S3_DSD6_URI: s3://dsd6-staging
S3_OMNIBUS_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-cache-build-stable
S3_OMNIBUS_GIT_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-git-cache-build-stable
S3_PERMANENT_ARTIFACTS_URI: s3://dd-ci-persistent-artefacts-build-stable/$CI_PROJECT_NAME
S3_PROJECT_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME
S3_RELEASE_ARTIFACTS_URI: s3://dd-release-artifacts/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_RELEASE_INSTALLER_ARTIFACTS_URI: s3://dd-release-artifacts/datadog-installer/$CI_PIPELINE_ID
S3_SBOM_STORAGE_URI: s3://sbom-root-us1-ddbuild-io/$CI_PROJECT_NAME/$CI_PIPELINE_ID
SECRET_GENERIC_CONNECTOR_BINARIES_DIR: bin/secret-generic-connector
SKIP_WINDOWS: 'false'
SLACK_AGENT: slack-agent-ci
SMP_ACCOUNT: smp
STATIC_BINARIES_DIR: bin/static
SYSTEM_PROBE_BINARIES_DIR: bin/system-probe
TEST_KEYS_URL: apttesting.datad0g.com/test-keys
VCPKG_BLOB_SAS_URL: ci.datadog-agent-buildimages.vcpkg_blob_sas_url
VIRUS_TOTAL: virus-total
WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
WINDOWS_POWERSHELL_DIR: $CI_PROJECT_DIR/signed_scripts
WINDOWS_TESTING_S3_BUCKET: pipelines/A7/$CI_PIPELINE_ID
WINGET_PAT: ci.datadog-agent.winget_pat
WIN_S3_BUCKET: dd-agent-mstestingChanges Summary
ℹ️ Diff available in the job log. |
Contributor
Files inventory check summaryFile checks results against ancestor 80a2fe13: Results for datadog-agent_7.79.0~devel.git.559.1699ffb.pipeline.106881537-1_amd64.deb:No change detected |
aiuto
approved these changes
Apr 8, 2026
| e.rangeContext = &rangeContext{outer: e.rangeContext} | ||
| } | ||
| c0 := e.escapeList(c, n.List) | ||
| c0 := e.escapeList(c.clone(), n.List) |
Contributor
There was a problem hiding this comment.
Is this needed, or can you divide the PR into
- update go
- take advantage of the new features.
We should never change infrastructure and make use of the new features in the same change.
https://datadoghq.atlassian.net/wiki/spaces/~712020e2548bb5a7654883bebf1c9b326e8973/pages/6344180523/Changing+system+behavior+everything+needs+a+feature+flag
Contributor
There was a problem hiding this comment.
Also, for the go version change, you should run all the tests before merge, with
trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on
Member
Author
There was a problem hiding this comment.
This code is vendored from the Go standard library, with a few patches applied on top, so it's always the same as the code from the Go version we're using (ie. I didn't make this change, Go 1.25.9 did), https://github.com/DataDog/datadog-agent/blob/main/pkg/template/README.md
you should run all the tests before merge
This happens automatically when the .go-version file is edited 👍
Contributor
There was a problem hiding this comment.
@aiuto this PR is IMO to be approved because it indeed brings the bare minimum for the version bump (in the current state of affairs).
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 5ecc3b7 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.80 | [-2.18, +3.77] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.15 | [-0.52, +2.82] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | +0.80 | [-2.18, +3.77] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.36 | [+0.21, +0.50] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.19 | [+0.01, +0.37] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.15 | [+0.08, +0.21] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.14 | [-0.03, +0.31] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.09 | [-0.48, +0.65] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.00 | [-0.42, +0.42] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.00 | [-0.06, +0.05] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.16, +0.06] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.05 | [-0.27, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.08 | [-0.49, +0.33] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.12 | [-0.32, +0.09] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.12 | [-0.21, -0.03] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.15 | [-0.18, -0.12] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | -0.22 | [-0.28, -0.16] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.28 | [-0.44, -0.12] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.49 | [-0.53, -0.44] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.74 | [-0.83, -0.64] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.10 | [-1.33, -0.87] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 691 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 277.93MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 708 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.80MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 489.51MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 205.08MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 358.42 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 415.69MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
8 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
jose-manuel-almaza
approved these changes
Apr 9, 2026
rdesgroppes
approved these changes
Apr 9, 2026
KevinFairise2
approved these changes
Apr 9, 2026
chouetz
approved these changes
Apr 9, 2026
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Apr 9, 2026
878ce65
into
main
292 of 293 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump go to 1.25.9
Motivation
CVE fixes
Describe how you validated your changes
CI
Additional Notes