[serverless-init] Skip trace/metric init when DD_API_KEY is not set by Lewis-E · Pull Request #48458 · DataDog/datadog-agent

Lewis-E · 2026-03-26T22:58:06Z

Summary

When serverless-init runs without DD_API_KEY, the trace agent config validation and forwarder produced repeated ERROR logs (403 responses, missing API key). This regressed in 1.9.0 when the internal log level changed from "off" to "error".
Gate trace and metric agent initialization on API key presence. When no key is set, log a single warning and use no-op agents. The process wrapper and logs agent continue normally.
Add defense-in-depth: downgrade ErrMissingAPIKey from Error to Warn in trace agent config loading.

Test plan

Build image with the log change
Run docker run with serverless-init dev image without DD_API_KEY — expect single WARN, no ERROR spam
Run docker run with serverless-init with DD_API_KEY — expect normal trace/metric behavior

🤖 Generated with Claude Code

When serverless-init runs without DD_API_KEY configured, the trace agent config validation and forwarder produce repeated ERROR logs (403 responses, missing API key errors). This regressed in 1.9.0 when the internal log level was changed from "off" to "error". Gate trace and metric agent initialization on API key presence. When no key is set, log a single warning and use no-op agents. The process wrapper and logs agent continue to function normally. Fixes #48036 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

github-actions · 2026-03-26T22:58:18Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

agent-platform-auto-pr · 2026-03-26T23:22:22Z

Files inventory check summary

File checks results against ancestor 867176f1:

Results for datadog-agent_7.79.0~devel.git.219.7daeadc.pipeline.105105202-1_amd64.deb:

No change detected

cit-pr-commenter-54b7da · 2026-03-26T23:42:55Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: aff48440-d664-4513-8da7-ce4e7b9d4f0d

Baseline: 6e6fb95
Comparison: 23f7c50
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.32	[-1.65, +4.29]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.32	[-1.65, +4.29]	1	Logs
➖	ddot_logs	memory utilization	+1.07	[+1.00, +1.14]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.80	[+0.70, +0.90]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.28	[+0.11, +0.45]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.23	[+0.17, +0.29]	1	Logs
➖	docker_containers_memory	memory utilization	+0.19	[+0.11, +0.26]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.17	[-0.06, +0.41]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.17	[+0.01, +0.34]	1	Logs
➖	ddot_metrics	memory utilization	+0.12	[-0.05, +0.28]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.09	[+0.06, +0.13]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.51, +0.58]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.03	[-0.39, +0.45]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.07, +0.09]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.10, +0.12]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.19]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.41, +0.36]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.03	[-0.24, +0.17]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.05	[-1.67, +1.57]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.06	[-0.12, +0.00]	1	Logs
➖	quality_gate_idle	memory utilization	-0.20	[-0.25, -0.15]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.36	[-0.58, -0.14]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.54	[-0.73, -0.34]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.64	[-0.78, -0.50]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	601 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	273.10MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	703 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	173.66MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.12MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	203.08MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	366.20 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	405.84MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2026-03-26T23:54:35Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 867176f
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.573 MiB
✅	agent_deb_amd64_fips	709.595 MiB
✅	agent_heroku_amd64	313.301 MiB
✅	agent_rpm_amd64	752.557 MiB
✅	agent_rpm_amd64_fips	709.579 MiB
✅	agent_rpm_arm64	730.998 MiB
✅	agent_rpm_arm64_fips	691.021 MiB
✅	agent_suse_amd64	752.557 MiB
✅	agent_suse_amd64_fips	709.579 MiB
✅	agent_suse_arm64	730.998 MiB
✅	agent_suse_arm64_fips	691.021 MiB
✅	docker_agent_amd64	812.876 MiB
✅	docker_agent_arm64	816.087 MiB
✅	docker_agent_jmx_amd64	1003.791 MiB
✅	docker_agent_jmx_arm64	995.781 MiB
✅	docker_cluster_agent_amd64	203.942 MiB
✅	docker_cluster_agent_arm64	218.420 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.238 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.881 MiB
✅	dogstatsd_deb_arm64	28.034 MiB
✅	dogstatsd_rpm_amd64	29.881 MiB
✅	dogstatsd_suse_amd64	29.881 MiB
✅	iot_agent_deb_amd64	43.278 MiB
✅	iot_agent_deb_arm64	40.324 MiB
✅	iot_agent_deb_armhf	41.076 MiB
✅	iot_agent_rpm_amd64	43.278 MiB
✅	iot_agent_suse_amd64	43.278 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-13.9 KiB (0.01% reduction)	174.766 → 174.752 → 178.360
✅	agent_deb_amd64_fips	neutral	165.365 MiB → 172.790
✅	agent_heroku_amd64	-3.05 KiB (0.00% reduction)	75.008 → 75.005 → 79.970
✅	agent_rpm_amd64	+2.12 KiB (0.00% increase)	177.552 → 177.554 → 181.830
✅	agent_rpm_amd64_fips	+33.55 KiB (0.02% increase)	167.614 → 167.647 → 173.370
✅	agent_rpm_arm64	+2.38 KiB (0.00% increase)	159.477 → 159.480 → 163.060
✅	agent_rpm_arm64_fips	+43.43 KiB (0.03% increase)	151.333 → 151.375 → 156.170
✅	agent_suse_amd64	+2.12 KiB (0.00% increase)	177.552 → 177.554 → 181.830
✅	agent_suse_amd64_fips	+33.55 KiB (0.02% increase)	167.614 → 167.647 → 173.370
✅	agent_suse_arm64	+2.38 KiB (0.00% increase)	159.477 → 159.480 → 163.060
✅	agent_suse_arm64_fips	+43.43 KiB (0.03% increase)	151.333 → 151.375 → 156.170
✅	docker_agent_amd64	neutral	268.105 MiB → 272.480
✅	docker_agent_arm64	neutral	255.292 MiB → 261.060
✅	docker_agent_jmx_amd64	-6.99 KiB (0.00% reduction)	336.760 → 336.753 → 341.100
✅	docker_agent_jmx_arm64	-5.03 KiB (0.00% reduction)	319.928 → 319.923 → 325.620
✅	docker_cluster_agent_amd64	neutral	71.373 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	67.012 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.174 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.494 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.895 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.778 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.904 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.904 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.399 MiB → 12.040
✅	iot_agent_deb_arm64	+3.62 KiB (0.04% increase)	9.701 → 9.705 → 10.450
✅	iot_agent_deb_armhf	-2.25 KiB (0.02% reduction)	9.943 → 9.941 → 10.620
✅	iot_agent_rpm_amd64	neutral	11.416 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.416 MiB → 12.060

Replace nested monitoringEnabled conditionals with a guard clause that returns early when DD_API_KEY is unset. Also use configUtils.SanitizeAPIKey instead of inline strings.TrimSpace, and remove the now-unreachable ErrMissingAPIKey branch in trace agent config loading. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

…e field Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Lewis-E · 2026-03-27T20:45:41Z

I have read the CLA Document and I hereby sign the CLA

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff05077d08

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…guard The early return that disables trace/metric init when no API key is set now also checks the deprecated apm_config.api_key, which the trace agent still honors. This prevents a silent regression for any deployments that only set that key. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

kathiehuang

LGTM!

Lewis-E · 2026-03-30T20:54:26Z

Scenario	Current stable (`latest`)	Dev build (`1.9.9-log-change-dev`)
No `DD_API_KEY`	`ERROR: Unable to load trace agent config: you must specify an API Key` + `ERROR: API Key invalid (403 response)` spam every few seconds	Single `WARN: DD_API_KEY is not set; trace and metric collection are disabled` ✅
With `DD_API_KEY`	Normal agent startup	Normal agent startup — trace agent, dogstatsd on `127.0.0.1:8125`, APM on `:8126`, logs agent tailing files ✅

dd-octo-sts Bot added the internal Identify a non-fork PR label Mar 26, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Mar 26, 2026

Lewis-E added the team/serverless-azure-gcp label Mar 26, 2026

Lewis-E force-pushed the lewis/SVLS-8743-serverless-init-no-apikey-errors branch from 77db2e5 to c923fee Compare March 27, 2026 20:31

Lewis-E force-pushed the lewis/SVLS-8743-serverless-init-no-apikey-errors branch from c923fee to ff53180 Compare March 27, 2026 20:36

[serverless-init] Remove unused errors import and redundant zero-valu…

ff05077

…e field Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Lewis-E added the changelog/no-changelog No changelog entry needed label Mar 27, 2026

Lewis-E marked this pull request as ready for review March 27, 2026 20:49

Lewis-E requested a review from a team as a code owner March 27, 2026 20:49

chatgpt-codex-connector Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread cmd/serverless-init/main.go Outdated

Lewis-E requested a review from kathiehuang March 30, 2026 18:02

kathiehuang approved these changes Mar 30, 2026

View reviewed changes

Lewis-E added the qa/done QA done before merge and regressions are covered by tests label Mar 30, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 23f7c50 into main Mar 30, 2026
245 of 246 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the lewis/SVLS-8743-serverless-init-no-apikey-errors branch March 30, 2026 23:17

github-actions Bot added this to the 7.79.0 milestone Mar 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[serverless-init] Skip trace/metric init when DD_API_KEY is not set#48458

[serverless-init] Skip trace/metric init when DD_API_KEY is not set#48458
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
lewis/SVLS-8743-serverless-init-no-apikey-errors

Lewis-E commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

cit-pr-commenter-54b7da Bot commented Mar 26, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

Lewis-E commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

kathiehuang left a comment

Uh oh!

Lewis-E commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Lewis-E commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

github-actions Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.219.7daeadc.pipeline.105105202-1_amd64.deb:

Uh oh!

cit-pr-commenter-54b7da Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Uh oh!

Lewis-E commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kathiehuang left a comment

Choose a reason for hiding this comment

Uh oh!

Lewis-E commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Lewis-E commented Mar 26, 2026 •

edited

Loading

github-actions Bot commented Mar 26, 2026 •

edited

Loading

agent-platform-auto-pr Bot commented Mar 26, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Mar 26, 2026 •

edited

Loading

agent-platform-auto-pr Bot commented Mar 26, 2026 •

edited

Loading