Switch bazel remote config from executor to cache with fallback#47945
Conversation
Files inventory check summaryFile checks results against ancestor 5c143af1: Results for datadog-agent_7.79.0~devel.git.316.4492ca3.pipeline.105301854-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e6be752 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.28 | [-1.71, +4.26] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.23 | [+0.59, +3.86] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | +1.28 | [-1.71, +4.26] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.41 | [+0.35, +0.48] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.24 | [+0.16, +0.32] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.12 | [-0.11, +0.36] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.09 | [+0.04, +0.15] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.06 | [-0.04, +0.17] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.00 | [-0.14, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.10] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.01 | [-0.06, +0.04] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.44, +0.41] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.02 | [-0.19, +0.15] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.57, +0.49] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.42, +0.33] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.08 | [-0.17, +0.00] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.09 | [-0.13, -0.06] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.12 | [-0.17, -0.06] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.20 | [-0.42, +0.03] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.26 | [-0.44, -0.08] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.27 | [-0.41, -0.13] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.95 | [-1.11, -0.79] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 688 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 272.86MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 704 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.26MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 492.63MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 207.16MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 428.13 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 415.58MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
235686b to
5d6eea3
Compare
### What does this PR do? Add `--incompatible_remote_local_fallback_for_remote_cache` to the `cache` config. ### Motivation `--remote_local_fallback` only covers remote executor unavailability. Remote cache errors, often leading Bazel to exit with status code [34](https://dd.slack.com/archives/C08SK4B0FK8/p1773737357223759), bypass the fallback and fail the build. `--incompatible_remote_local_fallback_for_remote_cache`, introduced with Bazel 8.5.1 (bazelbuild/bazel#27996) extends the fallback to remote cache errors as well. ### Describe how you validated your changes Local builds unaffected. The flag is a no-op outside `--config=cache`. ### Additional Notes Also remove a now stale comment that said "fallback doesn't work for --remote_cache" since it does, with this flag turned on.
5d6eea3 to
4492ca3
Compare
remote_local_fallback to remote cache errorsbazel remote config from executor to cache with fallback
Not exactly, fallback is basically broken for remote executor if an endpoint is unavailable before the build. So if buildbarn was to fail during the build Bazel would just continue locally. |
I updated the PR description quoting your words and mentioning the issue you filed upstream: |
What does this PR do?
Adjust the
cacheBazel config following a complete review of the remote flags:--remote_executorto--remote_cachesince RBE infrastructure is not ready,--incompatible_remote_local_fallback_for_remote_cacheto enable local fallback on remote cache failures,--remote_local_fallback_strategy=sandboxedfrom thelinuxandmacosconfigs, which became dead letter.Motivation
Earlier discussion.
1.
--remote_executorto--remote_cacheThe build farm is used as a remote cache, not a remote executor.
Quoting @JSGette, who filed bazelbuild/bazel#29129:
2.
--incompatible_remote_local_fallback_for_remote_cacheThe flag was introduced with Bazel 8.5.1 (bazelbuild/bazel#27996) since
--remote_local_fallbackalone does not cover cache-layer failures.Both flags are required because they are AND-gated at the single decision point:
Without both flags, a
RemoteExecutionCapabilitiesException(capabilities fetch failure) causes a hard build failure instead of a local fallback.3.
--remote_local_fallback_strategyremovalThe flag is unreachable in a
--remote_cache-only setup: its single call site isRemoteSpawnRunner.execLocally(), gated byRemoteExecutionService.mayBeExecutedRemotely(), which requiresremoteExecutor != null.It is also
@Deprecated(bazelbuild/bazel#7480).Describe how you validated your changes
The flag is a no-op outside
--config=cache(local builds unaffected by default), but CI benefits from it by default.Additional Notes
The stale
registerRemoteSpawnStrategy()javadoc ("otherwise does nothing" when no executor is set) is a known source-reading hazard: the null-check was deliberately removed in bazelbuild/bazel#13490 (2021), moving the guard tocanExec().The javadoc was never updated.