Skip to content

pkg/clusteragent/admission: remove unused wmeta field from admission webhook structs#47864

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
alexander.yastrebov/pkg/clusteragent-remove-unused-wmeta
Mar 16, 2026
Merged

pkg/clusteragent/admission: remove unused wmeta field from admission webhook structs#47864
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
alexander.yastrebov/pkg/clusteragent-remove-unused-wmeta

Conversation

@AlexanderYastrebov

@AlexanderYastrebov AlexanderYastrebov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The wmeta (workloadmeta.Component) field was stored in the Webhook struct for config, tagsfromlabels, and autoinstrumentation webhooks but never read. All mutation logic is delegated to the mutator field. Remove the field and the corresponding NewWebhook parameter, updating all call sites and tests.

Motivation

Reduce component dependencies.

Describe how you validated your changes

Additional Notes

@AlexanderYastrebov @claude
pkg/clusteragent/admission: remove unused wmeta field from admission …
cb72ee0 
…webhook structs

The wmeta (workloadmeta.Component) field was stored in the Webhook struct
for config, tagsfromlabels, and autoinstrumentation webhooks but never read.
All mutation logic is delegated to the mutator field. Remove the field and
the corresponding NewWebhook parameter, updating all call sites and tests.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@AlexanderYastrebov
AlexanderYastrebov requested review from a team as code owners March 16, 2026 09:23
@github-actions github-actions Bot added the medium review PR review might take time label Mar 16, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/container-platform The Container Platform Team team/injection-platform labels Mar 16, 2026
@AlexanderYastrebov AlexanderYastrebov added the qa/done QA done before merge and regressions are covered by tests label Mar 16, 2026
@AlexanderYastrebov AlexanderYastrebov added the changelog/no-changelog No changelog entry needed label Mar 16, 2026
@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 5a007aeb:

Results for datadog-agent_7.78.0~devel.git.605.cb72ee0.pipeline.102608019-1_amd64.deb:

No change detected

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2c21bde
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 746.937 MiB
✅ agent_deb_amd64_fips 705.302 MiB
✅ agent_heroku_amd64 311.742 MiB
✅ agent_rpm_amd64 746.921 MiB
✅ agent_rpm_amd64_fips 705.286 MiB
✅ agent_rpm_arm64 724.843 MiB
✅ agent_rpm_arm64_fips 686.155 MiB
✅ agent_suse_amd64 746.921 MiB
✅ agent_suse_amd64_fips 705.286 MiB
✅ agent_suse_arm64 724.843 MiB
✅ agent_suse_arm64_fips 686.155 MiB
✅ docker_agent_amd64 807.273 MiB
✅ docker_agent_arm64 809.997 MiB
✅ docker_agent_jmx_amd64 998.189 MiB
✅ docker_agent_jmx_arm64 989.691 MiB
✅ docker_cluster_agent_amd64 203.662 MiB
✅ docker_cluster_agent_arm64 218.164 MiB
✅ docker_cws_instrumentation_amd64 7.142 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.619 MiB
✅ docker_dogstatsd_arm64 36.939 MiB
✅ dogstatsd_deb_amd64 29.847 MiB
✅ dogstatsd_deb_arm64 28.000 MiB
✅ dogstatsd_rpm_amd64 29.847 MiB
✅ dogstatsd_suse_amd64 29.847 MiB
✅ iot_agent_deb_amd64 43.048 MiB
✅ iot_agent_deb_arm64 40.111 MiB
✅ iot_agent_deb_armhf 40.843 MiB
✅ iot_agent_rpm_amd64 43.049 MiB
✅ iot_agent_suse_amd64 43.049 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 -17.2 KiB (0.01% reduction) 174.484 → 174.468 → 177.700
✅ agent_deb_amd64_fips +7.84 KiB (0.00% increase) 165.368 → 165.376 → 172.230
✅ agent_heroku_amd64 -4.04 KiB (0.01% reduction) 75.169 → 75.165 → 79.970
✅ agent_rpm_amd64 -58.69 KiB (0.03% reduction) 176.427 → 176.370 → 180.780
✅ agent_rpm_amd64_fips +26.76 KiB (0.02% increase) 168.086 → 168.112 → 173.370
✅ agent_rpm_arm64 -9.61 KiB (0.01% reduction) 159.348 → 159.339 → 161.610
✅ agent_rpm_arm64_fips neutral 151.376 MiB → 155.910
✅ agent_suse_amd64 -58.69 KiB (0.03% reduction) 176.427 → 176.370 → 180.780
✅ agent_suse_amd64_fips +26.76 KiB (0.02% increase) 168.086 → 168.112 → 173.370
✅ agent_suse_arm64 -9.61 KiB (0.01% reduction) 159.348 → 159.339 → 161.610
✅ agent_suse_arm64_fips neutral 151.376 MiB → 155.910
✅ docker_agent_amd64 neutral 267.108 MiB → 271.240
✅ docker_agent_arm64 neutral 254.421 MiB → 259.800
✅ docker_agent_jmx_amd64 neutral 335.760 MiB → 339.870
✅ docker_agent_jmx_arm64 neutral 319.057 MiB → 324.390
✅ docker_cluster_agent_amd64 neutral 71.275 MiB → 72.920
✅ docker_cluster_agent_arm64 neutral 66.919 MiB → 68.220
✅ docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 14.944 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.274 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.885 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.769 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.895 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.895 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.349 MiB → 12.040
✅ iot_agent_deb_arm64 neutral 9.660 MiB → 10.450
✅ iot_agent_deb_armhf neutral 9.890 MiB → 10.620
✅ iot_agent_rpm_amd64 -3.6 KiB (0.03% reduction) 11.368 → 11.365 → 12.060
✅ iot_agent_suse_amd64 -3.6 KiB (0.03% reduction) 11.368 → 11.365 → 12.060

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3002b978-fc36-4aaa-a1a5-fee835bd9946

Baseline: c6ee509
Comparison: b99db73
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.86 [-1.24, +4.95] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.86 [-1.24, +4.95] 1 Logs
➖ quality_gate_logs % cpu utilization +1.21 [-0.38, +2.80] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization +0.42 [+0.37, +0.47] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.39 [+0.33, +0.45] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.22 [+0.12, +0.33] 1 Logs
➖ ddot_metrics memory utilization +0.19 [+0.01, +0.36] 1 Logs
➖ docker_containers_memory memory utilization +0.09 [+0.02, +0.16] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.09 [-0.14, +0.31] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.07 [-0.31, +0.44] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.41, +0.46] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.06, +0.06] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.16, +0.15] 1 Logs
➖ file_tree memory utilization -0.01 [-0.07, +0.05] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.19, +0.17] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization -0.03 [-0.17, +0.10] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.07 [-0.57, +0.43] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.09 [-0.13, -0.06] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.22 [-0.28, -0.15] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.28 [-0.52, -0.04] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_delta memory utilization -0.29 [-0.46, -0.12] 1 Logs
➖ otlp_ingest_logs memory utilization -0.32 [-0.42, -0.23] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.87 [-1.02, -0.71] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ docker_containers_cpu simple_check_run 10/10 721 ≥ 26
✅ docker_containers_memory memory_usage 10/10 274.26MiB ≤ 370MiB
✅ docker_containers_memory simple_check_run 10/10 725 ≥ 26
✅ file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
✅ file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
✅ file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
✅ file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
✅ file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
✅ quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 174.21MiB ≤ 175MiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 491.04MiB ≤ 550MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 205.33MiB ≤ 220MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 375.42 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 407.19MiB ≤ 475MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit b99db73 into main Mar 16, 2026
293 of 299 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexander.yastrebov/pkg/clusteragent-remove-unused-wmeta branch March 16, 2026 11:18
@github-actions github-actions Bot added this to the 7.78.0 milestone Mar 16, 2026
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Mar 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamluc iamluc iamluc approved these changes
@tbavelier tbavelier tbavelier approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team team/injection-platform

Projects

None yet

Milestone

7.78.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexanderYastrebov @iamluc @tbavelier