pkg/clusteragent/autoscaling/cluster: add spot instance scheduler MVP#47429
Conversation
Go Package Import DifferencesBaseline: b7939a5
|
Files inventory check summaryFile checks results against ancestor b7939a5a: Results for datadog-agent_7.79.0~devel.git.843.2271b55.pipeline.108120592-1_amd64.deb:No change detected |
30be0cd to
3ec3995
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 00d2c25 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | % cpu utilization | -7.50 | [-10.38, -4.62] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.08 | [+0.43, +3.73] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.75 | [+0.68, +0.81] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.71 | [+0.47, +0.94] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.17 | [-0.01, +0.34] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.09 | [+0.01, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.51, +0.62] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.08, +0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.02 | [-0.04, +0.08] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.02 | [-0.21, +0.24] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.00 | [-0.05, +0.05] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.21, +0.19] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.46, +0.42] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.05 | [-0.08, -0.01] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.06 | [-0.47, +0.35] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.19 | [-0.38, -0.00] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.26 | [-0.42, -0.10] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.34 | [-0.49, -0.19] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.49 | [-0.55, -0.44] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.37 | [-1.55, -1.19] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -1.60 | [-1.71, -1.50] | 1 | Logs |
| ✅ | docker_containers_cpu | % cpu utilization | -7.50 | [-10.38, -4.62] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 715 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 278.15MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 684 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.24GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ❌ | quality_gate_idle | intake_connections | 0/10 | 4 > 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.78MiB ≤ 181MiB | bounds checks dashboard |
| ❌ | quality_gate_idle_all_features | intake_connections | 5/10 | 4 > 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 499.48MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 208.75MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 355.79 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 411.69MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 5/10 replicas passed. Failed 5 which is > 0. Gate FAILED.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
|
@codex review |
|
I've created #47864 to compensate for the size change. |
79a1ef9 to
0feddde
Compare
15be835 to
6962a28
Compare
18a5c0b to
cd08df3
Compare
…ling/spot-scheduling-2 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
…tion (#48684) ### What does this PR do? Add support for customizing kind cluster topology and pre-loading Docker images into the cluster before the agent is deployed. ### Motivation Local e2e tests for Spot Scheduling #47429 ### Describe how you validated your changes I am testing spot scheduling via #48821 and extracted these changes into a separate PR. ### Additional Notes Co-authored-by: alexander.yastrebov <[email protected]>
What does this PR do? ===================== Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Checklist --------- - [ ] PR has at least one valid label: `bug`, `enhancement`, `refactoring`, `documentation`, `tooling`, and/or `dependencies` - [ ] PR has a milestone or the `qa/skip-qa` label - [ ] All commits are signed (see: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#<PR>. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…2957) [feature][autoscaling] add Spot scheduling feature and update RBAC What does this PR do? --------------------- Adds `features.autoscaling.cluster.spot.enabled` to the DatadogAgent API, which grants the cluster-agent permission to patch Deployments/StatefulSets with the `spot-disabled-until` annotation and evict pending spot pods during on-demand fallback. Spot is enforced as a sub-feature of cluster autoscaling (requires `cluster.enabled=true`). Motivation ---------- Support spot instance scheduling in the operator so that users can enable the spot scheduler via the DatadogAgent CR without manually managing RBAC. Additional Notes ---------------- Spot scheduler implementation: DataDog/datadog-agent#47429 Updates https://datadoghq.atlassian.net/browse/CASCL-1312 Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Describe your test plan ----------------------- Unit tests cover the new RBAC rules for spot scheduling. E2E tests in DataDog/datadog-agent validate spot scheduling behaviour end-to-end. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Co-authored-by: alexander.yastrebov <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
[datadog/cluster autoscaling] add spot scheduling RBAC What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Co-authored-by: alexander.yastrebov <[email protected]>
What does this PR do?
Implement a spot instance scheduler for the Cluster Agent that schedules eligible workloads on Karpenter-managed spot nodes while maintaining configurable spot/on-demand ratios and automatic fallback to on-demand when spot pods are stuck pending.
Add
autoscaling.cluster.spot.enabledfeature toggle (default: false) and configuration defaults.Tests use a mocked cluster that simulates a Kubernetes cluster and the Spot Scheduler is exercised through its public API.
Motivation
Enable spot scheduling for selected workloads.
Describe how you validated your changes
Via unit tests, running Cluster Agent in a local kind cluster and in EKS cluster with Karpenter.
Additional Notes
Please check README.md and scheduler_test.go first.