Skip to content

Remove copy_file workaround from nghttp2 build#46182

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/remove-nghttp2-copy-file-workaround
Feb 11, 2026
Merged

Remove copy_file workaround from nghttp2 build#46182
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/remove-nghttp2-copy-file-workaround

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Feb 10, 2026 •
edited
Loading

What does this PR do?

Remove copy_file workaround for cross-repo file references from nghttp2 build by updating rules_pkg to the latest main that includes our fix:

Motivation

The workaround was needed because rules_pkg was incorrectly calculating paths for cross-repo references.

Describe how you validated your changes

bazel run @nghttp2//:install -- --destdir=/tmp/xxx

Output files are identical before and after changes.

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Feb 10, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Feb 10, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 10, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Feb 10, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c5effa61-2685-4f83-9ed7-4f9705567b81

Baseline: 70c3562
Comparison: 5ca7d7c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.67 [-1.43, +4.77] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.67 [-1.43, +4.77] 1 Logs
➖ quality_gate_logs % cpu utilization +0.69 [-0.82, +2.21] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.68 [+0.44, +0.91] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.38 [+0.22, +0.54] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.27 [+0.11, +0.43] 1 Logs
➖ file_tree memory utilization +0.10 [+0.04, +0.15] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.08 [-0.01, +0.17] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.37, +0.47] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.05 [+0.01, +0.08] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput +0.02 [-0.46, +0.49] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
➖ docker_containers_memory memory utilization -0.01 [-0.09, +0.07] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.06, +0.04] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.01 [-0.39, +0.36] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.15, +0.12] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.16, +0.11] 1 Logs
➖ quality_gate_idle memory utilization -0.06 [-0.10, -0.01] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_delta memory utilization -0.08 [-0.29, +0.12] 1 Logs
➖ otlp_ingest_logs memory utilization -0.10 [-0.21, -0.00] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.24 [-0.30, -0.19] 1 Logs
➖ ddot_logs memory utilization -0.31 [-0.38, -0.25] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.40 [-0.62, -0.18] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization -0.52 [-0.73, -0.32] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/remove-nghttp2-copy-file-workaround branch from 1f21694 to 9374646 Compare February 10, 2026 12:55
@rdesgroppes rdesgroppes changed the title tmp Remove copy_file workaround from nghttp2 build Feb 10, 2026
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/remove-nghttp2-copy-file-workaround branch from 9374646 to 1fd68ef Compare February 10, 2026 12:57
@rdesgroppes rdesgroppes marked this pull request as ready for review February 10, 2026 12:57
@rdesgroppes rdesgroppes requested a review from a team as a code owner February 10, 2026 12:57
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Feb 10, 2026 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 815cc1c
📊 Static Quality Gates Dashboard
🔗 SQG Job

Error

Quality gate Change Size (prev → curr → max)
⚠️ docker_agent_amd64 (on wire) -2.5 KiB (0.00% reduction) 277.981 → 277.978 → 277.400
⚠️ docker_agent_jmx_amd64 (on wire) +2.47 KiB (0.00% increase) 346.629 → 346.632 → 346.020
Gate failure full details
Quality gate Error type Error message
docker_agent_amd64 StaticQualityGateFailed (non-blocking: size unchanged from ancestor) �[91mstatic_quality_gate_docker_agent_amd64 failed!
Wire size 278.0 MB exceeds limit of 277.4 MB by 592.0 KB�[0m
docker_agent_jmx_amd64 StaticQualityGateFailed (non-blocking: size unchanged from ancestor) �[91mstatic_quality_gate_docker_agent_jmx_amd64 failed!
Wire size 346.6 MB exceeds limit of 346.0 MB by 626.2 KB�[0m

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

29 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 754.351 MiB
✅ agent_deb_amd64_fips 714.466 MiB
✅ agent_heroku_amd64 324.200 MiB
✅ agent_msi 663.010 MiB
✅ agent_rpm_amd64 754.335 MiB
✅ agent_rpm_amd64_fips 714.449 MiB
✅ agent_rpm_arm64 732.818 MiB
✅ agent_rpm_arm64_fips 695.386 MiB
✅ agent_suse_amd64 754.335 MiB
✅ agent_suse_amd64_fips 714.449 MiB
✅ agent_suse_arm64 732.818 MiB
✅ agent_suse_arm64_fips 695.386 MiB
✅ docker_agent_arm64 821.321 MiB
✅ docker_agent_jmx_arm64 1001.016 MiB
✅ docker_cluster_agent_amd64 180.979 MiB
✅ docker_cluster_agent_arm64 196.809 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.453 MiB
✅ docker_dogstatsd_arm64 36.749 MiB
✅ dogstatsd_deb_amd64 29.669 MiB
✅ dogstatsd_deb_arm64 27.833 MiB
✅ dogstatsd_rpm_amd64 29.669 MiB
✅ dogstatsd_suse_amd64 29.669 MiB
✅ iot_agent_deb_amd64 42.818 MiB
✅ iot_agent_deb_arm64 39.935 MiB
✅ iot_agent_deb_armhf 40.505 MiB
✅ iot_agent_rpm_amd64 42.818 MiB
✅ iot_agent_suse_amd64 42.818 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
⚠️ docker_agent_amd64 -2.5 KiB (0.00% reduction) 277.981 → 277.978 → 277.400
⚠️ docker_agent_jmx_amd64 +2.47 KiB (0.00% increase) 346.629 → 346.632 → 346.020
✅ agent_deb_amd64 neutral 184.395 MiB → 184.810
✅ agent_deb_amd64_fips +33.15 KiB (0.02% increase) 176.292 → 176.324 → 177.560
✅ agent_heroku_amd64 neutral 87.113 MiB → 88.450
✅ agent_msi -20.0 KiB (0.01% reduction) 143.285 → 143.266 → 143.300
✅ agent_rpm_amd64 +32.2 KiB (0.02% increase) 186.732 → 186.763 → 188.160
✅ agent_rpm_amd64_fips +49.0 KiB (0.03% increase) 178.206 → 178.254 → 178.900
✅ agent_rpm_arm64 -21.83 KiB (0.01% reduction) 169.013 → 168.992 → 169.930
✅ agent_rpm_arm64_fips -61.15 KiB (0.04% reduction) 162.326 → 162.266 → 163.120
✅ agent_suse_amd64 +32.2 KiB (0.02% increase) 186.732 → 186.763 → 188.160
✅ agent_suse_amd64_fips +49.0 KiB (0.03% increase) 178.206 → 178.254 → 178.900
✅ agent_suse_arm64 -21.83 KiB (0.01% reduction) 169.013 → 168.992 → 169.930
✅ agent_suse_arm64_fips -61.15 KiB (0.04% reduction) 162.326 → 162.266 → 163.120
✅ docker_agent_arm64 +2.35 KiB (0.00% increase) 265.367 → 265.369 → 266.040
✅ docker_agent_jmx_arm64 +18.67 KiB (0.01% increase) 330.005 → 330.023 → 330.660
✅ docker_cluster_agent_amd64 neutral 63.923 MiB → 64.510
✅ docker_cluster_agent_arm64 neutral 60.189 MiB → 61.170
✅ docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 14.878 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.217 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.840 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.726 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.851 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.851 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.234 MiB → 12.040
✅ iot_agent_deb_arm64 neutral 9.599 MiB → 10.450
✅ iot_agent_deb_armhf neutral 9.801 MiB → 10.620
✅ iot_agent_rpm_amd64 neutral 11.251 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.251 MiB → 12.060

@rdesgroppes
Remove copy_file workaround from nghttp2
5ca7d7c 
### What does this PR do?
Remove `copy_file` workaround for cross-repo file references from
`nghttp2` build by updating `rules_pkg` to the latest main that
includes our fix:
- bazelbuild/rules_pkg#1016.

### Motivation
The workaround was needed because `rules_pkg` was incorrectly
calculating paths for cross-repo references.

### Describe how you validated your changes
```
bazel run @nghttp2//:install -- --destdir=/tmp/xxx
```
Output files are identical before and after changes.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/remove-nghttp2-copy-file-workaround branch from 1fd68ef to 5ca7d7c Compare February 10, 2026 15:58
@rdesgroppes
Copy link
Copy Markdown
Contributor Author

rdesgroppes commented Feb 11, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Feb 11, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-02-11 08:59:42 UTC ℹ️ Start processing command /merge

2026-02-11 08:59:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-02-11 10:03:58 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 24838f0 into main Feb 11, 2026
258 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/remove-nghttp2-copy-file-workaround branch February 11, 2026 10:03
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSGette JSGette JSGette approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Milestone

7.77.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdesgroppes @JSGette