Bump rules_python from 1.6.3 to 1.8.3#46017
Bump rules_python from 1.6.3 to 1.8.3#46017gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
rules_python from 1.6.3 to 1.8.3#46017Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: be89362 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.12 | [-0.95, +5.20] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.12 | [-0.95, +5.20] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.05 | [-0.44, +2.55] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.85 | [+0.73, +0.97] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.58 | [+0.49, +0.67] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.50 | [+0.34, +0.65] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.38 | [+0.32, +0.44] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.26 | [+0.19, +0.33] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.25 | [+0.20, +0.30] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.43, +0.55] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.05 | [+0.01, +0.09] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.02 | [-0.15, +0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.11, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.40, +0.37] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.12, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.03 | [-0.45, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.08, +0.00] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.17 | [-0.21, -0.12] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | -0.24 | [-0.46, -0.02] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.31 | [-0.54, -0.08] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.40 | [-0.47, -0.33] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.94 | [-1.15, -0.73] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.97 | [-1.18, -0.75] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
7d9637c to
1ed1f0f
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
On-wire sizes (compressed)
|
cdca19d to
5e67465
Compare
5e67465 to
2d89dea
Compare
### What does this PR do? Update `rules_python` from version 1.6.3 to 1.8.3 to reduce the number of DEBUG warnings seen in CI, which tends to indicate a combinatorial explosion. ### Motivation Some CI runs generate thousands of warnings like: ``` DEBUG: rules_python:pypi:create_whl_repos WARNING: Could not find a whl or an sdist with sha256=... ``` ([example](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1406186495)). While switching to version 1.8.x alone is unlikely to eliminate all warnings, it brings changes that should help reduce their frequency: - bazel-contrib/rules_python#3225 - bazel-contrib/rules_python#3385 - bazel-contrib/rules_python#3441 - bazel-contrib/rules_python#3432 - bazel-contrib/rules_python#3447 ### Additional Notes This is a mitigation/preparation step: if warning counts don't decrease significantly, the next step would be to add `target_platforms` to the `pip.parse()` configuration to explicitly limit platform checks, which is worth a dedicated PR.
2d89dea to
154b8b1
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Update
rules_pythonfrom version 1.6.3 to 1.8.3 with the aim at reducing the number of warnings seen in CI, which tend to indicate an underlying combinatorial explosion when looking for Python wheels.Motivation
Some CI runs generate thousands of warnings like:
(example).
While switching to version 1.8.x alone is unlikely to eliminate all warnings, it brings changes that should help reduce their frequency:
Describe how you validated your changes
For that, I'll be monitoring logs once the change is merged to the mainline, see why below.
Additional Notes
Coming next:
target_platformsto thepip.parse()configuration to explicitly limit platform checks, which is worth a dedicated PR,rules_pythonmust be removed onceRunfiles.CurrentRepository()raisesValueErroron Windows bazel-contrib/rules_python#3579 is addressed. Without it, we used to faceValueErrors which were preventing the version bump.