Skip to content

Bump rules_python from 1.6.3 to 1.8.3#46017

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/bump-rules-python-1.8.3
Feb 9, 2026
Merged

Bump rules_python from 1.6.3 to 1.8.3#46017
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/bump-rules-python-1.8.3

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Feb 6, 2026

What does this PR do?

Update rules_python from version 1.6.3 to 1.8.3 with the aim at reducing the number of warnings seen in CI, which tend to indicate an underlying combinatorial explosion when looking for Python wheels.

Motivation

Some CI runs generate thousands of warnings like:

DEBUG: rules_python:pypi:create_whl_repos WARNING: Could not find a whl or an sdist with sha256=...

(example).

While switching to version 1.8.x alone is unlikely to eliminate all warnings, it brings changes that should help reduce their frequency:

Describe how you validated your changes

For that, I'll be monitoring logs once the change is merged to the mainline, see why below.

Additional Notes

Coming next:

  • this is a mitigation/preparation step: if warning counts don't decrease significantly, the next step would be to add target_platforms to the pip.parse() configuration to explicitly limit platform checks, which is worth a dedicated PR,
  • even if it's tiny, the patch on rules_python must be removed once Runfiles.CurrentRepository() raises ValueError on Windows bazel-contrib/rules_python#3579 is addressed. Without it, we used to face ValueErrors which were preventing the version bump.

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Feb 6, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 6, 2026
@github-actions github-actions bot added the medium review PR review might take time label Feb 6, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review February 6, 2026 18:01
@rdesgroppes rdesgroppes requested a review from a team as a code owner February 6, 2026 18:01
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 6, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 17021740-5edb-4f10-ad29-60785a908789

Baseline: be89362
Comparison: 154b8b1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.12 [-0.95, +5.20] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.12 [-0.95, +5.20] 1 Logs
quality_gate_logs % cpu utilization +1.05 [-0.44, +2.55] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.85 [+0.73, +0.97] 1 Logs
otlp_ingest_logs memory utilization +0.58 [+0.49, +0.67] 1 Logs
otlp_ingest_metrics memory utilization +0.50 [+0.34, +0.65] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.38 [+0.32, +0.44] 1 Logs
docker_containers_memory memory utilization +0.26 [+0.19, +0.33] 1 Logs
file_tree memory utilization +0.25 [+0.20, +0.30] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.06 [-0.43, +0.55] 1 Logs
quality_gate_idle_all_features memory utilization +0.05 [+0.01, +0.09] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.02 [-0.15, +0.19] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.40, +0.37] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.12, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.45, +0.39] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.08, +0.00] 1 Logs
quality_gate_idle memory utilization -0.17 [-0.21, -0.12] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.24 [-0.46, -0.02] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.31 [-0.54, -0.08] 1 Logs
ddot_logs memory utilization -0.40 [-0.47, -0.33] 1 Logs
ddot_metrics_sum_delta memory utilization -0.94 [-1.15, -0.73] 1 Logs
quality_gate_metrics_logs memory utilization -0.97 [-1.18, -0.75] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@rdesgroppes rdesgroppes marked this pull request as draft February 7, 2026 01:23
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-rules-python-1.8.3 branch from 7d9637c to 1ed1f0f Compare February 7, 2026 01:26
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 7, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 86e0a74
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 748.898 → 754.830
agent_deb_amd64_fips N/A N/A → 709.016 → 715.320
agent_heroku_amd64 N/A N/A → 324.190 → 329.530
agent_msi N/A N/A → 660.232 → 1072.620
agent_rpm_amd64 N/A N/A → 748.881 → 754.800
agent_rpm_amd64_fips N/A N/A → 709.000 → 715.310
agent_rpm_arm64 N/A N/A → 727.975 → 737.340
agent_rpm_arm64_fips N/A N/A → 690.535 → 698.930
agent_suse_amd64 N/A N/A → 748.881 → 754.800
agent_suse_amd64_fips N/A N/A → 709.000 → 715.310
agent_suse_arm64 N/A N/A → 727.975 → 737.340
agent_suse_arm64_fips N/A N/A → 690.535 → 698.930
docker_agent_amd64 N/A N/A → 811.305 → 817.140
docker_agent_arm64 N/A N/A → 814.947 → 824.020
docker_agent_jmx_amd64 N/A N/A → 1002.217 → 1008.020
docker_agent_jmx_arm64 N/A N/A → 994.641 → 1003.620
docker_cluster_agent_amd64 N/A N/A → 180.944 → 181.200
docker_cluster_agent_arm64 N/A N/A → 196.809 → 198.490
docker_cws_instrumentation_amd64 N/A N/A → 7.135 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_dogstatsd_amd64 N/A N/A → 38.449 → 39.380
docker_dogstatsd_arm64 N/A N/A → 36.749 → 37.940
dogstatsd_deb_amd64 N/A N/A → 29.669 → 30.610
dogstatsd_deb_arm64 N/A N/A → 27.833 → 29.110
dogstatsd_rpm_amd64 N/A N/A → 29.669 → 30.610
dogstatsd_suse_amd64 N/A N/A → 29.669 → 30.610
iot_agent_deb_amd64 N/A N/A → 42.810 → 43.290
iot_agent_deb_arm64 N/A N/A → 39.923 → 40.920
iot_agent_deb_armhf N/A N/A → 40.489 → 41.030
iot_agent_rpm_amd64 N/A N/A → 42.810 → 43.290
iot_agent_suse_amd64 N/A N/A → 42.810 → 43.290
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 183.103 → 184.810
agent_deb_amd64_fips N/A N/A → 175.460 → 177.560
agent_heroku_amd64 N/A N/A → 87.110 → 88.450
agent_msi N/A N/A → 142.742 → 143.300
agent_rpm_amd64 N/A N/A → 186.254 → 188.160
agent_rpm_amd64_fips N/A N/A → 177.229 → 178.900
agent_rpm_arm64 N/A N/A → 168.083 → 169.930
agent_rpm_arm64_fips N/A N/A → 161.027 → 163.120
agent_suse_amd64 N/A N/A → 186.254 → 188.160
agent_suse_amd64_fips N/A N/A → 177.229 → 178.900
agent_suse_arm64 N/A N/A → 168.083 → 169.930
agent_suse_arm64_fips N/A N/A → 161.027 → 163.120
docker_agent_amd64 N/A N/A → 275.382 → 277.400
docker_agent_arm64 N/A N/A → 262.879 → 266.040
docker_agent_jmx_amd64 N/A N/A → 344.034 → 346.020
docker_agent_jmx_arm64 N/A N/A → 327.513 → 330.660
docker_cluster_agent_amd64 N/A N/A → 63.910 → 64.510
docker_cluster_agent_arm64 N/A N/A → 60.182 → 61.170
docker_cws_instrumentation_amd64 N/A N/A → 2.994 → 3.330
docker_cws_instrumentation_arm64 N/A N/A → 2.726 → 3.090
docker_dogstatsd_amd64 N/A N/A → 14.876 → 15.820
docker_dogstatsd_arm64 N/A N/A → 14.215 → 14.830
dogstatsd_deb_amd64 N/A N/A → 7.839 → 8.790
dogstatsd_deb_arm64 N/A N/A → 6.725 → 7.710
dogstatsd_rpm_amd64 N/A N/A → 7.848 → 8.800
dogstatsd_suse_amd64 N/A N/A → 7.848 → 8.800
iot_agent_deb_amd64 N/A N/A → 11.229 → 12.040
iot_agent_deb_arm64 N/A N/A → 9.597 → 10.450
iot_agent_deb_armhf N/A N/A → 9.796 → 10.620
iot_agent_rpm_amd64 N/A N/A → 11.246 → 12.060
iot_agent_suse_amd64 N/A N/A → 11.246 → 12.060

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-rules-python-1.8.3 branch from cdca19d to 5e67465 Compare February 8, 2026 17:30
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-rules-python-1.8.3 branch from 5e67465 to 2d89dea Compare February 9, 2026 06:30
### What does this PR do?
Update `rules_python` from version 1.6.3 to 1.8.3 to reduce the number
of DEBUG warnings seen in CI, which tends to indicate a combinatorial
explosion.

### Motivation
Some CI runs generate thousands of warnings like:
```
DEBUG: rules_python:pypi:create_whl_repos WARNING: Could not find a whl or an sdist with sha256=...
```
([example](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1406186495)).

While switching to version 1.8.x alone is unlikely to eliminate all
warnings, it brings changes that should help reduce their frequency:
- bazel-contrib/rules_python#3225
- bazel-contrib/rules_python#3385
- bazel-contrib/rules_python#3441
- bazel-contrib/rules_python#3432
- bazel-contrib/rules_python#3447

### Additional Notes
This is a mitigation/preparation step: if warning counts don't decrease
significantly, the next step would be to add `target_platforms` to the
`pip.parse()` configuration to explicitly limit platform checks, which
is worth a dedicated PR.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-rules-python-1.8.3 branch from 2d89dea to 154b8b1 Compare February 9, 2026 12:31
@rdesgroppes rdesgroppes marked this pull request as ready for review February 9, 2026 12:45
@rdesgroppes
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026

View all feedbacks in Devflow UI.

2026-02-09 12:45:51 UTC ℹ️ Start processing command /merge


2026-02-09 12:45:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-09 14:26:45 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-02-09 14:58:01 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 71c03a1 into main Feb 9, 2026
257 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/bump-rules-python-1.8.3 branch February 9, 2026 14:58
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants