Skip to content

feat: [SVLS-8340] use proper tags for the cloud run job span#45335

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
aleksandr.pasechnik/svls-8340-cloud-run-job-span-service
Jan 22, 2026
Merged

feat: [SVLS-8340] use proper tags for the cloud run job span#45335
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
aleksandr.pasechnik/svls-8340-cloud-run-job-span-service

Conversation

@apiarian-datadog

@apiarian-datadog apiarian-datadog commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix tag handling for the cloud run job span.

Motivation

We spotted an issue with the incorrect service on the span. Looks like we were missing a bunch of tags.

Describe how you validated your changes

Unit tests and checked with a live deployed cloud run test job.

@apiarian-datadog
apiarian-datadog requested a review from a team as a code owner January 21, 2026 20:09
@github-actions github-actions Bot added the medium review PR review might take time label Jan 21, 2026
@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Jan 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2958846
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 752.713 MiB
✅ agent_deb_amd64_fips 701.415 MiB
✅ agent_heroku_amd64 326.766 MiB
✅ agent_msi 662.391 MiB
✅ agent_rpm_amd64 752.697 MiB
✅ agent_rpm_amd64_fips 701.398 MiB
✅ agent_rpm_arm64 731.516 MiB
✅ agent_rpm_arm64_fips 683.520 MiB
✅ agent_suse_amd64 752.697 MiB
✅ agent_suse_amd64_fips 701.398 MiB
✅ agent_suse_arm64 731.516 MiB
✅ agent_suse_arm64_fips 683.520 MiB
✅ docker_agent_amd64 814.830 MiB
✅ docker_agent_arm64 818.224 MiB
✅ docker_agent_jmx_amd64 1005.709 MiB
✅ docker_agent_jmx_arm64 997.822 MiB
✅ docker_cluster_agent_amd64 181.009 MiB
✅ docker_cluster_agent_arm64 196.854 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.812 MiB
✅ docker_dogstatsd_arm64 37.128 MiB
✅ dogstatsd_deb_amd64 30.039 MiB
✅ dogstatsd_deb_arm64 28.184 MiB
✅ dogstatsd_rpm_amd64 30.039 MiB
✅ dogstatsd_suse_amd64 30.039 MiB
✅ iot_agent_deb_amd64 42.978 MiB
✅ iot_agent_deb_arm64 40.084 MiB
✅ iot_agent_deb_armhf 40.654 MiB
✅ iot_agent_rpm_amd64 42.979 MiB
✅ iot_agent_suse_amd64 42.979 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +8.07 KiB (0.00% increase) 183.725 → 183.733 → 184.810
✅ agent_deb_amd64_fips -8.03 KiB (0.00% reduction) 172.444 → 172.436 → 173.790
✅ agent_heroku_amd64 +2.86 KiB (0.00% increase) 87.094 → 87.097 → 88.450
✅ agent_msi +20.0 KiB (0.01% increase) 142.969 → 142.988 → 143.300
✅ agent_rpm_amd64 +26.71 KiB (0.01% increase) 186.954 → 186.980 → 188.160
✅ agent_rpm_amd64_fips +9.61 KiB (0.01% increase) 175.338 → 175.347 → 176.600
✅ agent_rpm_arm64 +15.46 KiB (0.01% increase) 168.349 → 168.365 → 169.930
✅ agent_rpm_arm64_fips -23.41 KiB (0.01% reduction) 158.992 → 158.969 → 160.550
✅ agent_suse_amd64 +26.71 KiB (0.01% increase) 186.954 → 186.980 → 188.160
✅ agent_suse_amd64_fips +9.61 KiB (0.01% increase) 175.338 → 175.347 → 176.600
✅ agent_suse_arm64 +15.46 KiB (0.01% increase) 168.349 → 168.365 → 169.930
✅ agent_suse_arm64_fips -23.41 KiB (0.01% reduction) 158.992 → 158.969 → 160.550
✅ docker_agent_amd64 neutral 276.405 MiB → 277.400
✅ docker_agent_arm64 +5.9 KiB (0.00% increase) 263.868 → 263.874 → 266.040
✅ docker_agent_jmx_amd64 neutral 345.051 MiB → 346.020
✅ docker_agent_jmx_arm64 +2.92 KiB (0.00% increase) 328.487 → 328.490 → 330.660
✅ docker_cluster_agent_amd64 neutral 63.958 MiB → 64.490
✅ docker_cluster_agent_arm64 neutral 60.220 MiB → 61.170
✅ docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 15.021 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.344 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.936 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.819 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.948 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.948 MiB → 8.800
✅ iot_agent_deb_amd64 -3.29 KiB (0.03% reduction) 11.279 → 11.276 → 12.040
✅ iot_agent_deb_arm64 neutral 9.639 MiB → 10.450
✅ iot_agent_deb_armhf neutral 9.838 MiB → 10.620
✅ iot_agent_rpm_amd64 neutral 11.294 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.294 MiB → 12.060

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jan 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 58e11dfe-add1-47d4-bfee-c3d10d39f814

Baseline: 2958846
Comparison: 74de54a
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization -1.39 [-4.34, +1.55] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +2.29 [+0.77, +3.82] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +1.07 [+0.98, +1.15] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.85 [+0.63, +1.07] 1 Logs bounds checks dashboard
➖ file_tree memory utilization +0.55 [+0.50, +0.61] 1 Logs
➖ otlp_ingest_logs memory utilization +0.50 [+0.40, +0.61] 1 Logs
➖ docker_containers_memory memory utilization +0.26 [+0.18, +0.33] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.14 [-0.02, +0.31] 1 Logs
➖ quality_gate_idle memory utilization +0.02 [-0.03, +0.06] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.53, +0.55] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.11, +0.13] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.09, +0.09] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.05, +0.04] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.14, +0.12] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.42, +0.39] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.40, +0.37] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.12 [-0.16, -0.09] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.13 [-0.19, -0.08] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.35 [-0.58, -0.12] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.41 [-0.56, -0.26] 1 Logs
➖ ddot_metrics memory utilization -0.56 [-0.77, -0.34] 1 Logs
➖ ddot_logs memory utilization -0.70 [-0.77, -0.63] 1 Logs
➖ ddot_metrics_sum_delta memory utilization -0.72 [-0.92, -0.52] 1 Logs
➖ docker_containers_cpu % cpu utilization -1.39 [-4.34, +1.55] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Lewis-E
Lewis-E reviewed Jan 21, 2026
View reviewed changes
Comment thread cmd/serverless-init/trace/trace.go
@Lewis-E

Lewis-E commented Jan 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code here makes sense in of itself and in the context of the earlier PRs, but a couple of questions so I can understand properly:

  1. What is MakeTraceAgentTags doing with all the tags we're then also sending in the TraceContext?
  2. Which tags were missing, or was it just the wrong jobNameTag?
  3. What were the other designs you considered and also disliked? (Because I had that move init back to L127 change in mind for later...)

@apiarian-datadog apiarian-datadog mentioned this pull request Jan 21, 2026
Closed
@apiarian-datadog

apiarian-datadog commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Code here makes sense in of itself and in the context of the earlier PRs, but a couple of questions so I can understand properly:

  1. What is MakeTraceAgentTags doing with all the tags we're then also sending in the TraceContext?

Those tags are applied to spans and traces. Though now that I look at it more, I think we should probably be using the trace agent tags for our span tags, not the base tags.

  1. Which tags were missing, or was it just the wrong jobNameTag?

This work was prompted by a missing service tag which meant that the service was being set incorrectly for the span we were generating. But we were also missing the version and env. So now we just get all the tags

  1. What were the other designs you considered and also disliked? (Because I had that move init back to L127 change in mind for later...)

I briefly poked at the cloud service api to try to remove the parameters to init entirely, but that ended up with a more complex GetCloudServiceType shape that I didn't like. Happy to explore other options tho, since I still don't like this structure. Tho a big refactor is probably not in the cards for our cloud service constructs.

@apiarian-datadog
apiarian-datadog force-pushed the aleksandr.pasechnik/svls-8340-cloud-run-job-span-service branch from 16ce215 to 74de54a Compare January 22, 2026 17:22
@apiarian-datadog

apiarian-datadog commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

testing with serverless-init e2e tests: https://gitlab.ddbuild.io/DataDog/serverless-e2e-serverless-init-gcp-tests/-/pipelines/92337502(some unrelated test failures, but otherwise looks good.)

@apiarian-datadog apiarian-datadog added the qa/done QA done before merge and regressions are covered by tests label Jan 22, 2026
@apiarian-datadog

apiarian-datadog commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-22 21:30:51 UTC ℹ️ Start processing command /merge

2026-01-22 21:30:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 60m (p90).

2026-01-22 22:19:56 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f794755 into main Jan 22, 2026
343 of 344 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the aleksandr.pasechnik/svls-8340-cloud-run-job-span-service branch January 22, 2026 22:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 22, 2026
@github-actions github-actions Bot added this to the 7.76.0 milestone Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lewis-E Lewis-E Lewis-E approved these changes
@duncanpharvey duncanpharvey duncanpharvey approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/serverless-azure-gcp

Projects

None yet

Milestone

7.76.0

Development

Successfully merging this pull request may close these issues.

3 participants

@apiarian-datadog @Lewis-E @duncanpharvey