Skip to content

Bump bazel_lib from 3.0.1 to 3.1.1#45220

Merged
dd-mergequeue[bot] merged 1 commit intomainfrom
regis.desgroppes/bazel-lib-3.1.1
Jan 19, 2026
Merged

Bump bazel_lib from 3.0.1 to 3.1.1#45220
dd-mergequeue[bot] merged 1 commit intomainfrom
regis.desgroppes/bazel-lib-3.1.1

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Jan 19, 2026

What does this PR do?

This upgrade includes a Windows compatibility fix for batch file line endings (bazel-contrib/bazel-lib#1222), which resolves a cmd parsing bug where GOTO/CALL to labels fails when batch files use non CRLF-only line endings and a label crosses a 512-byte boundary:

> bazel test //deps/openssl3:module_consistency_test
[...]
==================== Test output for //deps/openssl3:module_consistency_test:
-The system cannot find the batch label specified - compare_files
+compare_files
+FAIL: files "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" and "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel" differ.
+
+
+@@//deps/openssl3:openssl3.MODULE.bazel is out of date. To update this file, run:
+
+    bazel run //deps/openssl3:module_consistency
+To see differences run:
+
+    diff "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel"
+
================================================================================

Because this now surfaces we'd been generating *.MODULE.bazel with OS-specific newlines, the present change fixes it by always issuing UNIX-style newlines:

> bazel test //deps/openssl3:module_consistency_test
[...]
//deps/openssl3:module_consistency_test                                  PASSED in 0.4s

Motivation

Keep up to date and better support colleagues working on Windows.

Describe how you validated your changes

Locally for the time being because we still have very limited test coverage due to #44455 being disputed.

Additional Notes

bazel_lib 3.1.0/3.1.1 comes with further improvements, like:

This upgrade includes a Windows compatibility fix for batch file line
endings (bazel-contrib/bazel-lib#1222), which resolves a cmd parsing bug
where GOTO/CALL to labels fails when batch files use non CRLF-only line
endings and a label crosses a 512-byte boundary:
```diff
$ bazel test //deps/openssl3:module_consistency_test
[...]
==================== Test output for //deps/openssl3:module_consistency_test:
-The system cannot find the batch label specified - compare_files
+compare_files
+FAIL: files "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" and "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel" differ.
+
+
+@@//deps/openssl3:openssl3.MODULE.bazel is out of date. To update this file, run:
+
+    bazel run //deps/openssl3:module_consistency
+To see differences run:
+
+    diff "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel"
+
================================================================================
```

Because this now surfaces we'd been generating `*.MODULE.bazel` with
OS-specific newlines, the present change fixes it by always issuing
UNIX-style newlines:
```sh
$ bazel test //deps/openssl3:module_consistency_test
[...]
//deps/openssl3:module_consistency_test                                  PASSED in 0.4s
```

`bazel_lib` 3.1.1 comes with further improvements, like:
- bazel-contrib/bazel-lib#1217
- bazel-contrib/bazel-lib#1220
- bazel-contrib/bazel-lib#1232
@rdesgroppes rdesgroppes added the changelog/no-changelog No changelog entry needed label Jan 19, 2026
@rdesgroppes rdesgroppes requested a review from a team as a code owner January 19, 2026 14:25
@rdesgroppes rdesgroppes added qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Jan 19, 2026
@rdesgroppes rdesgroppes changed the title bazel: bump bazel_lib from 3.0.1 to 3.1.1 Bump bazel_lib from 3.0.1 to 3.1.1 Jan 19, 2026
@github-actions github-actions bot added team/agent-build short review PR is simple enough to be reviewed quickly labels Jan 19, 2026
@rdesgroppes rdesgroppes added ask-review Ask required teams to review this PR and removed ask-review Ask required teams to review this PR labels Jan 19, 2026
@rdesgroppes
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Jan 19, 2026

View all feedbacks in Devflow UI.

2026-01-19 15:38:42 UTC ℹ️ Start processing command /merge


2026-01-19 15:38:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-19 16:31:28 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 58m (p90).


2026-01-19 17:07:30 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 74672ff
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 704.607 MiB
agent_deb_amd64_fips 699.904 MiB
agent_heroku_amd64 327.121 MiB
agent_msi 571.923 MiB
agent_rpm_amd64 704.594 MiB
agent_rpm_amd64_fips 699.891 MiB
agent_rpm_arm64 685.963 MiB
agent_rpm_arm64_fips 682.101 MiB
agent_suse_amd64 704.594 MiB
agent_suse_amd64_fips 699.891 MiB
agent_suse_arm64 685.963 MiB
agent_suse_arm64_fips 682.101 MiB
docker_agent_amd64 766.750 MiB
docker_agent_arm64 772.734 MiB
docker_agent_jmx_amd64 957.629 MiB
docker_agent_jmx_arm64 952.332 MiB
docker_cluster_agent_amd64 180.749 MiB
docker_cluster_agent_arm64 196.602 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.843 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.066 MiB
dogstatsd_deb_arm64 28.211 MiB
dogstatsd_rpm_amd64 30.066 MiB
dogstatsd_suse_amd64 30.066 MiB
iot_agent_deb_amd64 43.128 MiB
iot_agent_deb_arm64 40.241 MiB
iot_agent_deb_armhf 40.826 MiB
iot_agent_rpm_amd64 43.128 MiB
iot_agent_suse_amd64 43.128 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -5.16 KiB (0.00% reduction) 173.288 → 173.283 → 174.490
agent_deb_amd64_fips -38.85 KiB (0.02% reduction) 172.262 → 172.224 → 173.750
agent_heroku_amd64 neutral 87.148 MiB
agent_msi -24.0 KiB (0.02% reduction) 143.035 → 143.012 → 143.020
agent_rpm_amd64 -15.15 KiB (0.01% reduction) 176.368 → 176.353 → 177.660
agent_rpm_amd64_fips -9.57 KiB (0.01% reduction) 174.706 → 174.696 → 176.600
agent_rpm_arm64 neutral 159.460 MiB
agent_rpm_arm64_fips -23.91 KiB (0.01% reduction) 158.941 → 158.918 → 160.550
agent_suse_amd64 -15.15 KiB (0.01% reduction) 176.368 → 176.353 → 177.660
agent_suse_amd64_fips -9.57 KiB (0.01% reduction) 174.706 → 174.696 → 176.600
agent_suse_arm64 neutral 159.460 MiB
agent_suse_arm64_fips -23.91 KiB (0.01% reduction) 158.941 → 158.918 → 160.550
docker_agent_amd64 neutral 260.883 MiB
docker_agent_arm64 neutral 249.884 MiB
docker_agent_jmx_amd64 neutral 329.526 MiB
docker_agent_jmx_arm64 neutral 314.505 MiB
docker_cluster_agent_amd64 neutral 63.863 MiB
docker_cluster_agent_arm64 neutral 60.133 MiB
docker_cws_instrumentation_amd64 neutral 2.995 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.037 MiB
docker_dogstatsd_arm64 neutral 14.363 MiB
dogstatsd_deb_amd64 neutral 7.951 MiB
dogstatsd_deb_arm64 neutral 6.826 MiB
dogstatsd_rpm_amd64 neutral 7.962 MiB
dogstatsd_suse_amd64 neutral 7.962 MiB
iot_agent_deb_amd64 neutral 11.300 MiB
iot_agent_deb_arm64 +2.15 KiB (0.02% increase) 9.660 → 9.662 → 10.450
iot_agent_deb_armhf +2.45 KiB (0.02% increase) 9.859 → 9.862 → 10.620
iot_agent_rpm_amd64 neutral 11.320 MiB
iot_agent_suse_amd64 neutral 11.320 MiB

@cit-pr-commenter
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c7b612bd-312f-4f4c-beb6-1608c9bda39e

Baseline: 74672ff
Comparison: fb75233
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.39 [-4.35, +1.56] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +2.15 [+2.08, +2.21] 1 Logs
quality_gate_logs % cpu utilization +1.55 [+0.06, +3.04] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.86 [+0.64, +1.07] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.50 [+0.35, +0.66] 1 Logs
ddot_metrics memory utilization +0.31 [+0.10, +0.53] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.19 [-0.04, +0.42] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.13 [+0.08, +0.19] 1 Logs
file_tree memory utilization +0.08 [+0.02, +0.14] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.01, +0.08] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.46, +0.51] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.40, +0.43] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.09] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.04, +0.05] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.46, +0.32] 1 Logs
otlp_ingest_metrics memory utilization -0.12 [-0.27, +0.03] 1 Logs
docker_containers_memory memory utilization -0.34 [-0.41, -0.27] 1 Logs
quality_gate_idle_all_features memory utilization -0.46 [-0.50, -0.43] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.56 [-0.65, -0.46] 1 Logs
ddot_metrics_sum_delta memory utilization -0.87 [-1.07, -0.67] 1 Logs
ddot_logs memory utilization -0.92 [-1.00, -0.84] 1 Logs
docker_containers_cpu % cpu utilization -1.39 [-4.35, +1.56] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x3) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 00dd24f into main Jan 19, 2026
323 of 325 checks passed
@dd-mergequeue dd-mergequeue bot deleted the regis.desgroppes/bazel-lib-3.1.1 branch January 19, 2026 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2026
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants